From 3db4626d6ec21518682d38bd259a80c76f759be5 Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Thu, 1 Aug 2024 21:53:44 +0300 Subject: [PATCH v3 03/12] Fix comment on processes being kept over a restart All child processes except the syslogger are killed on a restart. The archiver might be already running though, if it was started during recovery. The split in the comments between "other special children" and the first group of "background tasks" seemed really arbitrary, so I just merged them all into one group. --- src/backend/postmaster/postmaster.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c index 6e753f3865..b0152a0068 100644 --- a/src/backend/postmaster/postmaster.c +++ b/src/backend/postmaster/postmaster.c @@ -2386,9 +2386,9 @@ process_pm_child_exit(void) connsAllowed = true; /* - * Crank up the background tasks, if we didn't do that already - * when we entered consistent recovery state. It doesn't matter - * if this fails, we'll just try again later. + * Crank up any background tasks that we didn't start earlier + * already. It doesn't matter if any of these fail, we'll just + * try again later. */ if (CheckpointerPID == 0) CheckpointerPID = StartChildProcess(B_CHECKPOINTER); @@ -2397,18 +2397,11 @@ process_pm_child_exit(void) if (WalWriterPID == 0) WalWriterPID = StartChildProcess(B_WAL_WRITER); MaybeStartWalSummarizer(); - - /* - * Likewise, start other special children as needed. In a restart - * situation, some of them may be alive already. - */ if (!IsBinaryUpgrade && AutoVacuumingActive() && AutoVacPID == 0) AutoVacPID = StartChildProcess(B_AUTOVAC_LAUNCHER); if (PgArchStartupAllowed() && PgArchPID == 0) PgArchPID = StartChildProcess(B_ARCHIVER); MaybeStartSlotSyncWorker(); - - /* workers may be scheduled to start now */ maybe_start_bgworkers(); /* at this point we are really open for business */ -- 2.39.2