From 4a9967e55cc1b9821c9bd2f16dddfdb0854d8363 Mon Sep 17 00:00:00 2001 From: Anthonin Bonnefoy Date: Tue, 30 Jul 2024 08:39:15 +0200 Subject: [PATCH v8] Add WAL usage reporting to ANALYZE. This change adds WAL usage reporting to the output of ANALYZE VERBOSE and autoanalyze reports. It aligns the analyze output with VACUUM, providing consistency. Additionally, it aids in troubleshooting cases where unexpected WAL records are generated during analyze operations. Author: Anthonin Bonnefoy Reviewed-by: Masahiko Sawada Discussion: https://postgr.es/m/CAO6_Xqr__kTTCLkftqS0qSCm-J7_xbRG3Ge2rWhucxQJMJhcRA%40mail.gmail.com --- src/backend/commands/analyze.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/backend/commands/analyze.c b/src/backend/commands/analyze.c index 902eb1a450..38fb4c3ef2 100644 --- a/src/backend/commands/analyze.c +++ b/src/backend/commands/analyze.c @@ -305,6 +305,7 @@ do_analyze_rel(Relation onerel, VacuumParams *params, Oid save_userid; int save_sec_context; int save_nestlevel; + WalUsage startwalusage = pgWalUsage; BufferUsage startbufferusage = pgBufferUsage; BufferUsage bufferusage; PgStat_Counter startreadtime = 0; @@ -740,6 +741,7 @@ do_analyze_rel(Relation onerel, VacuumParams *params, params->log_min_duration)) { long delay_in_ms; + WalUsage walusage; double read_rate = 0; double write_rate = 0; char *msgfmt; @@ -750,6 +752,8 @@ do_analyze_rel(Relation onerel, VacuumParams *params, memset(&bufferusage, 0, sizeof(BufferUsage)); BufferUsageAccumDiff(&bufferusage, &pgBufferUsage, &startbufferusage); + memset(&walusage, 0, sizeof(WalUsage)); + WalUsageAccumDiff(&walusage, &pgWalUsage, &startwalusage); total_blks_hit = bufferusage.shared_blks_hit + bufferusage.local_blks_hit; @@ -818,6 +822,11 @@ do_analyze_rel(Relation onerel, VacuumParams *params, (long long) total_blks_hit, (long long) total_blks_read, (long long) total_blks_dirtied); + appendStringInfo(&buf, + _("WAL usage: %lld records, %lld full page images, %llu bytes\n"), + (long long) walusage.wal_records, + (long long) walusage.wal_fpi, + (unsigned long long) walusage.wal_bytes); appendStringInfo(&buf, _("system usage: %s"), pg_rusage_show(&ru0)); ereport(verbose ? INFO : LOG, -- 2.39.3