From fab0575ef1350cb700b6fc079230397ecb5ca19d Mon Sep 17 00:00:00 2001 From: Ilia Evdokimov Date: Mon, 19 Aug 2024 12:08:53 +0300 Subject: [PATCH] Remove redundant NULL check for clause during selectivity calculation The function clause_selectivity_ext() takes a Node *clause parameter, which is either iterated over in a loop with other clauses or passed as a RestrictInfo from other functions. Since these functions guarantee that clause cannot be NULL, the NULL check is unnecessary and has been removed. --- src/backend/optimizer/path/clausesel.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/backend/optimizer/path/clausesel.c b/src/backend/optimizer/path/clausesel.c index 0ab021c1e8..5992f96ed2 100644 --- a/src/backend/optimizer/path/clausesel.c +++ b/src/backend/optimizer/path/clausesel.c @@ -692,9 +692,6 @@ clause_selectivity_ext(PlannerInfo *root, RestrictInfo *rinfo = NULL; bool cacheable = false; - if (clause == NULL) /* can this still happen? */ - return s1; - if (IsA(clause, RestrictInfo)) { rinfo = (RestrictInfo *) clause; -- 2.34.1