From e05cf468cab4003baa510053ff921063ca32c19a Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Thu, 27 Jul 2023 18:59:25 -0700 Subject: [PATCH v2.0 01/17] bufmgr: Return early in ScheduleBufferTagForWriteback() if fsync=off Author: Reviewed-by: Discussion: https://postgr.es/m/ Backpatch: --- src/backend/storage/buffer/bufmgr.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c index 5cdd2f10fc8..ec957635f2a 100644 --- a/src/backend/storage/buffer/bufmgr.c +++ b/src/backend/storage/buffer/bufmgr.c @@ -5926,7 +5926,12 @@ ScheduleBufferTagForWriteback(WritebackContext *wb_context, IOContext io_context { PendingWriteback *pending; - if (io_direct_flags & IO_DIRECT_DATA) + /* + * As pg_flush_data() doesn't do anything with fsync disabled, there's no + * point in tracking in that case. + */ + if (io_direct_flags & IO_DIRECT_DATA || + !enableFsync) return; /* -- 2.45.2.827.g557ae147e6