From 320e54894a1ad45e2c25a4ee88a6409a9dc1a527 Mon Sep 17 00:00:00 2001 From: Soumyadeep Chakraborty Date: Sat, 5 Oct 2024 16:22:56 -0700 Subject: [PATCH v1 1/1] Use heap_getnext() in vac_update_datfrozenxid() Since we are going to do a full sequential scan without a filter, we can avoid overhead from the extra layers of sysscan. --- src/backend/commands/vacuum.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/backend/commands/vacuum.c b/src/backend/commands/vacuum.c index ac8f5d9c25..717e310054 100644 --- a/src/backend/commands/vacuum.c +++ b/src/backend/commands/vacuum.c @@ -1588,7 +1588,7 @@ vac_update_datfrozenxid(void) HeapTuple tuple; Form_pg_database dbform; Relation relation; - SysScanDesc scan; + TableScanDesc scan; HeapTuple classTup; TransactionId newFrozenXid; MultiXactId newMinMulti; @@ -1638,10 +1638,9 @@ vac_update_datfrozenxid(void) */ relation = table_open(RelationRelationId, AccessShareLock); - scan = systable_beginscan(relation, InvalidOid, false, - NULL, 0, NULL); + scan = table_beginscan_catalog(relation, 0, NULL); - while ((classTup = systable_getnext(scan)) != NULL) + while ((classTup = heap_getnext(scan, ForwardScanDirection)) != NULL) { volatile FormData_pg_class *classForm = (Form_pg_class) GETSTRUCT(classTup); TransactionId relfrozenxid = classForm->relfrozenxid; @@ -1707,7 +1706,7 @@ vac_update_datfrozenxid(void) } /* we're done with pg_class */ - systable_endscan(scan); + table_endscan(scan); table_close(relation, AccessShareLock); /* chicken out if bogus data found */ -- 2.43.0