From 70f67eec099bc2fd97aedc71c894ca6e54add4b5 Mon Sep 17 00:00:00 2001 From: Ashutosh Bapat Date: Mon, 21 Oct 2024 14:42:26 +0530 Subject: [PATCH 1/2] Add test to cover aclcheck_error_col() The error message "permission denied for column \"%s\" of relation \"%s\"" is not in any of the expected output even though it's simple to trigger this error message. Add a test for the same so as to improve test coverage of this particular error. Author: Ashutosh Bapat Discussion: https://postgr.es/m/CAExHW5swFANiB9JmqRoGg_Rkr%2BM%3Dqh%2Bci_zfOtQXFT%2BA%3D%2BjB-A%40mail.gmail.com --- src/test/regress/expected/privileges.out | 2 ++ src/test/regress/sql/privileges.sql | 1 + 2 files changed, 3 insertions(+) diff --git a/src/test/regress/expected/privileges.out b/src/test/regress/expected/privileges.out index 1d903babd33..2787d9d6ce8 100644 --- a/src/test/regress/expected/privileges.out +++ b/src/test/regress/expected/privileges.out @@ -512,6 +512,8 @@ EXPLAIN (COSTS OFF) SELECT * FROM atest12sbv x, atest12sbv y Filter: (b <<< 5) (8 rows) +GRANT SELECT (a, b) ON atest12 TO PUBLIC; -- fails +ERROR: permission denied for column "a" of relation "atest12" -- Now regress_priv_user1 grants sufficient access to regress_priv_user2. SET SESSION AUTHORIZATION regress_priv_user1; GRANT SELECT (a, b) ON atest12 TO PUBLIC; diff --git a/src/test/regress/sql/privileges.sql b/src/test/regress/sql/privileges.sql index 3f54b0f8f05..9c38b5a83f5 100644 --- a/src/test/regress/sql/privileges.sql +++ b/src/test/regress/sql/privileges.sql @@ -334,6 +334,7 @@ EXPLAIN (COSTS OFF) SELECT * FROM atest12v x, atest12v y EXPLAIN (COSTS OFF) SELECT * FROM atest12sbv x, atest12sbv y WHERE x.a = y.b and abs(y.a) <<< 5; +GRANT SELECT (a, b) ON atest12 TO PUBLIC; -- fails -- Now regress_priv_user1 grants sufficient access to regress_priv_user2. SET SESSION AUTHORIZATION regress_priv_user1; GRANT SELECT (a, b) ON atest12 TO PUBLIC; -- 2.34.1