From 36e5c10105d934da0d51474b0ad7c5bd9087e2aa Mon Sep 17 00:00:00 2001 From: Vignesh Date: Wed, 11 Dec 2024 08:57:06 +0530 Subject: [PATCH v1] Fix memory leak in pgoutput relation attribute map The pgoutput module caches relation attribute map and frees it upon invalidation. However, this was not getting freed incase of SQL functions like pg_logical_slot_{get,peek}_changes() which would bloat its cache memory usage. Every pg_logical_slot_{get,peek}_changes() call for changes on partition table creates more bloat. To address this, this relation attribute map is freed while the output plugin is shutdown. --- src/backend/replication/pgoutput/pgoutput.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/backend/replication/pgoutput/pgoutput.c b/src/backend/replication/pgoutput/pgoutput.c index b50b3d62e3..f1ef13d313 100644 --- a/src/backend/replication/pgoutput/pgoutput.c +++ b/src/backend/replication/pgoutput/pgoutput.c @@ -1747,6 +1747,16 @@ pgoutput_shutdown(LogicalDecodingContext *ctx) { if (RelationSyncCache) { + RelationSyncEntry *entry; + HASH_SEQ_STATUS status; + + hash_seq_init(&status, RelationSyncCache); + while ((entry = (RelationSyncEntry *) hash_seq_search(&status)) != NULL) + { + if (entry->attrmap) + free_attrmap(entry->attrmap); + } + hash_destroy(RelationSyncCache); RelationSyncCache = NULL; } -- 2.43.0