From a83def4ca95c154e824378452cb15f100887a56c Mon Sep 17 00:00:00 2001 From: Bertrand Drouvot Date: Fri, 20 Dec 2024 08:59:53 +0000 Subject: [PATCH v1] Fix per-backend IO stats regression test The tests added in 9aea73fc61 did not take into account that the backend can fsync in some circumstances. --- src/test/regress/expected/stats.out | 3 +-- src/test/regress/sql/stats.sql | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) 50.0% src/test/regress/expected/ 50.0% src/test/regress/sql/ diff --git a/src/test/regress/expected/stats.out b/src/test/regress/expected/stats.out index 150b6dcf74..d18fc7c081 100644 --- a/src/test/regress/expected/stats.out +++ b/src/test/regress/expected/stats.out @@ -1329,8 +1329,7 @@ SELECT :my_io_sum_shared_after_writes >= :my_io_sum_shared_before_writes; (1 row) SELECT current_setting('fsync') = 'off' - OR (:my_io_sum_shared_after_fsyncs = :my_io_sum_shared_before_fsyncs - AND :my_io_sum_shared_after_fsyncs= 0); + OR :my_io_sum_shared_after_fsyncs >= :my_io_sum_shared_before_fsyncs; ?column? ---------- t diff --git a/src/test/regress/sql/stats.sql b/src/test/regress/sql/stats.sql index 1e7d0ff665..fc0d2fde31 100644 --- a/src/test/regress/sql/stats.sql +++ b/src/test/regress/sql/stats.sql @@ -648,8 +648,7 @@ SELECT sum(writes) AS writes, sum(fsyncs) AS fsyncs WHERE object = 'relation' \gset my_io_sum_shared_after_ SELECT :my_io_sum_shared_after_writes >= :my_io_sum_shared_before_writes; SELECT current_setting('fsync') = 'off' - OR (:my_io_sum_shared_after_fsyncs = :my_io_sum_shared_before_fsyncs - AND :my_io_sum_shared_after_fsyncs= 0); + OR :my_io_sum_shared_after_fsyncs >= :my_io_sum_shared_before_fsyncs; -- Change the tablespace so that the table is rewritten directly, then SELECT -- from it to cause it to be read back into shared buffers. -- 2.34.1