From abf964263e5de78d44f6235f90789cfe5143b534 Mon Sep 17 00:00:00 2001 From: Vignesh Date: Thu, 26 Dec 2024 11:37:43 +0530 Subject: [PATCH v2] Fix memory leak in pgoutput relation attribute map The pgoutput module caches relation attribute map only when validating the RelationSyncEntry. However, this was not getting freed incase of SQL functions like pg_logical_slot_{get,peek}_changes() which would bloat its cache memory usage. Every pg_logical_slot_{get,peek}_changes() call for changes on partition table creates more bloat. To address this, this relation attribute map is allocated in the plugin's cachectx which will be freed while the context is freed at the end of pg_logical_slot_{get,peek}_changes() execution. --- src/backend/replication/pgoutput/pgoutput.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/replication/pgoutput/pgoutput.c b/src/backend/replication/pgoutput/pgoutput.c index 6db780d733..6c19cc1bb2 100644 --- a/src/backend/replication/pgoutput/pgoutput.c +++ b/src/backend/replication/pgoutput/pgoutput.c @@ -1197,8 +1197,8 @@ init_tuple_slot(PGOutputData *data, Relation relation, TupleDesc indesc = RelationGetDescr(relation); TupleDesc outdesc = RelationGetDescr(ancestor); - /* Map must live as long as the session does. */ - oldctx = MemoryContextSwitchTo(CacheMemoryContext); + /* Map must live as long as the logical decoding context. */ + oldctx = MemoryContextSwitchTo(data->cachectx); entry->attrmap = build_attrmap_by_name_if_req(indesc, outdesc, false); -- 2.43.0