From b2770262caaf5c4beadf16ed168746b475f00d68 Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Fri, 20 Dec 2024 00:36:33 +0200 Subject: [PATCH v1 2/3] Add assertions --- src/backend/utils/time/snapmgr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/backend/utils/time/snapmgr.c b/src/backend/utils/time/snapmgr.c index 3900e1452ca..76992eb094f 100644 --- a/src/backend/utils/time/snapmgr.c +++ b/src/backend/utils/time/snapmgr.c @@ -595,6 +595,7 @@ CopySnapshot(Snapshot snapshot) Size size; Assert(snapshot != InvalidSnapshot); + Assert(snapshot->snapshot_type == SNAPSHOT_MVCC || snapshot->snapshot_type == SNAPSHOT_HISTORIC_MVCC); /* We allocate any XID arrays needed in the same palloc block. */ size = subxipoff = sizeof(SnapshotData) + @@ -680,6 +681,8 @@ PushActiveSnapshotWithLevel(Snapshot snapshot, int snap_level) { ActiveSnapshotElt *newactive; + Assert(snapshot->snapshot_type == SNAPSHOT_MVCC); + Assert(snapshot != InvalidSnapshot); Assert(ActiveSnapshot == NULL || snap_level >= ActiveSnapshot->as_level); @@ -824,6 +827,8 @@ RegisterSnapshotOnOwner(Snapshot snapshot, ResourceOwner owner) if (snapshot == InvalidSnapshot) return InvalidSnapshot; + Assert(snapshot->snapshot_type == SNAPSHOT_MVCC || snapshot->snapshot_type == SNAPSHOT_HISTORIC_MVCC); + /* Static snapshot? Create a persistent copy */ snap = snapshot->copied ? snapshot : CopySnapshot(snapshot); -- 2.39.5