From 93a4d4a7e2219a952c2a544047c19db9f0f0f5c0 Mon Sep 17 00:00:00 2001 From: Yura Sokolov Date: Thu, 16 Jan 2025 15:06:59 +0300 Subject: [PATCH v0 1/2] Increase NUM_XLOGINSERT_LOCKS to 64 --- src/backend/access/transam/xlog.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index bf3dbda901d..39381693db6 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -147,7 +147,7 @@ int wal_segment_size = DEFAULT_XLOG_SEG_SIZE; * to happen concurrently, but adds some CPU overhead to flushing the WAL, * which needs to iterate all the locks. */ -#define NUM_XLOGINSERT_LOCKS 8 +#define NUM_XLOGINSERT_LOCKS 64 /* * Max distance from last checkpoint, before triggering a new xlog-based @@ -1448,7 +1448,11 @@ WALInsertLockRelease(void) { int i; - for (i = 0; i < NUM_XLOGINSERT_LOCKS; i++) + /* + * LWLockRelease hopes we will release in reverse order for faster + * search in held_lwlocks. + */ + for (i = NUM_XLOGINSERT_LOCKS - 1; i >= 0; i--) LWLockReleaseClearVar(&WALInsertLocks[i].l.lock, &WALInsertLocks[i].l.insertingAt, 0); -- 2.43.0