From 4507a8ca905a9272bad59198f93e01e40da87451 Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Wed, 22 Jan 2025 13:44:54 -0500 Subject: [PATCH v2.3 27/30] very-wip: test_aio module Author: Reviewed-by: Discussion: https://postgr.es/m/ Backpatch: --- src/include/storage/aio_internal.h | 8 + src/include/storage/buf_internals.h | 4 + src/backend/storage/aio/aio.c | 39 ++ src/backend/storage/buffer/bufmgr.c | 3 +- src/test/modules/Makefile | 1 + src/test/modules/meson.build | 1 + src/test/modules/test_aio/.gitignore | 6 + src/test/modules/test_aio/Makefile | 34 ++ src/test/modules/test_aio/expected/inject.out | 295 ++++++++++ src/test/modules/test_aio/expected/io.out | 40 ++ .../modules/test_aio/expected/ownership.out | 148 +++++ src/test/modules/test_aio/expected/prep.out | 17 + src/test/modules/test_aio/io_uring.conf | 5 + src/test/modules/test_aio/meson.build | 78 +++ src/test/modules/test_aio/sql/inject.sql | 84 +++ src/test/modules/test_aio/sql/io.sql | 16 + src/test/modules/test_aio/sql/ownership.sql | 65 +++ src/test/modules/test_aio/sql/prep.sql | 9 + src/test/modules/test_aio/sync.conf | 5 + src/test/modules/test_aio/test_aio--1.0.sql | 99 ++++ src/test/modules/test_aio/test_aio.c | 504 ++++++++++++++++++ src/test/modules/test_aio/test_aio.control | 3 + src/test/modules/test_aio/worker.conf | 5 + 23 files changed, 1467 insertions(+), 2 deletions(-) create mode 100644 src/test/modules/test_aio/.gitignore create mode 100644 src/test/modules/test_aio/Makefile create mode 100644 src/test/modules/test_aio/expected/inject.out create mode 100644 src/test/modules/test_aio/expected/io.out create mode 100644 src/test/modules/test_aio/expected/ownership.out create mode 100644 src/test/modules/test_aio/expected/prep.out create mode 100644 src/test/modules/test_aio/io_uring.conf create mode 100644 src/test/modules/test_aio/meson.build create mode 100644 src/test/modules/test_aio/sql/inject.sql create mode 100644 src/test/modules/test_aio/sql/io.sql create mode 100644 src/test/modules/test_aio/sql/ownership.sql create mode 100644 src/test/modules/test_aio/sql/prep.sql create mode 100644 src/test/modules/test_aio/sync.conf create mode 100644 src/test/modules/test_aio/test_aio--1.0.sql create mode 100644 src/test/modules/test_aio/test_aio.c create mode 100644 src/test/modules/test_aio/test_aio.control create mode 100644 src/test/modules/test_aio/worker.conf diff --git a/src/include/storage/aio_internal.h b/src/include/storage/aio_internal.h index 531532e306a..1855b57f355 100644 --- a/src/include/storage/aio_internal.h +++ b/src/include/storage/aio_internal.h @@ -316,6 +316,14 @@ extern const char *pgaio_io_get_target_name(PgAioHandle *ioh); __VA_ARGS__) +/* These functions are just for use in tests, from within injection points */ +#ifdef USE_INJECTION_POINTS + +extern PgAioHandle *pgaio_inj_io_get(void); + +#endif + + /* Declarations for the tables of function pointers exposed by each IO method. */ extern PGDLLIMPORT const IoMethodOps pgaio_sync_ops; extern PGDLLIMPORT const IoMethodOps pgaio_worker_ops; diff --git a/src/include/storage/buf_internals.h b/src/include/storage/buf_internals.h index aeefb1746ec..9939032d5f0 100644 --- a/src/include/storage/buf_internals.h +++ b/src/include/storage/buf_internals.h @@ -423,6 +423,10 @@ extern void IssuePendingWritebacks(WritebackContext *wb_context, IOContext io_co extern void ScheduleBufferTagForWriteback(WritebackContext *wb_context, IOContext io_context, BufferTag *tag); +/* solely to make it easier to write tests */ +extern bool StartBufferIO(BufferDesc *buf, bool forInput, bool nowait); + + /* freelist.c */ extern IOContext IOContextForStrategy(BufferAccessStrategy strategy); extern BufferDesc *StrategyGetBuffer(BufferAccessStrategy strategy, diff --git a/src/backend/storage/aio/aio.c b/src/backend/storage/aio/aio.c index 431f2c2e5af..7a873f6ffbb 100644 --- a/src/backend/storage/aio/aio.c +++ b/src/backend/storage/aio/aio.c @@ -46,6 +46,10 @@ #include "utils/resowner.h" #include "utils/wait_event_types.h" +#ifdef USE_INJECTION_POINTS +#include "utils/injection_point.h" +#endif + static inline void pgaio_io_update_state(PgAioHandle *ioh, PgAioHandleState new_state); static void pgaio_io_reclaim(PgAioHandle *ioh); @@ -92,6 +96,11 @@ static const IoMethodOps *const pgaio_method_ops_table[] = { const IoMethodOps *pgaio_method_ops; +#ifdef USE_INJECTION_POINTS +static PgAioHandle *pgaio_inj_cur_handle; +#endif + + /* -------------------------------------------------------------------------------- * Public Functions related to PgAioHandle @@ -452,6 +461,19 @@ pgaio_io_process_completion(PgAioHandle *ioh, int result) pgaio_io_update_state(ioh, PGAIO_HS_COMPLETED_IO); +#ifdef USE_INJECTION_POINTS + pgaio_inj_cur_handle = ioh; + + /* + * FIXME: This could be in a critical section - but it looks like we can't + * just InjectionPointLoad() at process start, as the injection point + * might not yet be defined. + */ + InjectionPointCached("AIO_PROCESS_COMPLETION_BEFORE_SHARED"); + + pgaio_inj_cur_handle = NULL; +#endif + pgaio_io_call_complete_shared(ioh); pgaio_io_update_state(ioh, PGAIO_HS_COMPLETED_SHARED); @@ -1128,3 +1150,20 @@ assign_io_method(int newval, void *extra) pgaio_method_ops = pgaio_method_ops_table[newval]; } + + + +/* -------------------------------------------------------------------------------- + * Injection point support + * -------------------------------------------------------------------------------- + */ + +#ifdef USE_INJECTION_POINTS + +PgAioHandle * +pgaio_inj_io_get(void) +{ + return pgaio_inj_cur_handle; +} + +#endif diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c index 1e8793d1630..7f6eabcb92e 100644 --- a/src/backend/storage/buffer/bufmgr.c +++ b/src/backend/storage/buffer/bufmgr.c @@ -514,7 +514,6 @@ static void UnpinBufferNoOwner(BufferDesc *buf); static void BufferSync(int flags); static uint32 WaitBufHdrUnlocked(BufferDesc *buf); static void WaitIO(BufferDesc *buf); -static bool StartBufferIO(BufferDesc *buf, bool forInput, bool nowait); static void TerminateBufferIO(BufferDesc *buf, bool clear_dirty, uint32 set_flag_bits, bool forget_owner, bool syncio); @@ -6184,7 +6183,7 @@ WaitIO(BufferDesc *buf) * find out if they can perform the I/O as part of a larger operation, without * waiting for the answer or distinguishing the reasons why not. */ -static bool +bool StartBufferIO(BufferDesc *buf, bool forInput, bool nowait) { uint32 buf_state; diff --git a/src/test/modules/Makefile b/src/test/modules/Makefile index c0d3cf0e14b..73ff9c55687 100644 --- a/src/test/modules/Makefile +++ b/src/test/modules/Makefile @@ -13,6 +13,7 @@ SUBDIRS = \ libpq_pipeline \ plsample \ spgist_name_ops \ + test_aio \ test_bloomfilter \ test_copy_callbacks \ test_custom_rmgrs \ diff --git a/src/test/modules/meson.build b/src/test/modules/meson.build index 4f544a042d4..b11dd72334c 100644 --- a/src/test/modules/meson.build +++ b/src/test/modules/meson.build @@ -1,5 +1,6 @@ # Copyright (c) 2022-2025, PostgreSQL Global Development Group +subdir('test_aio') subdir('brin') subdir('commit_ts') subdir('delay_execution') diff --git a/src/test/modules/test_aio/.gitignore b/src/test/modules/test_aio/.gitignore new file mode 100644 index 00000000000..b4903eba657 --- /dev/null +++ b/src/test/modules/test_aio/.gitignore @@ -0,0 +1,6 @@ +# Generated subdirectories +/log/ +/results/ +/output_iso/ +/tmp_check/ +/tmp_check_iso/ diff --git a/src/test/modules/test_aio/Makefile b/src/test/modules/test_aio/Makefile new file mode 100644 index 00000000000..ae6d685835b --- /dev/null +++ b/src/test/modules/test_aio/Makefile @@ -0,0 +1,34 @@ +# src/test/modules/delay_execution/Makefile + +PGFILEDESC = "test_aio - test code for AIO" + +MODULE_big = test_aio +OBJS = \ + $(WIN32RES) \ + test_aio.o + +EXTENSION = test_aio +DATA = test_aio--1.0.sql + +REGRESS = prep ownership io + +ifeq ($(enable_injection_points),yes) +REGRESS += inject +endif + +# FIXME: with meson this runs the tests once with worker and once - if +# supported - with io_uring. + +# requires custom config +NO_INSTALLCHECK = 1 + +ifdef USE_PGXS +PG_CONFIG = pg_config +PGXS := $(shell $(PG_CONFIG) --pgxs) +include $(PGXS) +else +subdir = src/test/modules/test_aio +top_builddir = ../../../.. +include $(top_builddir)/src/Makefile.global +include $(top_srcdir)/contrib/contrib-global.mk +endif diff --git a/src/test/modules/test_aio/expected/inject.out b/src/test/modules/test_aio/expected/inject.out new file mode 100644 index 00000000000..e62e3718845 --- /dev/null +++ b/src/test/modules/test_aio/expected/inject.out @@ -0,0 +1,295 @@ +SELECT count(*) FROM tbl_b WHERE ctid = '(2, 1)'; + count +------- + 1 +(1 row) + +-- injected what we'd expect +SELECT inj_io_short_read_attach(8192); + inj_io_short_read_attach +-------------------------- + +(1 row) + +SELECT invalidate_rel_block('tbl_b', 2); + invalidate_rel_block +---------------------- + +(1 row) + +SELECT count(*) FROM tbl_b WHERE ctid = '(2, 1)'; + count +------- + 1 +(1 row) + +SELECT inj_io_short_read_detach(); + inj_io_short_read_detach +-------------------------- + +(1 row) + +-- injected a read shorter than a single block, expecting error +SELECT inj_io_short_read_attach(17); + inj_io_short_read_attach +-------------------------- + +(1 row) + +SELECT invalidate_rel_block('tbl_b', 2); + invalidate_rel_block +---------------------- + +(1 row) + +SELECT redact($$ + SELECT count(*) FROM tbl_b WHERE ctid = '(2, 1)'; +$$); +NOTICE: wrapped error: could not read blocks 2..2 in file base/: read only 0 of 8192 bytes + redact +-------- + f +(1 row) + +SELECT inj_io_short_read_detach(); + inj_io_short_read_detach +-------------------------- + +(1 row) + +-- shorten multi-block read to a single block, should retry +SELECT count(*) FROM tbl_b; -- for comparison + count +------- + 10000 +(1 row) + +SELECT invalidate_rel_block('tbl_b', 0); + invalidate_rel_block +---------------------- + +(1 row) + +SELECT invalidate_rel_block('tbl_b', 1); + invalidate_rel_block +---------------------- + +(1 row) + +SELECT invalidate_rel_block('tbl_b', 2); + invalidate_rel_block +---------------------- + +(1 row) + +SELECT inj_io_short_read_attach(8192); + inj_io_short_read_attach +-------------------------- + +(1 row) + +-- no need to redact, no messages to client +SELECT count(*) FROM tbl_b; + count +------- + 10000 +(1 row) + +SELECT inj_io_short_read_detach(); + inj_io_short_read_detach +-------------------------- + +(1 row) + +-- shorten multi-block read to 1 1/2 blocks, should retry +SELECT count(*) FROM tbl_b; -- for comparison + count +------- + 10000 +(1 row) + +SELECT invalidate_rel_block('tbl_b', 0); + invalidate_rel_block +---------------------- + +(1 row) + +SELECT invalidate_rel_block('tbl_b', 1); + invalidate_rel_block +---------------------- + +(1 row) + +SELECT invalidate_rel_block('tbl_b', 2); + invalidate_rel_block +---------------------- + +(1 row) + +SELECT inj_io_short_read_attach(8192 + 4096); + inj_io_short_read_attach +-------------------------- + +(1 row) + +-- no need to redact, no messages to client +SELECT count(*) FROM tbl_b; + count +------- + 10000 +(1 row) + +SELECT inj_io_short_read_detach(); + inj_io_short_read_detach +-------------------------- + +(1 row) + +-- shorten single-block read to read that block partially, we'll error out, +-- because we assume we can read at least one block at a time. +SELECT count(*) FROM tbl_b WHERE ctid = '(2, 1)'; -- for comparison + count +------- + 1 +(1 row) + +SELECT invalidate_rel_block('tbl_b', 2); + invalidate_rel_block +---------------------- + +(1 row) + +SELECT inj_io_short_read_attach(4096); + inj_io_short_read_attach +-------------------------- + +(1 row) + +SELECT redact($$ + SELECT count(*) FROM tbl_b WHERE ctid = '(2, 1)'; +$$); +NOTICE: wrapped error: could not read blocks 2..2 in file base/: read only 0 of 8192 bytes + redact +-------- + f +(1 row) + +SELECT inj_io_short_read_detach(); + inj_io_short_read_detach +-------------------------- + +(1 row) + +-- shorten single-block read to read 0 bytes, expect that to error out +SELECT count(*) FROM tbl_b WHERE ctid = '(2, 1)'; -- for comparison + count +------- + 1 +(1 row) + +SELECT invalidate_rel_block('tbl_b', 2); + invalidate_rel_block +---------------------- + +(1 row) + +SELECT inj_io_short_read_attach(0); + inj_io_short_read_attach +-------------------------- + +(1 row) + +SELECT redact($$ + SELECT count(*) FROM tbl_b WHERE ctid = '(2, 1)'; +$$); +NOTICE: wrapped error: could not read blocks 2..2 in file base/: read only 0 of 8192 bytes + redact +-------- + f +(1 row) + +SELECT inj_io_short_read_detach(); + inj_io_short_read_detach +-------------------------- + +(1 row) + +-- verify that checksum errors are detected even as part of a shortened +-- multi-block read +-- (tbl_a, block 1 is corrupted) +SELECT redact($$ + SELECT count(*) FROM tbl_a WHERE ctid < '(2, 1)'; +$$); +NOTICE: wrapped error: invalid page in block 2 of relation base/ + redact +-------- + f +(1 row) + +SELECT inj_io_short_read_attach(8192); + inj_io_short_read_attach +-------------------------- + +(1 row) + +SELECT invalidate_rel_block('tbl_a', 0); + invalidate_rel_block +---------------------- + +(1 row) + +SELECT invalidate_rel_block('tbl_a', 1); + invalidate_rel_block +---------------------- + +(1 row) + +SELECT invalidate_rel_block('tbl_a', 2); + invalidate_rel_block +---------------------- + +(1 row) + +SELECT redact($$ + SELECT count(*) FROM tbl_a WHERE ctid < '(2, 1)'; +$$); +NOTICE: wrapped error: invalid page in block 2 of relation base/ + redact +-------- + f +(1 row) + +SELECT inj_io_short_read_detach(); + inj_io_short_read_detach +-------------------------- + +(1 row) + +-- trigger a hard error, should error out +SELECT inj_io_short_read_attach(-errno_from_string('EIO')); + inj_io_short_read_attach +-------------------------- + +(1 row) + +SELECT invalidate_rel_block('tbl_b', 2); + invalidate_rel_block +---------------------- + +(1 row) + +SELECT redact($$ + SELECT count(*) FROM tbl_b WHERE ctid = '(2, 1)'; +$$); +NOTICE: wrapped error: could not read blocks 2..3 in file base/: Input/output error + redact +-------- + f +(1 row) + +SELECT inj_io_short_read_detach(); + inj_io_short_read_detach +-------------------------- + +(1 row) + diff --git a/src/test/modules/test_aio/expected/io.out b/src/test/modules/test_aio/expected/io.out new file mode 100644 index 00000000000..e46b582f290 --- /dev/null +++ b/src/test/modules/test_aio/expected/io.out @@ -0,0 +1,40 @@ +SELECT count(*) FROM tbl_a WHERE ctid = '(1, 1)'; + count +------- + 1 +(1 row) + +SELECT corrupt_rel_block('tbl_a', 1); + corrupt_rel_block +------------------- + +(1 row) + +-- FIXME: Should report the error +SELECT redact($$ + SELECT read_corrupt_rel_block('tbl_a', 1); +$$); + redact +-------- + t +(1 row) + +-- verify the error is reported +SELECT redact($$ + SELECT count(*) FROM tbl_a WHERE ctid = '(1, 1)'; +$$); +NOTICE: wrapped error: invalid page in block 2 of relation base/ + redact +-------- + f +(1 row) + +SELECT redact($$ + SELECT count(*) FROM tbl_a; +$$); +NOTICE: wrapped error: invalid page in block 2 of relation base/ + redact +-------- + f +(1 row) + diff --git a/src/test/modules/test_aio/expected/ownership.out b/src/test/modules/test_aio/expected/ownership.out new file mode 100644 index 00000000000..97fdad6c629 --- /dev/null +++ b/src/test/modules/test_aio/expected/ownership.out @@ -0,0 +1,148 @@ +----- +-- IO handles +---- +-- leak warning: implicit xact +SELECT handle_get(); +WARNING: leaked AIO handle + handle_get +------------ + +(1 row) + +-- leak warning: explicit xact +BEGIN; SELECT handle_get(); COMMIT; +WARNING: leaked AIO handle + handle_get +------------ + +(1 row) + +-- leak warning + error: released in different command (thus resowner) +BEGIN; SELECT handle_get(); SELECT handle_release_last(); COMMIT; +WARNING: leaked AIO handle + handle_get +------------ + +(1 row) + +ERROR: release in unexpected state +-- no leak, same command +BEGIN; SELECT handle_get() UNION ALL SELECT handle_release_last(); COMMIT; + handle_get +------------ + + +(2 rows) + +-- leak warning: subtrans +BEGIN; SAVEPOINT foo; SELECT handle_get(); COMMIT; +WARNING: leaked AIO handle + handle_get +------------ + +(1 row) + +-- normal handle use +SELECT handle_get_release(); + handle_get_release +-------------------- + +(1 row) + +-- should error out, API violation +SELECT handle_get_twice(); +ERROR: API violation: Only one IO can be handed out +-- recover after error in implicit xact +SELECT handle_get_and_error(); SELECT handle_get_release(); +ERROR: as you command + handle_get_release +-------------------- + +(1 row) + +-- recover after error in explicit xact +BEGIN; SELECT handle_get_and_error(); ROLLBACK; SELECT handle_get_release(); +ERROR: as you command + handle_get_release +-------------------- + +(1 row) + +-- recover after error in subtrans +BEGIN; SAVEPOINT foo; SELECT handle_get_and_error(); ROLLBACK TO SAVEPOINT foo; SELECT handle_get_release(); ROLLBACK; +ERROR: as you command + handle_get_release +-------------------- + +(1 row) + +----- +-- Bounce Buffers handles +---- +-- leak warning: implicit xact +SELECT bb_get(); +WARNING: leaked AIO bounce buffer + bb_get +-------- + +(1 row) + +-- leak warning: explicit xact +BEGIN; SELECT bb_get(); COMMIT; +WARNING: leaked AIO bounce buffer + bb_get +-------- + +(1 row) + +-- missing leak warning: we should warn at command boundaries, not xact boundaries +BEGIN; SELECT bb_get(); SELECT bb_release_last(); COMMIT; +WARNING: leaked AIO bounce buffer + bb_get +-------- + +(1 row) + +ERROR: can only release handed out BB +-- leak warning: subtrans +BEGIN; SAVEPOINT foo; SELECT bb_get(); COMMIT; +WARNING: leaked AIO bounce buffer + bb_get +-------- + +(1 row) + +-- normal bb use +SELECT bb_get_release(); + bb_get_release +---------------- + +(1 row) + +-- should error out, API violation +SELECT bb_get_twice(); +ERROR: can only hand out one BB +-- recover after error in implicit xact +SELECT bb_get_and_error(); SELECT bb_get_release(); +ERROR: as you command + bb_get_release +---------------- + +(1 row) + +-- recover after error in explicit xact +BEGIN; SELECT bb_get_and_error(); ROLLBACK; SELECT bb_get_release(); +ERROR: as you command + bb_get_release +---------------- + +(1 row) + +-- recover after error in subtrans +BEGIN; SAVEPOINT foo; SELECT bb_get_and_error(); ROLLBACK TO SAVEPOINT foo; SELECT bb_get_release(); ROLLBACK; +ERROR: as you command + bb_get_release +---------------- + +(1 row) + diff --git a/src/test/modules/test_aio/expected/prep.out b/src/test/modules/test_aio/expected/prep.out new file mode 100644 index 00000000000..7fad6280db5 --- /dev/null +++ b/src/test/modules/test_aio/expected/prep.out @@ -0,0 +1,17 @@ +CREATE EXTENSION test_aio; +CREATE TABLE tbl_a(data int not null); +CREATE TABLE tbl_b(data int not null); +INSERT INTO tbl_a SELECT generate_series(1, 10000); +INSERT INTO tbl_b SELECT generate_series(1, 10000); +SELECT grow_rel('tbl_a', 500); + grow_rel +---------- + +(1 row) + +SELECT grow_rel('tbl_b', 550); + grow_rel +---------- + +(1 row) + diff --git a/src/test/modules/test_aio/io_uring.conf b/src/test/modules/test_aio/io_uring.conf new file mode 100644 index 00000000000..efd7ad143ff --- /dev/null +++ b/src/test/modules/test_aio/io_uring.conf @@ -0,0 +1,5 @@ +shared_preload_libraries=test_aio +io_method = 'io_uring' +log_min_messages = 'DEBUG3' +log_statement=all +restart_after_crash=false diff --git a/src/test/modules/test_aio/meson.build b/src/test/modules/test_aio/meson.build new file mode 100644 index 00000000000..a4bef0ceeb0 --- /dev/null +++ b/src/test/modules/test_aio/meson.build @@ -0,0 +1,78 @@ +# Copyright (c) 2022-2024, PostgreSQL Global Development Group + +test_aio_sources = files( + 'test_aio.c', +) + +if host_system == 'windows' + test_aio_sources += rc_lib_gen.process(win32ver_rc, extra_args: [ + '--NAME', 'test_aio', + '--FILEDESC', 'test_aio - test code for AIO',]) +endif + +test_aio = shared_module('test_aio', + test_aio_sources, + kwargs: pg_test_mod_args, +) +test_install_libs += test_aio + +test_install_data += files( + 'test_aio.control', + 'test_aio--1.0.sql', +) + + +testfiles = [ + 'prep', + 'ownership', + 'io', +] + +if get_option('injection_points') + testfiles += 'inject' +endif + + +tests += { + 'name': 'test_aio_sync', + 'sd': meson.current_source_dir(), + 'bd': meson.current_build_dir(), + 'regress': { + 'sql': testfiles, + 'regress_args': [ + '--temp-config', files('sync.conf'), + ], + # requires custom config + 'runningcheck': false, + }, +} + +tests += { + 'name': 'test_aio_worker', + 'sd': meson.current_source_dir(), + 'bd': meson.current_build_dir(), + 'regress': { + 'sql': testfiles, + 'regress_args': [ + '--temp-config', files('worker.conf'), + ], + # requires custom config + 'runningcheck': false, + }, +} + +if liburing.found() + tests += { + 'name': 'test_aio_uring', + 'sd': meson.current_source_dir(), + 'bd': meson.current_build_dir(), + 'regress': { + 'sql': testfiles, + 'regress_args': [ + '--temp-config', files('io_uring.conf'), + ], + # requires custom config + 'runningcheck': false, + } + } +endif diff --git a/src/test/modules/test_aio/sql/inject.sql b/src/test/modules/test_aio/sql/inject.sql new file mode 100644 index 00000000000..1190531f5ad --- /dev/null +++ b/src/test/modules/test_aio/sql/inject.sql @@ -0,0 +1,84 @@ +SELECT count(*) FROM tbl_b WHERE ctid = '(2, 1)'; + +-- injected what we'd expect +SELECT inj_io_short_read_attach(8192); +SELECT invalidate_rel_block('tbl_b', 2); +SELECT count(*) FROM tbl_b WHERE ctid = '(2, 1)'; +SELECT inj_io_short_read_detach(); + + +-- injected a read shorter than a single block, expecting error +SELECT inj_io_short_read_attach(17); +SELECT invalidate_rel_block('tbl_b', 2); +SELECT redact($$ + SELECT count(*) FROM tbl_b WHERE ctid = '(2, 1)'; +$$); +SELECT inj_io_short_read_detach(); + + +-- shorten multi-block read to a single block, should retry +SELECT count(*) FROM tbl_b; -- for comparison +SELECT invalidate_rel_block('tbl_b', 0); +SELECT invalidate_rel_block('tbl_b', 1); +SELECT invalidate_rel_block('tbl_b', 2); +SELECT inj_io_short_read_attach(8192); +-- no need to redact, no messages to client +SELECT count(*) FROM tbl_b; +SELECT inj_io_short_read_detach(); + + +-- shorten multi-block read to 1 1/2 blocks, should retry +SELECT count(*) FROM tbl_b; -- for comparison +SELECT invalidate_rel_block('tbl_b', 0); +SELECT invalidate_rel_block('tbl_b', 1); +SELECT invalidate_rel_block('tbl_b', 2); +SELECT inj_io_short_read_attach(8192 + 4096); +-- no need to redact, no messages to client +SELECT count(*) FROM tbl_b; +SELECT inj_io_short_read_detach(); + + +-- shorten single-block read to read that block partially, we'll error out, +-- because we assume we can read at least one block at a time. +SELECT count(*) FROM tbl_b WHERE ctid = '(2, 1)'; -- for comparison +SELECT invalidate_rel_block('tbl_b', 2); +SELECT inj_io_short_read_attach(4096); +SELECT redact($$ + SELECT count(*) FROM tbl_b WHERE ctid = '(2, 1)'; +$$); +SELECT inj_io_short_read_detach(); + + +-- shorten single-block read to read 0 bytes, expect that to error out +SELECT count(*) FROM tbl_b WHERE ctid = '(2, 1)'; -- for comparison +SELECT invalidate_rel_block('tbl_b', 2); +SELECT inj_io_short_read_attach(0); +SELECT redact($$ + SELECT count(*) FROM tbl_b WHERE ctid = '(2, 1)'; +$$); +SELECT inj_io_short_read_detach(); + + +-- verify that checksum errors are detected even as part of a shortened +-- multi-block read +-- (tbl_a, block 1 is corrupted) +SELECT redact($$ + SELECT count(*) FROM tbl_a WHERE ctid < '(2, 1)'; +$$); +SELECT inj_io_short_read_attach(8192); +SELECT invalidate_rel_block('tbl_a', 0); +SELECT invalidate_rel_block('tbl_a', 1); +SELECT invalidate_rel_block('tbl_a', 2); +SELECT redact($$ + SELECT count(*) FROM tbl_a WHERE ctid < '(2, 1)'; +$$); +SELECT inj_io_short_read_detach(); + + +-- trigger a hard error, should error out +SELECT inj_io_short_read_attach(-errno_from_string('EIO')); +SELECT invalidate_rel_block('tbl_b', 2); +SELECT redact($$ + SELECT count(*) FROM tbl_b WHERE ctid = '(2, 1)'; +$$); +SELECT inj_io_short_read_detach(); diff --git a/src/test/modules/test_aio/sql/io.sql b/src/test/modules/test_aio/sql/io.sql new file mode 100644 index 00000000000..a29bb4eb15d --- /dev/null +++ b/src/test/modules/test_aio/sql/io.sql @@ -0,0 +1,16 @@ +SELECT count(*) FROM tbl_a WHERE ctid = '(1, 1)'; + +SELECT corrupt_rel_block('tbl_a', 1); + +-- FIXME: Should report the error +SELECT redact($$ + SELECT read_corrupt_rel_block('tbl_a', 1); +$$); + +-- verify the error is reported +SELECT redact($$ + SELECT count(*) FROM tbl_a WHERE ctid = '(1, 1)'; +$$); +SELECT redact($$ + SELECT count(*) FROM tbl_a; +$$); diff --git a/src/test/modules/test_aio/sql/ownership.sql b/src/test/modules/test_aio/sql/ownership.sql new file mode 100644 index 00000000000..63cf40c802a --- /dev/null +++ b/src/test/modules/test_aio/sql/ownership.sql @@ -0,0 +1,65 @@ +----- +-- IO handles +---- + +-- leak warning: implicit xact +SELECT handle_get(); + +-- leak warning: explicit xact +BEGIN; SELECT handle_get(); COMMIT; + +-- leak warning + error: released in different command (thus resowner) +BEGIN; SELECT handle_get(); SELECT handle_release_last(); COMMIT; + +-- no leak, same command +BEGIN; SELECT handle_get() UNION ALL SELECT handle_release_last(); COMMIT; + +-- leak warning: subtrans +BEGIN; SAVEPOINT foo; SELECT handle_get(); COMMIT; + +-- normal handle use +SELECT handle_get_release(); + +-- should error out, API violation +SELECT handle_get_twice(); + +-- recover after error in implicit xact +SELECT handle_get_and_error(); SELECT handle_get_release(); + +-- recover after error in explicit xact +BEGIN; SELECT handle_get_and_error(); ROLLBACK; SELECT handle_get_release(); + +-- recover after error in subtrans +BEGIN; SAVEPOINT foo; SELECT handle_get_and_error(); ROLLBACK TO SAVEPOINT foo; SELECT handle_get_release(); ROLLBACK; + + +----- +-- Bounce Buffers handles +---- + +-- leak warning: implicit xact +SELECT bb_get(); + +-- leak warning: explicit xact +BEGIN; SELECT bb_get(); COMMIT; + +-- missing leak warning: we should warn at command boundaries, not xact boundaries +BEGIN; SELECT bb_get(); SELECT bb_release_last(); COMMIT; + +-- leak warning: subtrans +BEGIN; SAVEPOINT foo; SELECT bb_get(); COMMIT; + +-- normal bb use +SELECT bb_get_release(); + +-- should error out, API violation +SELECT bb_get_twice(); + +-- recover after error in implicit xact +SELECT bb_get_and_error(); SELECT bb_get_release(); + +-- recover after error in explicit xact +BEGIN; SELECT bb_get_and_error(); ROLLBACK; SELECT bb_get_release(); + +-- recover after error in subtrans +BEGIN; SAVEPOINT foo; SELECT bb_get_and_error(); ROLLBACK TO SAVEPOINT foo; SELECT bb_get_release(); ROLLBACK; diff --git a/src/test/modules/test_aio/sql/prep.sql b/src/test/modules/test_aio/sql/prep.sql new file mode 100644 index 00000000000..b8f225cbc98 --- /dev/null +++ b/src/test/modules/test_aio/sql/prep.sql @@ -0,0 +1,9 @@ +CREATE EXTENSION test_aio; + +CREATE TABLE tbl_a(data int not null); +CREATE TABLE tbl_b(data int not null); + +INSERT INTO tbl_a SELECT generate_series(1, 10000); +INSERT INTO tbl_b SELECT generate_series(1, 10000); +SELECT grow_rel('tbl_a', 500); +SELECT grow_rel('tbl_b', 550); diff --git a/src/test/modules/test_aio/sync.conf b/src/test/modules/test_aio/sync.conf new file mode 100644 index 00000000000..c480922d6cf --- /dev/null +++ b/src/test/modules/test_aio/sync.conf @@ -0,0 +1,5 @@ +shared_preload_libraries=test_aio +io_method = 'sync' +log_min_messages = 'DEBUG3' +log_statement=all +restart_after_crash=false diff --git a/src/test/modules/test_aio/test_aio--1.0.sql b/src/test/modules/test_aio/test_aio--1.0.sql new file mode 100644 index 00000000000..e3d5ce29c60 --- /dev/null +++ b/src/test/modules/test_aio/test_aio--1.0.sql @@ -0,0 +1,99 @@ +/* src/test/modules/test_aio/test_aio--1.0.sql */ + +-- complain if script is sourced in psql, rather than via CREATE EXTENSION +\echo Use "CREATE EXTENSION test_aio" to load this file. \quit + + +CREATE FUNCTION errno_from_string(sym text) +RETURNS pg_catalog.int4 STRICT +AS 'MODULE_PATHNAME' LANGUAGE C; + + +CREATE FUNCTION grow_rel(rel regclass, nblocks int) +RETURNS pg_catalog.void STRICT +AS 'MODULE_PATHNAME' LANGUAGE C; + + +CREATE FUNCTION corrupt_rel_block(rel regclass, blockno int) +RETURNS pg_catalog.void STRICT +AS 'MODULE_PATHNAME' LANGUAGE C; + +CREATE FUNCTION read_corrupt_rel_block(rel regclass, blockno int) +RETURNS pg_catalog.void STRICT +AS 'MODULE_PATHNAME' LANGUAGE C; + +CREATE FUNCTION invalidate_rel_block(rel regclass, blockno int) +RETURNS pg_catalog.void STRICT +AS 'MODULE_PATHNAME' LANGUAGE C; + +CREATE FUNCTION handle_get_and_error() +RETURNS pg_catalog.void STRICT +AS 'MODULE_PATHNAME' LANGUAGE C; + +CREATE FUNCTION handle_get_twice() +RETURNS pg_catalog.void STRICT +AS 'MODULE_PATHNAME' LANGUAGE C; + +CREATE FUNCTION handle_get() +RETURNS pg_catalog.void STRICT +AS 'MODULE_PATHNAME' LANGUAGE C; + +CREATE FUNCTION handle_get_release() +RETURNS pg_catalog.void STRICT +AS 'MODULE_PATHNAME' LANGUAGE C; + +CREATE FUNCTION handle_release_last() +RETURNS pg_catalog.void STRICT +AS 'MODULE_PATHNAME' LANGUAGE C; + + +CREATE FUNCTION bb_get_and_error() +RETURNS pg_catalog.void STRICT +AS 'MODULE_PATHNAME' LANGUAGE C; + +CREATE FUNCTION bb_get_twice() +RETURNS pg_catalog.void STRICT +AS 'MODULE_PATHNAME' LANGUAGE C; + +CREATE FUNCTION bb_get() +RETURNS pg_catalog.void STRICT +AS 'MODULE_PATHNAME' LANGUAGE C; + +CREATE FUNCTION bb_get_release() +RETURNS pg_catalog.void STRICT +AS 'MODULE_PATHNAME' LANGUAGE C; + +CREATE FUNCTION bb_release_last() +RETURNS pg_catalog.void STRICT +AS 'MODULE_PATHNAME' LANGUAGE C; + + +CREATE OR REPLACE FUNCTION redact(p_sql text) +RETURNS bool +LANGUAGE plpgsql +AS $$ + DECLARE + err_state text; + err_msg text; + BEGIN + EXECUTE p_sql; + RETURN true; + EXCEPTION WHEN OTHERS THEN + GET STACKED DIAGNOSTICS + err_state = RETURNED_SQLSTATE, + err_msg = MESSAGE_TEXT; + err_msg = regexp_replace(err_msg, '(file|relation) "?base/[0-9]+/[0-9]+"?', '\1 base/'); + RAISE NOTICE 'wrapped error: %', err_msg + USING ERRCODE = err_state; + RETURN false; + END; +$$; + + +CREATE FUNCTION inj_io_short_read_attach(result int) +RETURNS pg_catalog.void STRICT +AS 'MODULE_PATHNAME' LANGUAGE C; + +CREATE FUNCTION inj_io_short_read_detach() +RETURNS pg_catalog.void STRICT +AS 'MODULE_PATHNAME' LANGUAGE C; diff --git a/src/test/modules/test_aio/test_aio.c b/src/test/modules/test_aio/test_aio.c new file mode 100644 index 00000000000..20d7e6dc82f --- /dev/null +++ b/src/test/modules/test_aio/test_aio.c @@ -0,0 +1,504 @@ +/*------------------------------------------------------------------------- + * + * delay_execution.c + * Test module to allow delay between parsing and execution of a query. + * + * The delay is implemented by taking and immediately releasing a specified + * advisory lock. If another process has previously taken that lock, the + * current process will be blocked until the lock is released; otherwise, + * there's no effect. This allows an isolationtester script to reliably + * test behaviors where some specified action happens in another backend + * between parsing and execution of any desired query. + * + * Copyright (c) 2020-2024, PostgreSQL Global Development Group + * + * IDENTIFICATION + * src/test/modules/delay_execution/delay_execution.c + * + *------------------------------------------------------------------------- + */ + +#include "postgres.h" + +#include "access/relation.h" +#include "fmgr.h" +#include "storage/aio.h" +#include "storage/aio_internal.h" +#include "storage/buf_internals.h" +#include "storage/bufmgr.h" +#include "storage/ipc.h" +#include "storage/lwlock.h" +#include "utils/builtins.h" +#include "utils/injection_point.h" +#include "utils/rel.h" + + +PG_MODULE_MAGIC; + + +typedef struct InjIoErrorState +{ + bool enabled; + bool result_set; + int result; +} InjIoErrorState; + +static InjIoErrorState * inj_io_error_state; + +/* Shared memory init callbacks */ +static shmem_request_hook_type prev_shmem_request_hook = NULL; +static shmem_startup_hook_type prev_shmem_startup_hook = NULL; + + +static PgAioHandle *last_handle; +static PgAioBounceBuffer *last_bb; + + + +static void +test_aio_shmem_request(void) +{ + if (prev_shmem_request_hook) + prev_shmem_request_hook(); + + RequestAddinShmemSpace(sizeof(InjIoErrorState)); +} + +static void +test_aio_shmem_startup(void) +{ + bool found; + + if (prev_shmem_startup_hook) + prev_shmem_startup_hook(); + + /* Create or attach to the shared memory state */ + LWLockAcquire(AddinShmemInitLock, LW_EXCLUSIVE); + + inj_io_error_state = ShmemInitStruct("injection_points", + sizeof(InjIoErrorState), + &found); + + if (!found) + { + /* + * First time through, so initialize. This is shared with the dynamic + * initialization using a DSM. + */ + inj_io_error_state->enabled = false; + +#ifdef USE_INJECTION_POINTS + InjectionPointAttach("AIO_PROCESS_COMPLETION_BEFORE_SHARED", + "test_aio", + "inj_io_short_read", + NULL, + 0); + InjectionPointLoad("AIO_PROCESS_COMPLETION_BEFORE_SHARED"); +#endif + } + else + { +#ifdef USE_INJECTION_POINTS + InjectionPointLoad("AIO_PROCESS_COMPLETION_BEFORE_SHARED"); + elog(LOG, "injection point loaded"); +#endif + } + + LWLockRelease(AddinShmemInitLock); +} + +void +_PG_init(void) +{ + if (!process_shared_preload_libraries_in_progress) + return; + + /* Shared memory initialization */ + prev_shmem_request_hook = shmem_request_hook; + shmem_request_hook = test_aio_shmem_request; + prev_shmem_startup_hook = shmem_startup_hook; + shmem_startup_hook = test_aio_shmem_startup; +} + + +PG_FUNCTION_INFO_V1(errno_from_string); +Datum +errno_from_string(PG_FUNCTION_ARGS) +{ + const char *sym = text_to_cstring(PG_GETARG_TEXT_PP(0)); + + if (strcmp(sym, "EIO") == 0) + PG_RETURN_INT32(EIO); + else if (strcmp(sym, "EAGAIN") == 0) + PG_RETURN_INT32(EAGAIN); + else if (strcmp(sym, "EINTR") == 0) + PG_RETURN_INT32(EINTR); + else if (strcmp(sym, "ENOSPC") == 0) + PG_RETURN_INT32(ENOSPC); + else if (strcmp(sym, "EROFS") == 0) + PG_RETURN_INT32(EROFS); + + ereport(ERROR, + errcode(ERRCODE_INVALID_PARAMETER_VALUE), + errmsg_internal("%s is not a supported errno value", sym)); + PG_RETURN_INT32(0); +} + + +PG_FUNCTION_INFO_V1(grow_rel); +Datum +grow_rel(PG_FUNCTION_ARGS) +{ + Oid relid = PG_GETARG_OID(0); + uint32 nblocks = PG_GETARG_UINT32(1); + Relation rel; +#define MAX_BUFFERS_TO_EXTEND_BY 64 + Buffer victim_buffers[MAX_BUFFERS_TO_EXTEND_BY]; + + rel = relation_open(relid, AccessExclusiveLock); + + while (nblocks > 0) + { + uint32 extend_by_pages; + + extend_by_pages = Min(nblocks, MAX_BUFFERS_TO_EXTEND_BY); + + ExtendBufferedRelBy(BMR_REL(rel), + MAIN_FORKNUM, + NULL, + 0, + extend_by_pages, + victim_buffers, + &extend_by_pages); + + nblocks -= extend_by_pages; + + for (uint32 i = 0; i < extend_by_pages; i++) + { + ReleaseBuffer(victim_buffers[i]); + } + } + + relation_close(rel, NoLock); + + PG_RETURN_VOID(); +} + +PG_FUNCTION_INFO_V1(corrupt_rel_block); +Datum +corrupt_rel_block(PG_FUNCTION_ARGS) +{ + Oid relid = PG_GETARG_OID(0); + uint32 block = PG_GETARG_UINT32(1); + Relation rel; + Buffer buf; + Page page; + PageHeader ph; + + rel = relation_open(relid, AccessExclusiveLock); + + buf = ReadBuffer(rel, block); + page = BufferGetPage(buf); + + LockBuffer(buf, BUFFER_LOCK_EXCLUSIVE); + + MarkBufferDirty(buf); + + PageInit(page, BufferGetPageSize(buf), 0); + + ph = (PageHeader) page; + ph->pd_special = BLCKSZ + 1; + + FlushOneBuffer(buf); + + LockBuffer(buf, BUFFER_LOCK_UNLOCK); + + ReleaseBuffer(buf); + + EvictUnpinnedBuffer(buf); + + relation_close(rel, NoLock); + + PG_RETURN_VOID(); +} + +PG_FUNCTION_INFO_V1(read_corrupt_rel_block); +Datum +read_corrupt_rel_block(PG_FUNCTION_ARGS) +{ + Oid relid = PG_GETARG_OID(0); + uint32 block = PG_GETARG_UINT32(1); + Relation rel; + Buffer buf; + BufferDesc *buf_hdr; + Page page; + PgAioHandle *ioh; + PgAioWaitRef iow; + SMgrRelation smgr; + uint32 buf_state; + + rel = relation_open(relid, AccessExclusiveLock); + + /* read buffer without erroring out */ + buf = ReadBufferExtended(rel, MAIN_FORKNUM, block, RBM_ZERO_AND_LOCK, NULL); + LockBuffer(buf, BUFFER_LOCK_UNLOCK); + + page = BufferGetBlock(buf); + + ioh = pgaio_io_acquire(CurrentResourceOwner, NULL); + pgaio_io_get_wref(ioh, &iow); + + buf_hdr = GetBufferDescriptor(buf - 1); + smgr = RelationGetSmgr(rel); + + /* FIXME: even if just a test, we should verify nobody else uses this */ + buf_state = LockBufHdr(buf_hdr); + buf_state &= ~(BM_VALID | BM_DIRTY); + UnlockBufHdr(buf_hdr, buf_state); + + StartBufferIO(buf_hdr, true, false); + + pgaio_io_set_handle_data_32(ioh, (uint32 *) &buf, 1); + pgaio_io_register_callbacks(ioh, PGAIO_HCB_SHARED_BUFFER_READV); + + smgrstartreadv(ioh, smgr, MAIN_FORKNUM, block, + (void *) &page, 1); + + ReleaseBuffer(buf); + + pgaio_wref_wait(&iow); + + relation_close(rel, NoLock); + + PG_RETURN_VOID(); +} + +PG_FUNCTION_INFO_V1(invalidate_rel_block); +Datum +invalidate_rel_block(PG_FUNCTION_ARGS) +{ + Oid relid = PG_GETARG_OID(0); + uint32 block = PG_GETARG_UINT32(1); + Relation rel; + PrefetchBufferResult pr; + Buffer buf; + + rel = relation_open(relid, AccessExclusiveLock); + + /* this is a gross hack, but there's no good API exposed */ + pr = PrefetchBuffer(rel, MAIN_FORKNUM, block); + buf = pr.recent_buffer; + elog(LOG, "recent: %d", buf); + if (BufferIsValid(buf)) + { + /* if the buffer contents aren't valid, this'll return false */ + if (ReadRecentBuffer(rel->rd_locator, MAIN_FORKNUM, block, buf)) + { + LockBuffer(buf, BUFFER_LOCK_EXCLUSIVE); + FlushOneBuffer(buf); + LockBuffer(buf, BUFFER_LOCK_UNLOCK); + ReleaseBuffer(buf); + + if (!EvictUnpinnedBuffer(buf)) + elog(ERROR, "couldn't unpin"); + } + } + + relation_close(rel, AccessExclusiveLock); + + PG_RETURN_VOID(); +} + +#if 0 +PG_FUNCTION_INFO_V1(test_unsubmitted_vs_close); +Datum +test_unsubmitted_vs_close(PG_FUNCTION_ARGS) +{ + Oid relid = PG_GETARG_OID(0); + uint32 block = PG_GETARG_UINT32(1); + Relation rel; + Buffer buf; + Page page; + PageHeader ph; + + rel = relation_open(relid, AccessExclusiveLock); + + buf = ReadBufferExtended(rel, MAIN_FORKNUM, block, RBM_ZERO_AND_LOCK, NULL); + + buf = ReadBuffer(rel, block); + page = BufferGetPage(buf); + + EvictUnpinnedBuffer(buf); + + LockBuffer(buf, BUFFER_LOCK_UNLOCK); + + + MarkBufferDirty(buf); + ph->pd_special = BLCKSZ + 1; + + /* last_handle = pgaio_io_acquire(); */ + + PG_RETURN_VOID(); +} +#endif + +PG_FUNCTION_INFO_V1(handle_get); +Datum +handle_get(PG_FUNCTION_ARGS) +{ + last_handle = pgaio_io_acquire(CurrentResourceOwner, NULL); + + PG_RETURN_VOID(); +} + +PG_FUNCTION_INFO_V1(handle_release_last); +Datum +handle_release_last(PG_FUNCTION_ARGS) +{ + if (!last_handle) + elog(ERROR, "no handle"); + + pgaio_io_release(last_handle); + + PG_RETURN_VOID(); +} + +PG_FUNCTION_INFO_V1(handle_get_and_error); +Datum +handle_get_and_error(PG_FUNCTION_ARGS) +{ + pgaio_io_acquire(CurrentResourceOwner, NULL); + + elog(ERROR, "as you command"); + PG_RETURN_VOID(); +} + +PG_FUNCTION_INFO_V1(handle_get_twice); +Datum +handle_get_twice(PG_FUNCTION_ARGS) +{ + pgaio_io_acquire(CurrentResourceOwner, NULL); + pgaio_io_acquire(CurrentResourceOwner, NULL); + + PG_RETURN_VOID(); +} + + +PG_FUNCTION_INFO_V1(handle_get_release); +Datum +handle_get_release(PG_FUNCTION_ARGS) +{ + PgAioHandle *handle; + + handle = pgaio_io_acquire(CurrentResourceOwner, NULL); + pgaio_io_release(handle); + + PG_RETURN_VOID(); +} + +PG_FUNCTION_INFO_V1(bb_get); +Datum +bb_get(PG_FUNCTION_ARGS) +{ + last_bb = pgaio_bounce_buffer_get(); + + PG_RETURN_VOID(); +} + +PG_FUNCTION_INFO_V1(bb_release_last); +Datum +bb_release_last(PG_FUNCTION_ARGS) +{ + if (!last_bb) + elog(ERROR, "no bb"); + + pgaio_bounce_buffer_release(last_bb); + + PG_RETURN_VOID(); +} + +PG_FUNCTION_INFO_V1(bb_get_and_error); +Datum +bb_get_and_error(PG_FUNCTION_ARGS) +{ + pgaio_bounce_buffer_get(); + + elog(ERROR, "as you command"); + PG_RETURN_VOID(); +} + +PG_FUNCTION_INFO_V1(bb_get_twice); +Datum +bb_get_twice(PG_FUNCTION_ARGS) +{ + pgaio_bounce_buffer_get(); + pgaio_bounce_buffer_get(); + + PG_RETURN_VOID(); +} + + +PG_FUNCTION_INFO_V1(bb_get_release); +Datum +bb_get_release(PG_FUNCTION_ARGS) +{ + PgAioBounceBuffer *bb; + + bb = pgaio_bounce_buffer_get(); + pgaio_bounce_buffer_release(bb); + + PG_RETURN_VOID(); +} + +#ifdef USE_INJECTION_POINTS +extern PGDLLEXPORT void inj_io_short_read(const char *name, const void *private_data); + +void +inj_io_short_read(const char *name, const void *private_data) +{ + PgAioHandle *ioh; + + elog(LOG, "short read called: %d", inj_io_error_state->enabled); + + if (inj_io_error_state->enabled) + { + ioh = pgaio_inj_io_get(); + + if (inj_io_error_state->result_set) + { + elog(LOG, "short read, changing result from %d to %d", + ioh->result, inj_io_error_state->result); + + ioh->result = inj_io_error_state->result; + } + } +} +#endif + +PG_FUNCTION_INFO_V1(inj_io_short_read_attach); +Datum +inj_io_short_read_attach(PG_FUNCTION_ARGS) +{ +#ifdef USE_INJECTION_POINTS + inj_io_error_state->enabled = true; + inj_io_error_state->result_set = !PG_ARGISNULL(0); + if (inj_io_error_state->result_set) + inj_io_error_state->result = PG_GETARG_INT32(0); +#else + elog(ERROR, "injection points not supported"); +#endif + + PG_RETURN_VOID(); +} + +PG_FUNCTION_INFO_V1(inj_io_short_read_detach); +Datum +inj_io_short_read_detach(PG_FUNCTION_ARGS) +{ +#ifdef USE_INJECTION_POINTS + inj_io_error_state->enabled = false; +#else + elog(ERROR, "injection points not supported"); +#endif + PG_RETURN_VOID(); +} diff --git a/src/test/modules/test_aio/test_aio.control b/src/test/modules/test_aio/test_aio.control new file mode 100644 index 00000000000..cd91c3ed16b --- /dev/null +++ b/src/test/modules/test_aio/test_aio.control @@ -0,0 +1,3 @@ +comment = 'Test code for AIO' +default_version = '1.0' +module_pathname = '$libdir/test_aio' diff --git a/src/test/modules/test_aio/worker.conf b/src/test/modules/test_aio/worker.conf new file mode 100644 index 00000000000..8104c201924 --- /dev/null +++ b/src/test/modules/test_aio/worker.conf @@ -0,0 +1,5 @@ +shared_preload_libraries=test_aio +io_method = 'worker' +log_min_messages = 'DEBUG3' +log_statement=all +restart_after_crash=false -- 2.48.1.76.g4e746b1a31.dirty