From 5d0345554afc326e6dc5e657694ba3f832b97d7b Mon Sep 17 00:00:00 2001 From: Bertrand Drouvot Date: Wed, 5 Feb 2025 15:55:36 +0000 Subject: [PATCH v2 2/4] Allow pg_stat_statements to track WAL buffers full Now that wal_buffers_full is part of the WalUsage struct, let's report it in pg_stat_statements. This commit doesn't bump the version of pg_stat_statements as the same is done for this release in commit cf54a2c00254. --- contrib/pg_stat_statements/expected/oldextversions.out | 1 + .../pg_stat_statements--1.11--1.12.sql | 1 + contrib/pg_stat_statements/pg_stat_statements.c | 7 +++++-- doc/src/sgml/pgstatstatements.sgml | 9 +++++++++ 4 files changed, 16 insertions(+), 2 deletions(-) 10.4% contrib/pg_stat_statements/expected/ 55.1% contrib/pg_stat_statements/ 34.4% doc/src/sgml/ diff --git a/contrib/pg_stat_statements/expected/oldextversions.out b/contrib/pg_stat_statements/expected/oldextversions.out index 0c60fc81274..1ff3a053298 100644 --- a/contrib/pg_stat_statements/expected/oldextversions.out +++ b/contrib/pg_stat_statements/expected/oldextversions.out @@ -397,6 +397,7 @@ AlTER EXTENSION pg_stat_statements UPDATE TO '1.12'; jit_deform_time | double precision | | | parallel_workers_to_launch | bigint | | | parallel_workers_launched | bigint | | | + wal_buffers_full | bigint | | | stats_since | timestamp with time zone | | | minmax_stats_since | timestamp with time zone | | | diff --git a/contrib/pg_stat_statements/pg_stat_statements--1.11--1.12.sql b/contrib/pg_stat_statements/pg_stat_statements--1.11--1.12.sql index 80e6be25445..1a1ace6c85d 100644 --- a/contrib/pg_stat_statements/pg_stat_statements--1.11--1.12.sql +++ b/contrib/pg_stat_statements/pg_stat_statements--1.11--1.12.sql @@ -62,6 +62,7 @@ CREATE FUNCTION pg_stat_statements(IN showtext boolean, OUT jit_deform_time float8, OUT parallel_workers_to_launch int8, OUT parallel_workers_launched int8, + OUT wal_buffers_full int8, OUT stats_since timestamp with time zone, OUT minmax_stats_since timestamp with time zone ) diff --git a/contrib/pg_stat_statements/pg_stat_statements.c b/contrib/pg_stat_statements/pg_stat_statements.c index bebf8134eb0..8107da02017 100644 --- a/contrib/pg_stat_statements/pg_stat_statements.c +++ b/contrib/pg_stat_statements/pg_stat_statements.c @@ -206,6 +206,7 @@ typedef struct Counters * to be launched */ int64 parallel_workers_launched; /* # of parallel workers actually * launched */ + int64 wal_buffers_full; /* # of times the WAL buffers became full */ } Counters; /* @@ -1465,6 +1466,7 @@ pgss_store(const char *query, uint64 queryId, entry->counters.wal_records += walusage->wal_records; entry->counters.wal_fpi += walusage->wal_fpi; entry->counters.wal_bytes += walusage->wal_bytes; + entry->counters.wal_buffers_full += walusage->wal_buffers_full; if (jitusage) { entry->counters.jit_functions += jitusage->created_functions; @@ -1557,8 +1559,8 @@ pg_stat_statements_reset(PG_FUNCTION_ARGS) #define PG_STAT_STATEMENTS_COLS_V1_9 33 #define PG_STAT_STATEMENTS_COLS_V1_10 43 #define PG_STAT_STATEMENTS_COLS_V1_11 49 -#define PG_STAT_STATEMENTS_COLS_V1_12 51 -#define PG_STAT_STATEMENTS_COLS 51 /* maximum of above */ +#define PG_STAT_STATEMENTS_COLS_V1_12 52 +#define PG_STAT_STATEMENTS_COLS 52 /* maximum of above */ /* * Retrieve statement statistics. @@ -1975,6 +1977,7 @@ pg_stat_statements_internal(FunctionCallInfo fcinfo, { values[i++] = Int64GetDatumFast(tmp.parallel_workers_to_launch); values[i++] = Int64GetDatumFast(tmp.parallel_workers_launched); + values[i++] = Int64GetDatumFast(tmp.wal_buffers_full); } if (api_version >= PGSS_V1_11) { diff --git a/doc/src/sgml/pgstatstatements.sgml b/doc/src/sgml/pgstatstatements.sgml index 501b468e9af..b73636e6342 100644 --- a/doc/src/sgml/pgstatstatements.sgml +++ b/doc/src/sgml/pgstatstatements.sgml @@ -545,6 +545,15 @@ + + + wal_buffers_full bigint + + + Number of times the WAL buffers became full + + + stats_since timestamp with time zone -- 2.34.1