From 0671eb2a6f59926bf94b041a1e20b864ec370a25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dagfinn=20Ilmari=20Manns=C3=A5ker?= Date: Wed, 26 Feb 2025 10:51:28 +0000 Subject: [PATCH 1/2] pg_upgrade: fix spelling of --set-char-signedness in test The single dash causes it to fail with a different error, but because the test isn't checking the error message it was passing anyway. The next commit will make the test check for the actual error. --- src/bin/pg_upgrade/t/005_char_signedness.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/pg_upgrade/t/005_char_signedness.pl b/src/bin/pg_upgrade/t/005_char_signedness.pl index c024106863e..b3092f03bb7 100644 --- a/src/bin/pg_upgrade/t/005_char_signedness.pl +++ b/src/bin/pg_upgrade/t/005_char_signedness.pl @@ -51,7 +51,7 @@ '-s', $new->host, '-p', $old->port, '-P', $new->port, - '-set-char-signedness', 'signed', + '--set-char-signedness', 'signed', $mode ], '--set-char-signedness option cannot be used for upgrading from v18 or later' -- 2.48.1