From 96c95cbf855419c909b0f79b79be47c2220d2c51 Mon Sep 17 00:00:00 2001 From: Atsushi Torikoshi Date: Wed, 12 Mar 2025 21:45:43 +0900 Subject: [PATCH v1] Change log message when hot standby is not accessible Previously, the log message only assumed that the recovery process had not yet reached a consistent point. However, even when we have reached the consistent point, if there is a transaction whose subtransaction is overflowed, the hot standby is not accessible and it was difficult to identify the cause since there are no log message indicates the reason. This change improves clarity by explicitly mention the case. --- src/backend/postmaster/postmaster.c | 6 ++++-- src/backend/tcop/backend_startup.c | 5 +++-- src/include/tcop/backend_startup.h | 2 +- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c index d2a7a7add6..aafd238a7c 100644 --- a/src/backend/postmaster/postmaster.c +++ b/src/backend/postmaster/postmaster.c @@ -1812,8 +1812,10 @@ canAcceptConnections(BackendType backend_type) else if (!FatalError && pmState == PM_STARTUP) return CAC_STARTUP; /* normal startup */ else if (!FatalError && pmState == PM_RECOVERY) - return CAC_NOTCONSISTENT; /* not yet at consistent recovery - * state */ + return CAC_NOTCONSISTENT_OR_OVERFLOWED; /* not yet at consistent + * recovery state or + * subtransaction is + * overflowed */ else return CAC_RECOVERY; /* else must be crash recovery */ } diff --git a/src/backend/tcop/backend_startup.c b/src/backend/tcop/backend_startup.c index c70746fa56..46b1709e67 100644 --- a/src/backend/tcop/backend_startup.c +++ b/src/backend/tcop/backend_startup.c @@ -291,12 +291,13 @@ BackendInitialize(ClientSocket *client_sock, CAC_state cac) (errcode(ERRCODE_CANNOT_CONNECT_NOW), errmsg("the database system is starting up"))); break; - case CAC_NOTCONSISTENT: + case CAC_NOTCONSISTENT_OR_OVERFLOWED: if (EnableHotStandby) ereport(FATAL, (errcode(ERRCODE_CANNOT_CONNECT_NOW), errmsg("the database system is not yet accepting connections"), - errdetail("Consistent recovery state has not been yet reached."))); + errdetail("Consistent recovery state has not been yet reached, or snappshot is pending because subtransaction is overflowed."), + errhint("In the latter case, find and close the transaction with more than %d subtransactions", PGPROC_MAX_CACHED_SUBXIDS))); else ereport(FATAL, (errcode(ERRCODE_CANNOT_CONNECT_NOW), diff --git a/src/include/tcop/backend_startup.h b/src/include/tcop/backend_startup.h index 7328561120..6580efcfbd 100644 --- a/src/include/tcop/backend_startup.h +++ b/src/include/tcop/backend_startup.h @@ -29,7 +29,7 @@ typedef enum CAC_state CAC_STARTUP, CAC_SHUTDOWN, CAC_RECOVERY, - CAC_NOTCONSISTENT, + CAC_NOTCONSISTENT_OR_OVERFLOWED, CAC_TOOMANY, } CAC_state; -- 2.43.0