From a0d81976406ea47ac249f07bf850e65d126627cb Mon Sep 17 00:00:00 2001 From: Tomas Vondra Date: Mon, 31 Mar 2025 14:56:56 +0200 Subject: [PATCH v8 4/5] review --- src/backend/storage/lmgr/proc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c index 4e23c793f7f..ba1ac7e4861 100644 --- a/src/backend/storage/lmgr/proc.c +++ b/src/backend/storage/lmgr/proc.c @@ -231,10 +231,11 @@ InitProcGlobal(void) requestSize, &found); + MemSet(ptr, 0, requestSize); + procs = (PGPROC *) ptr; ptr = (char *) ptr + TotalProcs * sizeof(PGPROC); - MemSet(procs, 0, TotalProcs * sizeof(PGPROC)); ProcGlobal->allProcs = procs; /* XXX allProcCount isn't really all of them; it excludes prepared xacts */ ProcGlobal->allProcCount = MaxBackends + NUM_AUXILIARY_PROCS; @@ -244,15 +245,12 @@ InitProcGlobal(void) * PROC_HDR. */ ProcGlobal->xids = (TransactionId *) ptr; - MemSet(ProcGlobal->xids, 0, TotalProcs * sizeof(*ProcGlobal->xids)); ptr = (char *) ptr + (TotalProcs * sizeof(*ProcGlobal->xids)); ProcGlobal->subxidStates = (XidCacheStatus *) ptr; - MemSet(ProcGlobal->subxidStates, 0, TotalProcs * sizeof(*ProcGlobal->subxidStates)); ptr = (char *) ptr + (TotalProcs * sizeof(*ProcGlobal->subxidStates)); ProcGlobal->statusFlags = (uint8 *) ptr; - MemSet(ProcGlobal->statusFlags, 0, TotalProcs * sizeof(*ProcGlobal->statusFlags)); ptr = (char *) ptr + (TotalProcs * sizeof(*ProcGlobal->statusFlags)); /* make sure wer didn't overflow */ -- 2.49.0