From b80bcbcf05e44d31cc90c1de2e3200899db1294f Mon Sep 17 00:00:00 2001 From: Bertrand Drouvot Date: Wed, 23 Apr 2025 07:19:44 +0000 Subject: [PATCH v1] Avoid core dump in pgstat_read_statsfile() Adding a check that pgstat_get_kind_info() is not NULL when loading the stats file. Without this extra check a non fixed_amount custom stats kind that has write_to_file enabled would produce a core dump should its PGSTAT_KIND ID change before a re-start. --- src/backend/utils/activity/pgstat.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/backend/utils/activity/pgstat.c b/src/backend/utils/activity/pgstat.c index 21bdff106a9..d735a2c1a58 100644 --- a/src/backend/utils/activity/pgstat.c +++ b/src/backend/utils/activity/pgstat.c @@ -1908,6 +1908,13 @@ pgstat_read_statsfile(void) key.objid, t); goto error; } + + if (!pgstat_get_kind_info(key.kind)) + { + elog(WARNING, "could not find information of kind %u for entry of type %c", + key.kind, t); + goto error; + } } else { -- 2.34.1