From 593d33896dcb618f806b911e80fd448fdacbba0a Mon Sep 17 00:00:00 2001 From: Melanie Plageman Date: Thu, 12 Jun 2025 15:38:37 -0400 Subject: [PATCH v1 01/14] Remove unused check in heap_xlog_insert() 8e03eb92e9ad54e2 reverted the commit 39b66a91bd which allowed freezing in the heap_insert() code path but did not remove the corresponding check in heap_xlog_insert(). This code is extraneous but not harmful. However, cleaning it up makes it very clear that, as of now, we do not support any freezing of pages in the heap_insert() path. --- src/backend/access/heap/heapam_xlog.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/backend/access/heap/heapam_xlog.c b/src/backend/access/heap/heapam_xlog.c index 30f4c2d3c67..fa94e104f1c 100644 --- a/src/backend/access/heap/heapam_xlog.c +++ b/src/backend/access/heap/heapam_xlog.c @@ -508,9 +508,8 @@ heap_xlog_insert(XLogReaderState *record) if (xlrec->flags & XLH_INSERT_ALL_VISIBLE_CLEARED) PageClearAllVisible(page); - /* XLH_INSERT_ALL_FROZEN_SET implies that all tuples are visible */ - if (xlrec->flags & XLH_INSERT_ALL_FROZEN_SET) - PageSetAllVisible(page); + /* This should not happen in the heap_insert() code path */ + Assert(!(xlrec->flags & XLH_INSERT_ALL_FROZEN_SET)); MarkBufferDirty(buffer); } -- 2.34.1