From b6797809a22f44841ca17f3bb750b71545818670 Mon Sep 17 00:00:00 2001 From: Cybrosys Date: Thu, 19 Mar 2026 11:22:08 +0530 Subject: [PATCH] Fix type of reduction variable in _bt_singleval_fillfactor The local variable 'reduction' in _bt_singleval_fillfactor() was declared as int, but it holds the result of multiplying leftfree (which is Size, i.e. size_t / unsigned long) by a double factor. Using a signed int is a type mismatch: Size is the correct type for any quantity representing a byte count, and matches the type of the variable it is subtracted from (maxpostingsize). In practice no overflow occurs with current BLCKSZ limits, but the wrong type is misleading and could silently misbehave on non-standard builds with very large BLCKSZ values. --- src/backend/access/nbtree/nbtdedup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/access/nbtree/nbtdedup.c b/src/backend/access/nbtree/nbtdedup.c index 08884116aec..61bf877d5d9 100644 --- a/src/backend/access/nbtree/nbtdedup.c +++ b/src/backend/access/nbtree/nbtdedup.c @@ -822,7 +822,7 @@ static void _bt_singleval_fillfactor(Page page, BTDedupState state, Size newitemsz) { Size leftfree; - int reduction; + Size reduction; /* This calculation needs to match nbtsplitloc.c */ leftfree = PageGetPageSize(page) - SizeOfPageHeaderData - -- 2.34.1