>From d411e69a0c9c05b7ffadf2d9fe6afa1e025377d5 Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Thu, 5 Apr 2012 11:09:59 +0200 Subject: [PATCH 05/19] wal_decoding: Add a new RELFILENODE syscache to fetch a pg_class entry via (reltablespace, relfilenode) This cache is theoretically problematic because formally indexes used by syscaches needs to be unique, this one is not. This is "just" because of 0/InvalidOid are stored in pg_class.relfilenode for nailed/shared catalog relations. This syscache will never be queried for InvalidOid relfilenodes however so it seems to be safe even if it bends the rules somewhat. It might be nicer to add infrastructure to do this properly, like using a partial index, its not clear what the best way to do this is though and the benefit very well might not be worth the overhead. Needs a CATVERSION bump. --- src/backend/utils/cache/syscache.c | 11 +++++++++++ src/include/catalog/indexing.h | 2 ++ src/include/utils/syscache.h | 1 + 3 files changed, 14 insertions(+) diff --git a/src/backend/utils/cache/syscache.c b/src/backend/utils/cache/syscache.c index bfc3c86..b5fe64f 100644 --- a/src/backend/utils/cache/syscache.c +++ b/src/backend/utils/cache/syscache.c @@ -591,6 +591,17 @@ static const struct cachedesc cacheinfo[] = { }, 64 }, + {RelationRelationId, /* RELFILENODE */ + ClassTblspcRelfilenodeIndexId, + 2, + { + Anum_pg_class_reltablespace, + Anum_pg_class_relfilenode, + 0, + 0 + }, + 1024 + }, {RelationRelationId, /* RELNAMENSP */ ClassNameNspIndexId, 2, diff --git a/src/include/catalog/indexing.h b/src/include/catalog/indexing.h index 6251fb8..2a3cd82 100644 --- a/src/include/catalog/indexing.h +++ b/src/include/catalog/indexing.h @@ -106,6 +106,8 @@ DECLARE_UNIQUE_INDEX(pg_class_oid_index, 2662, on pg_class using btree(oid oid_o #define ClassOidIndexId 2662 DECLARE_UNIQUE_INDEX(pg_class_relname_nsp_index, 2663, on pg_class using btree(relname name_ops, relnamespace oid_ops)); #define ClassNameNspIndexId 2663 +DECLARE_INDEX(pg_class_tblspc_relfilenode_index, 3455, on pg_class using btree(reltablespace oid_ops, relfilenode oid_ops)); +#define ClassTblspcRelfilenodeIndexId 3455 DECLARE_UNIQUE_INDEX(pg_collation_name_enc_nsp_index, 3164, on pg_collation using btree(collname name_ops, collencoding int4_ops, collnamespace oid_ops)); #define CollationNameEncNspIndexId 3164 diff --git a/src/include/utils/syscache.h b/src/include/utils/syscache.h index d1d8abe..2a14905 100644 --- a/src/include/utils/syscache.h +++ b/src/include/utils/syscache.h @@ -75,6 +75,7 @@ enum SysCacheIdentifier PROCNAMEARGSNSP, PROCOID, RANGETYPE, + RELFILENODE, RELNAMENSP, RELOID, RULERELNAME, -- 1.7.12.289.g0ce9864.dirty