From d8f036876661a67079b62c5415279a88ca19c26f Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Wed, 15 Jul 2026 15:02:51 +0200 Subject: [PATCH v19] doc: Fix link text for data checksums Commit 67846550dc6d removed the xreflabels for initdb options, which turned the sentence "The second field contains the page checksum if data checksums are enabled" into "The second field contains the page checksum if -k are enabled", as well "Only has effect if data checksums are enabled" into "Only has effect if -k are enabled". Fix by setting an explicit link text, and while there also change the link to point to the data checksum page which has more information than just the initdb option. The original report was for one instance, further inspection turned up quite a few more cases. Also redirect the link in the amcheck docs which albeit was reading right, but will be more helpful if linking to the main page on data checksums. Backpatch to v18 where the xreflabels were removed. Author: Daniel Gustafsson Reported-by: y.saburov@gmail.com Reviewed-by: Laurenz Albe Discussion: https://postgr.es/m/178350739237.73862.4549076173872335741@wrigleys.postgresql.org Backpatch-through: 18 --- doc/src/sgml/amcheck.sgml | 5 ++--- doc/src/sgml/config.sgml | 2 +- doc/src/sgml/storage.sgml | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/doc/src/sgml/amcheck.sgml b/doc/src/sgml/amcheck.sgml index 08006856579..13a6bb18897 100644 --- a/doc/src/sgml/amcheck.sgml +++ b/doc/src/sgml/amcheck.sgml @@ -421,9 +421,8 @@ SET client_min_messages = DEBUG1; amcheck can be effective at detecting various types of - failure modes that data - checksums will fail to catch. These include: + failure modes that data checksums will fail + to catch. These include: diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index 45827687b9c..f4fb7d0ecfe 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -13182,7 +13182,7 @@ LOG: CleanUpLock: deleting: lock(0xb7acd844) id(24688,24696,0,0,0,1) - Only has effect if are enabled. + Only has effect if data checksums are enabled. Detection of a checksum failure during a read normally causes diff --git a/doc/src/sgml/storage.sgml b/doc/src/sgml/storage.sgml index 6b6377503bf..19924b98d71 100644 --- a/doc/src/sgml/storage.sgml +++ b/doc/src/sgml/storage.sgml @@ -797,7 +797,7 @@ data. Empty in ordinary tables. (PageHeaderData). Its format is detailed in . The first field tracks the most recent WAL entry related to this page. The second field contains - the page checksum if are + the page checksum if data checksums are enabled. Next is a 2-byte field containing flag bits. This is followed by three 2-byte integer fields (pd_lower, pd_upper, and -- 2.39.3 (Apple Git-146)