From 3efc4bac5da22ba27b41e94e10854ee9a87f93b6 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 18 Aug 2026 10:52:24 +0200 Subject: [PATCH 05/11] Fix some -Wcast-qual warnings [postgres_fdw] Small rearrangement to avoid having to cast away const qualifiers. --- contrib/postgres_fdw/connection.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/contrib/postgres_fdw/connection.c b/contrib/postgres_fdw/connection.c index fc9583f369f..b5d4cf3dccc 100644 --- a/contrib/postgres_fdw/connection.c +++ b/contrib/postgres_fdw/connection.c @@ -580,28 +580,31 @@ construct_connection_params(ForeignServer *server, UserMapping *user, if (MyProcPort != NULL && MyProcPort->has_scram_keys && UseScramPassthrough(server, user)) { int len; + char *encoded; int encoded_len; keywords[n] = "scram_client_key"; len = pg_b64_enc_len(sizeof(MyProcPort->scram_ClientKey)); /* don't forget the zero-terminator */ - values[n] = palloc0(len + 1); + encoded = palloc0(len + 1); encoded_len = pg_b64_encode(MyProcPort->scram_ClientKey, sizeof(MyProcPort->scram_ClientKey), - (char *) values[n], len); + encoded, len); if (encoded_len < 0) elog(ERROR, "could not encode SCRAM client key"); + values[n] = encoded; n++; keywords[n] = "scram_server_key"; len = pg_b64_enc_len(sizeof(MyProcPort->scram_ServerKey)); /* don't forget the zero-terminator */ - values[n] = palloc0(len + 1); + encoded = palloc0(len + 1); encoded_len = pg_b64_encode(MyProcPort->scram_ServerKey, sizeof(MyProcPort->scram_ServerKey), - (char *) values[n], len); + encoded, len); if (encoded_len < 0) elog(ERROR, "could not encode SCRAM server key"); + values[n] = encoded; n++; /* -- 2.55.0