>From 84c8333f02abd3f973b3009d02dcbecc880ce909 Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Wed, 30 Apr 2014 17:35:15 +0200 Subject: [PATCH 4/4] Pass sensible value to memset() when randomizing reorderbuffer's tuple slab. This is entirely harmless, but still wrong. Noticed by coverity. --- src/backend/replication/logical/reorderbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c index 4493930..0b21be9 100644 --- a/src/backend/replication/logical/reorderbuffer.c +++ b/src/backend/replication/logical/reorderbuffer.c @@ -463,7 +463,7 @@ ReorderBufferGetTupleBuf(ReorderBuffer *rb) tuple = slist_container(ReorderBufferTupleBuf, node, slist_pop_head_node(&rb->cached_tuplebufs)); #ifdef USE_ASSERT_CHECKING - memset(tuple, 0xdeadbeef, sizeof(ReorderBufferTupleBuf)); + memset(tuple, 0xa9, sizeof(ReorderBufferTupleBuf)); #endif } else -- 1.8.3.251.g1462b67