From 098f11cfbf8f9370829e24e9f8d704c050c98875 Mon Sep 17 00:00:00 2001 From: MasaoFujii Date: Fri, 13 Jun 2014 22:09:39 +0900 Subject: [PATCH] Make log_disconnections PGC_SUSET rather than PGC_SIGHUP. So far even non-superusers could disable log_disconnections in order to prevent their session logout from being logged because the parameter was defined with PGC_BACKEND. This was harmful in the systems which need to audit all session logouts by using log_disconnections. For this problem, this commit changes the GUC context of log_disconnections to PGC_SIGHUP and forbids any client from changing its setting. --- doc/src/sgml/config.sgml | 3 ++- src/backend/utils/misc/guc.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index 37d78b3..f5f0324 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -4257,7 +4257,8 @@ local0.* /var/log/postgresql log_connections but at session termination, and includes the duration of the session. This is off by default. - This parameter cannot be changed after session start. + This parameter can only be set in the postgresql.conf + file or on the server command line. diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 3a31a75..19e521b 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -919,7 +919,7 @@ static struct config_bool ConfigureNamesBool[] = NULL, NULL, NULL }, { - {"log_disconnections", PGC_BACKEND, LOGGING_WHAT, + {"log_disconnections", PGC_SIGHUP, LOGGING_WHAT, gettext_noop("Logs end of a session, including duration."), NULL }, -- 1.7.12.4 (Apple Git-37)