>From 68a47c527080f46c7e00f1da888937913e675da1 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Sat, 14 Feb 2015 15:22:27 -0300 Subject: [PATCH 01/42] getObjectIdentity: Fix opclass/opfamily names The original representation uses "opcname for amname", which is good enough; but if we replace "for" with "using", we can apply the returned identity directly in a DROP command, as in DROP OPERATOR CLASS opcname USING amname This slightly simplify code using the identities to programatically execute commands on operator classes and families. Note backwards-incompatible change: This dates back to 9.3 when object identities were introduced by commit f8348ea3, but we don't want to change the behavior of released branches and so this is not backpatched. --- src/backend/catalog/objectaddress.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/catalog/objectaddress.c b/src/backend/catalog/objectaddress.c index 2f40733..d899dd7 100644 --- a/src/backend/catalog/objectaddress.c +++ b/src/backend/catalog/objectaddress.c @@ -3533,7 +3533,7 @@ getObjectIdentityParts(const ObjectAddress *object, appendStringInfoString(&buffer, quote_qualified_identifier(schema, NameStr(opcForm->opcname))); - appendStringInfo(&buffer, " for %s", + appendStringInfo(&buffer, " USING %s", quote_identifier(NameStr(amForm->amname))); if (objname) { @@ -4070,7 +4070,7 @@ getOpFamilyIdentity(StringInfo buffer, Oid opfid, List **objname, List **objargs amForm = (Form_pg_am) GETSTRUCT(amTup); schema = get_namespace_name(opfForm->opfnamespace); - appendStringInfo(buffer, "%s for %s", + appendStringInfo(buffer, "%s USING %s", quote_qualified_identifier(schema, NameStr(opfForm->opfname)), NameStr(amForm->amname)); -- 2.1.4