>From 8393aa62cddeaff8cc66b19c6ba36a371b090db1 Mon Sep 17 00:00:00 2001 From: Euler Taveira Date: Tue, 1 Sep 2015 23:46:33 -0300 Subject: [PATCH 2/3] Fix startpos parameter check. startpos parameter can be specified together with --create-slot (--start must be specified too). This check is wrong since --create-slot and --start could be specified together. --- src/bin/pg_basebackup/pg_recvlogical.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bin/pg_basebackup/pg_recvlogical.c b/src/bin/pg_basebackup/pg_recvlogical.c index 9ce237f..b59fe13 100644 --- a/src/bin/pg_basebackup/pg_recvlogical.c +++ b/src/bin/pg_basebackup/pg_recvlogical.c @@ -848,9 +848,9 @@ main(int argc, char **argv) exit(1); } - if (startpos != InvalidXLogRecPtr && (do_create_slot || do_drop_slot)) + if (startpos != InvalidXLogRecPtr && !do_start_slot) { - fprintf(stderr, _("%s: cannot use --create-slot or --drop-slot together with --startpos\n"), progname); + fprintf(stderr, _("%s: can only use --startpos together with --start\n"), progname); fprintf(stderr, _("Try \"%s --help\" for more information.\n"), progname); exit(1); -- 2.1.4