diff --git a/src/backend/catalog/heap.c b/src/backend/catalog/heap.c index 7d7d062..04c4f8f 100644 --- a/src/backend/catalog/heap.c +++ b/src/backend/catalog/heap.c @@ -2349,7 +2349,7 @@ AddRelationNewConstraints(Relation rel, * OK, store it. */ constrOid = - StoreRelCheck(rel, ccname, expr, !cdef->skip_validation, is_local, + StoreRelCheck(rel, ccname, expr, cdef->initially_valid, is_local, is_local ? 0 : 1, cdef->is_no_inherit, is_internal); numchecks++; diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y index fba91d5..8fdc442 100644 --- a/src/backend/parser/gram.y +++ b/src/backend/parser/gram.y @@ -3077,6 +3077,8 @@ ColConstraintElem: n->is_no_inherit = $5; n->raw_expr = $3; n->cooked_expr = NULL; + n->skip_validation = false; + n->initially_valid = true; $$ = (Node *)n; } | DEFAULT b_expr diff --git a/src/backend/parser/parse_utilcmd.c b/src/backend/parser/parse_utilcmd.c index 344a40c..df8b04f 100644 --- a/src/backend/parser/parse_utilcmd.c +++ b/src/backend/parser/parse_utilcmd.c @@ -120,6 +120,8 @@ static IndexStmt *transformIndexConstraint(Constraint *constraint, static void transformFKConstraints(CreateStmtContext *cxt, bool skipValidation, bool isAddConstraint); +static void transformCheckConstraints(CreateStmtContext *cxt, + bool skipValidation); static void transformConstraintAttrs(CreateStmtContext *cxt, List *constraintList); static void transformColumnType(CreateStmtContext *cxt, ColumnDef *column); @@ -320,6 +322,11 @@ transformCreateStmt(CreateStmt *stmt, const char *queryString) transformFKConstraints(&cxt, true, false); /* + * Postprocess check constraints. + */ + transformCheckConstraints(&cxt, true); + + /* * Output results. */ stmt->tableElts = cxt.columns; @@ -1915,6 +1922,32 @@ transformIndexConstraint(Constraint *constraint, CreateStmtContext *cxt) } /* + * transformCheckConstraints + * handle CHECK constraints + */ +static void +transformCheckConstraints(CreateStmtContext *cxt, bool skipValidation) +{ + ListCell *ckclist; + + if (cxt->ckconstraints == NIL) + return; + /* + * If CREATE TABLE we can safely skip validation of check + * constraints, and nonetheless mark them valid. + * (This will override any user-supplied NOT VALID flag.) + */ + if (skipValidation) + foreach(ckclist, cxt->ckconstraints) + { + Constraint *constraint = (Constraint *) lfirst(ckclist); + + constraint->skip_validation = true; + constraint->initially_valid = true; + } +} + +/* * transformFKConstraints * handle FOREIGN KEY constraints */