From c8faf979d34a04099597bdbbe952ca7a936e5dbe Mon Sep 17 00:00:00 2001 From: Ashutosh Bapat Date: Fri, 23 Mar 2018 14:37:46 +0530 Subject: [PATCH] Comment fix in BuildTupleFromCStrings() Explain in what case we need to invoke in() function even when the value string is NULL in BuildTupleFromCStrings(). Ashutosh Bapat --- src/backend/executor/execTuples.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/backend/executor/execTuples.c b/src/backend/executor/execTuples.c index c46d65c..5089b7f 100644 --- a/src/backend/executor/execTuples.c +++ b/src/backend/executor/execTuples.c @@ -1183,7 +1183,10 @@ BuildTupleFromCStrings(AttInMetadata *attinmeta, char **values) dvalues = (Datum *) palloc(natts * sizeof(Datum)); nulls = (bool *) palloc(natts * sizeof(bool)); - /* Call the "in" function for each non-dropped attribute */ + /* + * Call the "in" function for each non-dropped attribute, even for nulls, + * to support domains. + */ for (i = 0; i < natts; i++) { if (!TupleDescAttr(tupdesc, i)->attisdropped) -- 1.7.9.5