From 769aa5b8b5b74458d2ff67db47e1a127a93985ce Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Thu, 28 Jun 2018 00:07:47 +0200 Subject: [PATCH] Properly capitalize OpenSSL when used as a name OpenSSL is the name of the library, openssl is the cli application bundled with it. --- doc/src/sgml/install-windows.sgml | 6 +++--- src/backend/libpq/be-secure-openssl.c | 6 +++--- src/test/ssl/Makefile | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/src/sgml/install-windows.sgml b/doc/src/sgml/install-windows.sgml index 99e9c7b78e..02d2c6f846 100644 --- a/doc/src/sgml/install-windows.sgml +++ b/doc/src/sgml/install-windows.sgml @@ -293,11 +293,11 @@ $ENV{MSBFLAGS}="/m"; - openssl + OpenSSL Required for SSL support. Binaries can be downloaded from - or source from . + or source from . @@ -348,7 +348,7 @@ $ENV{MSBFLAGS}="/m"; To use a server-side third party library such as python or - openssl, this library must also be + OpenSSL, this library must also be 64-bit. There is no support for loading a 32-bit library in a 64-bit server. Several of the third party libraries that PostgreSQL supports may only be available in 32-bit versions, in which case they cannot be used with diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index 48b468f62f..310e9ba348 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -187,7 +187,7 @@ be_tls_init(bool isServerStart) SSL_CTX_set_options(context, SSL_OP_NO_SSLv2 | SSL_OP_NO_SSLv3); /* disallow SSL session tickets */ -#ifdef SSL_OP_NO_TICKET /* added in openssl 0.9.8f */ +#ifdef SSL_OP_NO_TICKET /* added in OpenSSL 0.9.8f */ SSL_CTX_set_options(context, SSL_OP_NO_TICKET); #endif @@ -638,7 +638,7 @@ be_tls_write(Port *port, void *ptr, size_t len, int *waitfor) * Private substitute BIO: this does the sending and receiving using send() and * recv() instead. This is so that we can enable and disable interrupts * just while calling recv(). We cannot have interrupts occurring while - * the bulk of openssl runs, because it uses malloc() and possibly other + * the bulk of OpenSSL runs, because it uses malloc() and possibly other * non-reentrant libc facilities. We also need to call send() and recv() * directly so it gets passed through the socket/signals layer on Win32. * @@ -736,7 +736,7 @@ my_BIO_s_socket(void) return my_bio_methods; } -/* This should exactly match openssl's SSL_set_fd except for using my BIO */ +/* This should exactly match OpenSSL's SSL_set_fd except for using my BIO */ static int my_SSL_set_fd(Port *port, int fd) { diff --git a/src/test/ssl/Makefile b/src/test/ssl/Makefile index df477f1d40..97389c90f8 100644 --- a/src/test/ssl/Makefile +++ b/src/test/ssl/Makefile @@ -32,7 +32,7 @@ SSLFILES := $(CERTIFICATES:%=ssl/%.key) $(CERTIFICATES:%=ssl/%.crt) \ # This target generates all the key and certificate files. sslfiles: $(SSLFILES) -# Openssl requires a directory to put all generated certificates in. We don't +# OpenSSL requires a directory to put all generated certificates in. We don't # use this for anything, but we need a location. ssl/new_certs_dir: mkdir ssl/new_certs_dir -- 2.14.1.145.gb3622a4ee