From 37a5f024bd6ded444b99cd441ef33062da950d1d Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Fri, 29 Mar 2019 19:37:35 -0500 Subject: [PATCH v5 03/12] Add comma for readability --- doc/src/sgml/backup.sgml | 2 +- doc/src/sgml/bki.sgml | 2 +- doc/src/sgml/client-auth.sgml | 4 ++-- doc/src/sgml/config.sgml | 4 ++-- doc/src/sgml/ddl.sgml | 2 +- doc/src/sgml/indices.sgml | 2 +- doc/src/sgml/installation.sgml | 2 +- doc/src/sgml/logical-replication.sgml | 2 +- doc/src/sgml/monitoring.sgml | 8 ++++---- doc/src/sgml/protocol.sgml | 6 +++--- doc/src/sgml/ref/create_table.sgml | 2 +- doc/src/sgml/ref/create_table_as.sgml | 2 +- doc/src/sgml/ref/pgupgrade.sgml | 2 +- doc/src/sgml/ref/psql-ref.sgml | 2 +- doc/src/sgml/sources.sgml | 20 ++++++++++---------- doc/src/sgml/wal.sgml | 2 +- doc/src/sgml/xoper.sgml | 2 +- 17 files changed, 33 insertions(+), 33 deletions(-) diff --git a/doc/src/sgml/backup.sgml b/doc/src/sgml/backup.sgml index 9d4c000..aba0414 100644 --- a/doc/src/sgml/backup.sgml +++ b/doc/src/sgml/backup.sgml @@ -1024,7 +1024,7 @@ SELECT pg_start_backup('label', true); consider during this backup. - As noted above, if the server crashes during the backup it may not be + As noted above, if the server crashes during the backup, it may not be possible to restart until the backup_label file has been manually deleted from the PGDATA directory. Note that it is very important to never remove the diff --git a/doc/src/sgml/bki.sgml b/doc/src/sgml/bki.sgml index aa3d6f8..e27fa76 100644 --- a/doc/src/sgml/bki.sgml +++ b/doc/src/sgml/bki.sgml @@ -403,7 +403,7 @@ 8000—9999. This minimizes the risk of OID collisions with other patches being developed concurrently. To keep the 8000—9999 range free for development purposes, after a patch has been committed - to the master git repository its OIDs should be renumbered into + to the master git repository, its OIDs should be renumbered into available space below that range. Typically, this will be done near the end of each development cycle, moving all OIDs consumed by patches committed in that cycle at the same time. The script diff --git a/doc/src/sgml/client-auth.sgml b/doc/src/sgml/client-auth.sgml index 3ed74d8..4a01b1b 100644 --- a/doc/src/sgml/client-auth.sgml +++ b/doc/src/sgml/client-auth.sgml @@ -157,7 +157,7 @@ hostnogssenc database user - To make use of this option the server must be built with + To make use of this option, the server must be built with SSL support. Furthermore, SSL must be enabled by setting the configuration parameter (see @@ -189,7 +189,7 @@ hostnogssenc database user - To make use of this option the server must be built with + To make use of this option, the server must be built with GSSAPI support. Otherwise, the hostgssenc record is ignored except for logging a warning that it cannot match any connections. diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index ff60875..b898214 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -3458,7 +3458,7 @@ restore_command = 'copy "C:\\server\\archivedir\\%f" "%p"' # Windows reached. The default is pause, which means recovery will be paused. promote means the recovery process will finish and the server will start to accept connections. - Finally shutdown will stop the server after reaching the + Finally, shutdown will stop the server after reaching the recovery target. @@ -4188,7 +4188,7 @@ ANY num_sync ( @@ -3018,7 +3018,7 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i pg_statio_user_tables and pg_statio_sys_tables views contain the same information, - but filtered to only show user and system tables respectively. + but filtered to only show user and system tables, respectively. @@ -3079,7 +3079,7 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i pg_statio_user_indexes and pg_statio_sys_indexes views contain the same information, - but filtered to only show user and system indexes respectively. + but filtered to only show user and system indexes, respectively.
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml index 70f7286..3f907f6 100644 --- a/doc/src/sgml/protocol.sgml +++ b/doc/src/sgml/protocol.sgml @@ -1449,7 +1449,7 @@ SELECT 1/0; S, perform an SSL startup handshake (not described here, part of the SSL specification) with the server. If this is successful, continue - with sending the usual StartupMessage. In this case the + with sending the usual StartupMessage. In this case, the StartupMessage and all subsequent data will be SSL-encrypted. To continue after N, send the usual StartupMessage and proceed without @@ -1462,7 +1462,7 @@ SELECT 1/0; the server predates the addition of SSL support to PostgreSQL. (Such servers are now very ancient, and likely do not exist in the wild anymore.) - In this case the connection must + In this case, the connection must be closed, but the frontend might choose to open a fresh connection and proceed without requesting SSL. @@ -1528,7 +1528,7 @@ SELECT 1/0; The frontend should also be prepared to handle an ErrorMessage response to GSSENCRequest from the server. This would only occur if the server predates the addition of GSSAPI encryption - support to PostgreSQL. In this case the + support to PostgreSQL. In this case, the connection must be closed, but the frontend might choose to open a fresh connection and proceed without requesting GSSAPI encryption. Given the length limits specified above, the ErrorMessage diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_table.sgml index 9009add..4f3ff1d 100644 --- a/doc/src/sgml/ref/create_table.sgml +++ b/doc/src/sgml/ref/create_table.sgml @@ -1189,7 +1189,7 @@ WITH ( MODULUS numeric_literal, REM This clause specifies optional storage parameters for a table or index; see for more - information. For backward-compatibility the WITH + information. For backward-compatibility, the WITH clause for a table can also include OIDS=FALSE to specify that rows of the new table should not contain OIDs (object identifiers), OIDS=TRUE is not supported anymore. diff --git a/doc/src/sgml/ref/create_table_as.sgml b/doc/src/sgml/ref/create_table_as.sgml index b5c4ce6..0880459 100644 --- a/doc/src/sgml/ref/create_table_as.sgml +++ b/doc/src/sgml/ref/create_table_as.sgml @@ -142,7 +142,7 @@ CREATE [ [ GLOBAL | LOCAL ] { TEMPORARY | TEMP } | UNLOGGED ] TABLE [ IF NOT EXI This clause specifies optional storage parameters for the new table; see for more - information. For backward-compatibility the WITH + information. For backward-compatibility, the WITH clause for a table can also include OIDS=FALSE to specify that rows of the new table should contain no OIDs (object identifiers), OIDS=TRUE is not supported anymore. diff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.sgml index 8288676..6a898d9 100644 --- a/doc/src/sgml/ref/pgupgrade.sgml +++ b/doc/src/sgml/ref/pgupgrade.sgml @@ -746,7 +746,7 @@ psql --username=postgres --file=script.sql postgres pg_upgrade launches short-lived postmasters in the old and new data directories. Temporary Unix socket files for communication with these postmasters are, by default, made in the current - working directory. In some situations the path name for the current + working directory. In some situations, the path name for the current directory might be too long to be a valid socket name. In that case you can use the option to put the socket files in some directory with a shorter path name. For security, be sure that that diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml index 7789fc6..8076495 100644 --- a/doc/src/sgml/ref/psql-ref.sgml +++ b/doc/src/sgml/ref/psql-ref.sgml @@ -1056,7 +1056,7 @@ testdb=> These operations are not as efficient as the SQL COPY command with a file or program data source or destination, because all data must pass through the client/server - connection. For large amounts of data the SQL + connection. For large amounts of data, the SQL command might be preferable. diff --git a/doc/src/sgml/sources.sgml b/doc/src/sgml/sources.sgml index b94e7f7..c57f51d 100644 --- a/doc/src/sgml/sources.sgml +++ b/doc/src/sgml/sources.sgml @@ -100,7 +100,7 @@ less -x4 There are two required elements for every message: a severity level (ranging from DEBUG to PANIC) and a primary - message text. In addition there are optional elements, the most + message text. In addition, there are optional elements, the most common of which is an error identifier code that follows the SQL spec's SQLSTATE conventions. ereport itself is just a shell function that exists @@ -473,7 +473,7 @@ Hint: the addendum Rationale: Messages are not necessarily displayed on terminal-type - displays. In GUI displays or browsers these formatting instructions are + displays. In GUI displays or browsers, these formatting instructions are at best ignored. @@ -884,7 +884,7 @@ BETTER: unrecognized node type: 42 features can be used, if a fallback is provided. - For example _StaticAssert() and + For example, _StaticAssert() and __builtin_constant_p are currently used, even though they are from a newer revision of the C standard and a GCC extension, respectively. If not available, in the first case, @@ -897,14 +897,14 @@ BETTER: unrecognized node type: 42 Function-Like Macros and Inline Functions - Both, macros with arguments and static inline - functions, may be used. The latter are preferable if there are + Both macros with arguments and static inline + functions may be used. The latter are preferable if there are multiple-evaluation hazards when written as a macro, as e.g. the case with #define Max(x, y) ((x) > (y) ? (x) : (y)) - or when the macro would be very long. In other cases it's only + or when the macro would be very long. In other cases, it's only possible to use macros, or at least easier. For example because expressions of various types need to be passed to the macro. @@ -936,16 +936,16 @@ MemoryContextSwitchTo(MemoryContext context) Writing Signal Handlers - To be suitable to run inside a signal handler code has to be + To be suitable to run inside a signal handler, code has to be written very carefully. The fundamental problem is that, unless blocked, a signal handler can interrupt code at any time. If code - inside the signal handler uses the same state as code outside - chaos may ensue. As an example consider what happens if a signal + inside the signal handler uses the same state as code outside, + chaos may ensue. As an example, consider what happens if a signal handler tries to acquire a lock that's already held in the interrupted code. - Barring special arrangements code in signal handlers may only + Barring special arrangements, code in signal handlers may only call async-signal safe functions (as defined in POSIX) and access variables of type volatile sig_atomic_t. A few functions in postgres are also deemed signal safe; specifically, diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml index 4eb8feb..30bde24 100644 --- a/doc/src/sgml/wal.sgml +++ b/doc/src/sgml/wal.sgml @@ -326,7 +326,7 @@ before returning a success indication to the client. The client is therefore guaranteed that a transaction reported to be committed will be preserved, even in the event of a server crash immediately after. - However, for short transactions this delay is a major component of the + However, for short transactions, this delay is a major component of the total transaction time. Selecting asynchronous commit mode means that the server returns success as soon as the transaction is logically completed, before the WAL records it generated have diff --git a/doc/src/sgml/xoper.sgml b/doc/src/sgml/xoper.sgml index 260e43c..55cd3b1 100644 --- a/doc/src/sgml/xoper.sgml +++ b/doc/src/sgml/xoper.sgml @@ -375,7 +375,7 @@ table1.column1 OP table2.column2 Another example is that on machines that meet the IEEE floating-point standard, negative zero and positive zero are different values (different bit patterns) but they are defined to compare equal. - If a float value might contain negative zero then extra steps are needed + If a float value might contain negative zero, then extra steps are needed to ensure it generates the same hash value as positive zero. -- 2.7.4