From e08299ddf92abc3fb4e802e8b475097fa746c458 Mon Sep 17 00:00:00 2001 From: Alexey Kondratov Date: Wed, 25 Dec 2019 20:12:42 +0300 Subject: [PATCH v2] Make physical replslot advance persistent --- src/backend/replication/slotfuncs.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/backend/replication/slotfuncs.c b/src/backend/replication/slotfuncs.c index 6683fc3f9b..bc5c93b089 100644 --- a/src/backend/replication/slotfuncs.c +++ b/src/backend/replication/slotfuncs.c @@ -573,9 +573,17 @@ pg_replication_slot_advance(PG_FUNCTION_ARGS) values[0] = NameGetDatum(&MyReplicationSlot->data.name); nulls[0] = false; - /* Update the on disk state when lsn was updated. */ - if (XLogRecPtrIsInvalid(endlsn)) + /* + * Update the on disk state when LSN was updated. Here we rely on the facts + * that: 1) minlsn is initialized with restart_lsn and confirmed_flush LSN for + * physical and logical replication slot respectively, and 2) endlsn is set in + * the same way by pg_*_replication_slot_advance, but after advance. Thus, + * endlsn <= minlsn is treated as a no-op. + */ + if (endlsn > minlsn) { + elog(DEBUG1, "flushing replication slot '%s' state", + NameStr(MyReplicationSlot->data.name)); ReplicationSlotMarkDirty(); ReplicationSlotsComputeRequiredXmin(false); ReplicationSlotsComputeRequiredLSN(); base-commit: 8ce3aa9b5914d1ac45ed3f9bc484f66b3c4850c7 -- 2.17.1