From 084eb3d257f49c4b25df9911e46d649a09399a2e Mon Sep 17 00:00:00 2001 From: Mike Palmiotto Date: Wed, 4 Mar 2020 04:00:55 +0000 Subject: [PATCH 10/11] Update StartSubprocess comments --- src/backend/postmaster/postmaster.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c index f7a433f3a3..06622d3acb 100644 --- a/src/backend/postmaster/postmaster.c +++ b/src/backend/postmaster/postmaster.c @@ -5375,11 +5375,13 @@ CountChildren(int target) /* * StartChildProcess -- start an auxiliary process for the postmaster * - * "type" determines what kind of child will be started. All child types - * initially go to AuxiliaryProcessMain, which will handle common setup. + * "type" determines what kind of child will be started. This code relies + * heavily on MySubprocess, which is an entry in the process_types struct in + * subprocess.c. All auxiliary processes go through AuxiliaryProcessMain after + * forking. Everything else goes through the designated entrypoint. * - * Return value of StartChildProcess is subprocess' PID, or 0 if failed - * to start subprocess. + * Return value of StartChildProcess is subprocess' PID on success. On failure, + * the subprocess cleanup function decides whether or not to panic. */ static pid_t StartSubprocess(SubprocessType type) -- 2.21.0