From ef139f89531ba15f480cbb64c2bddeee03dc20ab Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Tue, 8 Sep 2020 16:55:30 -0300 Subject: [PATCH v3 1/2] Don't "getsomeattrs" on virtual slots MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit execute_attr_map_slot() was not careful about not calling slot_getallattrs() on tuple slots that could be virtual. Repair. Author: Álvaro Herrera --- src/backend/access/common/tupconvert.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/backend/access/common/tupconvert.c b/src/backend/access/common/tupconvert.c index 3cb0cbefaa..d440c1201a 100644 --- a/src/backend/access/common/tupconvert.c +++ b/src/backend/access/common/tupconvert.c @@ -193,7 +193,8 @@ execute_attr_map_slot(AttrMap *attrMap, outnatts = out_slot->tts_tupleDescriptor->natts; /* Extract all the values of the in slot. */ - slot_getallattrs(in_slot); + if (!TTS_IS_VIRTUAL(in_slot)) + slot_getallattrs(in_slot); /* Before doing the mapping, clear any old contents from the out slot */ ExecClearTuple(out_slot); -- 2.20.1