From cd94b204749da311506155141cd3d2eb179e28c2 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Thu, 5 Nov 2020 14:14:31 -0300 Subject: [PATCH 3/3] Add comment --- src/backend/access/brin/brin_tuple.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/backend/access/brin/brin_tuple.c b/src/backend/access/brin/brin_tuple.c index e3d5bde51b..6774f597a4 100644 --- a/src/backend/access/brin/brin_tuple.c +++ b/src/backend/access/brin/brin_tuple.c @@ -159,6 +159,12 @@ brin_form_tuple(BrinDesc *brdesc, BlockNumber blkno, BrinMemTuple *tuple, if (tuple->bt_columns[keyno].bv_hasnulls) anynulls = true; + /* + * Now obtain the values of each stored datum. Note that some values + * might be toasted, and we cannot rely on the original heap values + * sticking around forever, so we must detoast them. Also try to + * compress them. + */ for (datumno = 0; datumno < brdesc->bd_info[keyno]->oi_nstored; datumno++) -- 2.20.1