From e08c6d3e2b10964633904ff247e70330077d31b4 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Fri, 13 Nov 2020 13:39:31 -0300 Subject: [PATCH v2] error_severity of brin work item --- src/backend/access/brin/brin.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c index 1f72562c60..8278a5209c 100644 --- a/src/backend/access/brin/brin.c +++ b/src/backend/access/brin/brin.c @@ -887,8 +887,10 @@ brin_summarize_range(PG_FUNCTION_ARGS) /* * We must lock table before index to avoid deadlocks. However, if the * passed indexoid isn't an index then IndexGetRelation() will fail. - * Rather than emitting a not-very-helpful error message, postpone - * complaining, expecting that the is-it-an-index test below will fail. + * Rather than emitting a not-very-helpful error message, prepare to + * return without doing anything. This allows autovacuum work-items to be + * silently discarded rather than uselessly accumulating error messages in + * the server log. */ heapoid = IndexGetRelation(indexoid, true); if (OidIsValid(heapoid)) @@ -896,7 +898,14 @@ brin_summarize_range(PG_FUNCTION_ARGS) else heapRel = NULL; - indexRel = index_open(indexoid, ShareUpdateExclusiveLock); + indexRel = try_relation_open(indexoid, ShareUpdateExclusiveLock); + if (heapRel == NULL || indexRel == NULL) + { + if (heapRel != NULL) + table_close(heapRel, ShareUpdateExclusiveLock); + + PG_RETURN_INT32(0); + } /* Must be a BRIN index */ if (indexRel->rd_rel->relkind != RELKIND_INDEX || -- 2.17.0