From 2f6d8a4d0157b632ad1e0ff3b0a54c4d38199637 Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Sat, 30 Jan 2021 18:10:21 -0600 Subject: [PATCH 11/18] duplicate words commit 9c4f5192f69ed16c99e0d079f0b5faebd7bad212 Allow pg_rewind to use a standby server as the source system. commit 4a252996d5fda7662b2afdf329a5c95be0fe3b01 Add tests for tuplesort.c. commit 0a2bc5d61e713e3fe72438f020eea5fcc90b0f0b Move per-agg and per-trans duplicate finding to the planner. commit 623a9ba79bbdd11c5eccb30b8bd5c446130e521c snapshot scalability: cache snapshots using a xact completion counter. commit 2c03216d831160bedd72d45f712601b6f7d03f1c Revamp the WAL record format. --- src/backend/access/transam/xlogutils.c | 3 +-- src/backend/optimizer/prep/prepagg.c | 2 +- src/backend/storage/ipc/procarray.c | 2 +- src/bin/pg_rewind/libpq_source.c | 2 +- src/test/regress/expected/tuplesort.out | 2 +- src/test/regress/sql/tuplesort.sql | 2 +- 6 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/backend/access/transam/xlogutils.c b/src/backend/access/transam/xlogutils.c index e723253297..25d6df1659 100644 --- a/src/backend/access/transam/xlogutils.c +++ b/src/backend/access/transam/xlogutils.c @@ -433,8 +433,7 @@ XLogReadBufferForRedoExtended(XLogReaderState *record, * NB: A redo function should normally not call this directly. To get a page * to modify, use XLogReadBufferForRedoExtended instead. It is important that * all pages modified by a WAL record are registered in the WAL records, or - * they will be invisible to tools that that need to know which pages are - * modified. + * they will be invisible to tools that need to know which pages are modified. */ Buffer XLogReadBufferExtended(RelFileNode rnode, ForkNumber forknum, diff --git a/src/backend/optimizer/prep/prepagg.c b/src/backend/optimizer/prep/prepagg.c index 929a8ea13b..89046f9afb 100644 --- a/src/backend/optimizer/prep/prepagg.c +++ b/src/backend/optimizer/prep/prepagg.c @@ -71,7 +71,7 @@ static Datum GetAggInitVal(Datum textInitVal, Oid transtype); * * Information about the aggregates and transition functions are collected * in the root->agginfos and root->aggtransinfos lists. The 'aggtranstype', - * 'aggno', and 'aggtransno' fields in are filled in in each Aggref. + * 'aggno', and 'aggtransno' fields of each Aggref are filled in. * * NOTE: This modifies the Aggrefs in the input expression in-place! * diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c index cf12eda504..b9fbdcb88f 100644 --- a/src/backend/storage/ipc/procarray.c +++ b/src/backend/storage/ipc/procarray.c @@ -2049,7 +2049,7 @@ GetSnapshotDataReuse(Snapshot snapshot) * holding ProcArrayLock) exclusively). Thus the xactCompletionCount check * ensures we would detect if the snapshot would have changed. * - * As the snapshot contents are the same as it was before, it is is safe + * As the snapshot contents are the same as it was before, it is safe * to re-enter the snapshot's xmin into the PGPROC array. None of the rows * visible under the snapshot could already have been removed (that'd * require the set of running transactions to change) and it fulfills the diff --git a/src/bin/pg_rewind/libpq_source.c b/src/bin/pg_rewind/libpq_source.c index 86d2adcaee..ac794cf4eb 100644 --- a/src/bin/pg_rewind/libpq_source.c +++ b/src/bin/pg_rewind/libpq_source.c @@ -539,7 +539,7 @@ process_queued_fetch_requests(libpq_source *src) chunkoff, rq->path, (int64) rq->offset); /* - * We should not receive receive more data than we requested, or + * We should not receive more data than we requested, or * pg_read_binary_file() messed up. We could receive less, * though, if the file was truncated in the source after we * checked its size. That's OK, there should be a WAL record of diff --git a/src/test/regress/expected/tuplesort.out b/src/test/regress/expected/tuplesort.out index 3fc1998bf2..418f296a3f 100644 --- a/src/test/regress/expected/tuplesort.out +++ b/src/test/regress/expected/tuplesort.out @@ -1,7 +1,7 @@ -- only use parallelism when explicitly intending to do so SET max_parallel_maintenance_workers = 0; SET max_parallel_workers = 0; --- A table with with contents that, when sorted, triggers abbreviated +-- A table with contents that, when sorted, triggers abbreviated -- key aborts. One easy way to achieve that is to use uuids that all -- have the same prefix, as abbreviated keys for uuids just use the -- first sizeof(Datum) bytes. diff --git a/src/test/regress/sql/tuplesort.sql b/src/test/regress/sql/tuplesort.sql index 7d7e02f02a..846484d561 100644 --- a/src/test/regress/sql/tuplesort.sql +++ b/src/test/regress/sql/tuplesort.sql @@ -2,7 +2,7 @@ SET max_parallel_maintenance_workers = 0; SET max_parallel_workers = 0; --- A table with with contents that, when sorted, triggers abbreviated +-- A table with contents that, when sorted, triggers abbreviated -- key aborts. One easy way to achieve that is to use uuids that all -- have the same prefix, as abbreviated keys for uuids just use the -- first sizeof(Datum) bytes. -- 2.17.0