From 965c18471919e231ec94edac9025f7178f121206 Mon Sep 17 00:00:00 2001 From: Dilip Kumar Date: Mon, 31 May 2021 14:37:26 +0530 Subject: [PATCH v1] Extract unchanged replica identity key if it is stored externally If replica identity is set to key and the key is not modified we don't log key seperately because it should be logged along with the updated tuple. But if the key is stored externally we must have to detoast and log it separately. --- src/backend/access/heap/heapam.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c index bd60129..27d60e6 100644 --- a/src/backend/access/heap/heapam.c +++ b/src/backend/access/heap/heapam.c @@ -8407,8 +8407,11 @@ ExtractReplicaIdentity(Relation relation, HeapTuple tp, bool key_changed, return tp; } - /* if the key hasn't changed and we're only logging the key, we're done */ - if (!key_changed) + /* + * if the key hasn't changedand we're only logging the key, we're done. + * But if tuple has external data then we might have to detoast the key. + */ + if ((!key_changed) && !HeapTupleHasExternal(tp)) return NULL; /* find out the replica identity columns */ -- 1.8.3.1