From fafb23a62835f7d35bd3f4642b06253cf16cbfca Mon Sep 17 00:00:00 2001 From: Ranier Vilela Date: Thu, 15 Jul 2021 21:40:20 -0300 Subject: [PATCH] Reduce Wsign-compare warnings from clang-12 compiler. All size_t variables declared in procarray.c, are true ints. Lets promove a changes for int, reducing warnings like "comparison of integers of different signs". No need to backpatch, why this patch is classified as refactoring only. --- src/backend/storage/ipc/procarray.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c index 286132c696..efb489bc5d 100644 --- a/src/backend/storage/ipc/procarray.c +++ b/src/backend/storage/ipc/procarray.c @@ -703,7 +703,7 @@ ProcArrayEndTransaction(PGPROC *proc, TransactionId latestXid) static inline void ProcArrayEndTransactionInternal(PGPROC *proc, TransactionId latestXid) { - size_t pgxactoff = proc->pgxactoff; + int pgxactoff = proc->pgxactoff; /* * Note: we need exclusive lock here because we're going to change other @@ -875,7 +875,7 @@ ProcArrayGroupClearXid(PGPROC *proc, TransactionId latestXid) void ProcArrayClearTransaction(PGPROC *proc) { - size_t pgxactoff; + int pgxactoff; /* * Currently we need to lock ProcArrayLock exclusively here, as we @@ -1355,7 +1355,7 @@ TransactionIdIsInProgress(TransactionId xid) TransactionId topxid; TransactionId latestCompletedXid; int mypgxactoff; - size_t numProcs; + int numProcs; int j; /* @@ -1432,7 +1432,7 @@ TransactionIdIsInProgress(TransactionId xid) /* No shortcuts, gotta grovel through the array */ mypgxactoff = MyProc->pgxactoff; numProcs = arrayP->numProcs; - for (size_t pgxactoff = 0; pgxactoff < numProcs; pgxactoff++) + for (int pgxactoff = 0; pgxactoff < numProcs; pgxactoff++) { int pgprocno; PGPROC *proc; @@ -2167,7 +2167,7 @@ GetSnapshotData(Snapshot snapshot) TransactionId *other_xids = ProcGlobal->xids; TransactionId xmin; TransactionId xmax; - size_t count = 0; + int count = 0; int subcount = 0; bool suboverflowed = false; FullTransactionId latest_completed; @@ -2249,7 +2249,7 @@ GetSnapshotData(Snapshot snapshot) if (!snapshot->takenDuringRecovery) { - size_t numProcs = arrayP->numProcs; + int numProcs = arrayP->numProcs; TransactionId *xip = snapshot->xip; int *pgprocnos = arrayP->pgprocnos; XidCacheStatus *subxidStates = ProcGlobal->subxidStates; @@ -2259,7 +2259,7 @@ GetSnapshotData(Snapshot snapshot) * First collect set of pgxactoff/xids that need to be included in the * snapshot. */ - for (size_t pgxactoff = 0; pgxactoff < numProcs; pgxactoff++) + for (int pgxactoff = 0; pgxactoff < numProcs; pgxactoff++) { /* Fetch xid just once - see GetNewTransactionId */ TransactionId xid = UINT32_ACCESS_ONCE(other_xids[pgxactoff]); -- 2.25.1