From 30033d810bcc784da55600792484603e1c46b3d7 Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi Date: Mon, 19 Jul 2021 14:49:34 +0900 Subject: [PATCH v1] Don't forget message of hage-header errors while not in standby mode The commit 0668719801 intended to omit page-header errors only while in standby mode but actually it is always forgotten. As the result the message of the end of a crash recovery lacks the reason for the stop. Fix that by doing the additional check only while in standby mode. --- src/backend/access/transam/xlog.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 2ee9515139..79513fb8b5 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -12317,7 +12317,8 @@ retry: * Validating the page header is cheap enough that doing it twice * shouldn't be a big deal from a performance point of view. */ - if (!XLogReaderValidatePageHeader(xlogreader, targetPagePtr, readBuf)) + if (StandbyMode && + !XLogReaderValidatePageHeader(xlogreader, targetPagePtr, readBuf)) { /* reset any error XLogReaderValidatePageHeader() might have set */ xlogreader->errormsg_buf[0] = '\0'; -- 2.27.0