From 3833c5d48c65ff0bf8b6cb99f438d367feda799f Mon Sep 17 00:00:00 2001 From: Peter Smith Date: Wed, 8 Sep 2021 16:19:51 +1000 Subject: [PATCH v3] PG Docs - Create Subscription - options rewording Some rewording to improve grammar of the subscription_parameter descriptions. --- doc/src/sgml/ref/create_subscription.sgml | 42 +++++++++++++++---------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index 3c0bf37..05f728c 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -111,18 +111,18 @@ CREATE SUBSCRIPTION subscription_name - It is not allowed to combine connect set to + You are not allowed a combination of connect set to false and enabled, create_slot, or copy_data set to true. - Since no connection is made when this option is set - to false, the tables are not subscribed, and so + Since no connection is made when this option is + false, the tables are not subscribed, and so after you enable the subscription nothing will be replicated. It is required to run - ALTER SUBSCRIPTION ... REFRESH PUBLICATION in order + ALTER SUBSCRIPTION ... REFRESH PUBLICATION for tables to be subscribed. @@ -142,8 +142,8 @@ CREATE SUBSCRIPTION subscription_nameenabled (boolean) - Specifies whether the subscription should be actively replicating, - or whether it should be just setup but not started yet. The default + Specifies whether the subscription should be actively replicating + or whether it should be just set up but not started yet. The default is true. @@ -158,10 +158,10 @@ CREATE SUBSCRIPTION subscription_name - When slot_name is set to - NONE, there will be no replication slot - associated with the subscription. This can be used if the - replication slot will be created later manually. Such + Setting slot_name to NONE + means there will be no replication slot + associated with the subscription. Use this when you will be + creating the replication slot later manually. Such subscriptions must also have both enabled and create_slot set to false. @@ -182,14 +182,14 @@ CREATE SUBSCRIPTION subscription_namefalse. - Even when this option is enabled, only data types that have + Even when this option is enabled, only data types having binary send and receive functions will be transferred in binary. - When doing cross-version replication, it could happen that the + When doing cross-version replication, it could be that the publisher has a binary send function for some data type, but the - subscriber lacks a binary receive function for the type. In + subscriber lacks a binary receive function for that type. In such a case, data transfer will fail, and the binary option cannot be used. @@ -200,8 +200,8 @@ CREATE SUBSCRIPTION subscription_namecopy_data (boolean) - Specifies whether the existing data in the publications that are - being subscribed to should be copied once the replication starts. + Specifies whether to copy the existing data in the publications + subscribed to once the replication starts. The default is true. @@ -211,9 +211,9 @@ CREATE SUBSCRIPTION subscription_namestreaming (boolean) - Specifies whether streaming of in-progress transactions should - be enabled for this subscription. By default, all transactions - are fully decoded on the publisher, and only then sent to the + Specifies whether to enable streaming of in-progress transactions + for this subscription. By default, all transactions + are fully decoded on the publisher and only then sent to the subscriber as a whole. @@ -260,17 +260,17 @@ CREATE SUBSCRIPTION subscription_name - When two-phase commit is enabled then the decoded transactions are sent + When two-phase commit is enabled the decoded transactions are sent to the subscriber on the PREPARE TRANSACTION. By default, the transaction prepared on the publisher is decoded as a normal transaction at commit. The two-phase commit implementation requires that the replication has - successfully passed the initial table synchronization phase. This means + successfully passed the initial table synchronization phase. So even when two_phase is enabled for the subscription, the internal two-phase state remains temporarily "pending" until the initialization - phase is completed. See column + phase completes. See column subtwophasestate of to know the actual two-phase state. -- 1.8.3.1