From 11a9612c2590f57f431c3918d5b62c08a5b29efb Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi Date: Wed, 27 Oct 2021 11:39:02 +0900 Subject: [PATCH] Change log_(dis)connections to PGC_SIGHUP log_connections is not effective when it is given in connection options. Since no complaint has been heard for this behavior the use-case looks rather thin. Thus we change it to PGC_SIGHUP, rahther than putting efforts to make it effective for the use-case. log_disconnections is working with the usage but be consistent by treating it the same way with log_connection. --- doc/src/sgml/config.sgml | 8 ++++---- src/backend/utils/misc/guc.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index de77f14573..64b04a47d2 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -6800,8 +6800,8 @@ local0.* /var/log/postgresql Causes each attempted connection to the server to be logged, as well as successful completion of both client authentication (if necessary) and authorization. - Only superusers can change this parameter at session start, - and it cannot be changed at all within a session. + This parameter can only be set in the postgresql.conf + file or on the server command line. The default is off. @@ -6827,8 +6827,8 @@ local0.* /var/log/postgresql Causes session terminations to be logged. The log output provides information similar to log_connections, plus the duration of the session. - Only superusers can change this parameter at session start, - and it cannot be changed at all within a session. + This parameter can only be set in the postgresql.conf + file or on the server command line. The default is off. diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index e91d5a3cfd..57d810c80d 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -1353,7 +1353,7 @@ static struct config_bool ConfigureNamesBool[] = NULL, NULL, NULL }, { - {"log_connections", PGC_SU_BACKEND, LOGGING_WHAT, + {"log_connections", PGC_SIGHUP, LOGGING_WHAT, gettext_noop("Logs each successful connection."), NULL }, @@ -1362,7 +1362,7 @@ static struct config_bool ConfigureNamesBool[] = NULL, NULL, NULL }, { - {"log_disconnections", PGC_SU_BACKEND, LOGGING_WHAT, + {"log_disconnections", PGC_SIGHUP, LOGGING_WHAT, gettext_noop("Logs end of a session, including duration."), NULL }, -- 2.27.0