From cd58094d9623a57bfe15a5790120fba694523b0f Mon Sep 17 00:00:00 2001 From: Nathan Bossart Date: Sun, 5 Dec 2021 21:42:52 -0800 Subject: [PATCH v7 4/6] Move pgsql_tmp file removal to custodian process. With this change, startup (and restart after a crash) simply renames the pgsql_tmp directories, and the custodian process actually removes all the files in the staged directories as well as the staged directories themselves. This should help avoid long startup delays due to many leftover temporary files. --- src/backend/postmaster/custodian.c | 1 + src/backend/postmaster/postmaster.c | 24 +++++++++++++++++++----- src/backend/storage/file/fd.c | 13 +++++++------ src/include/postmaster/custodian.h | 2 +- 4 files changed, 28 insertions(+), 12 deletions(-) diff --git a/src/backend/postmaster/custodian.c b/src/backend/postmaster/custodian.c index e90f5d0d1f..fe1f48844e 100644 --- a/src/backend/postmaster/custodian.c +++ b/src/backend/postmaster/custodian.c @@ -70,6 +70,7 @@ struct cust_task_funcs_entry * whether the task is already enqueued. */ static const struct cust_task_funcs_entry cust_task_functions[] = { + {CUSTODIAN_REMOVE_TEMP_FILES, RemovePgTempFiles, NULL}, {INVALID_CUSTODIAN_TASK, NULL, NULL} /* must be last */ }; diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c index 50f348c42c..ed120eb836 100644 --- a/src/backend/postmaster/postmaster.c +++ b/src/backend/postmaster/postmaster.c @@ -112,6 +112,7 @@ #include "postmaster/autovacuum.h" #include "postmaster/auxprocess.h" #include "postmaster/bgworker_internals.h" +#include "postmaster/custodian.h" #include "postmaster/fork_process.h" #include "postmaster/interrupt.h" #include "postmaster/pgarch.h" @@ -1400,9 +1401,12 @@ PostmasterMain(int argc, char *argv[]) /* * Remove old temporary files. At this point there can be no other * Postgres processes running in this directory, so this should be safe. + * + * Note that this just stages the pgsql_tmp directories for deletion. The + * custodian process is responsible for actually removing the files. */ StagePgTempFilesForRemoval(); - RemovePgTempFiles(); + RequestCustodian(CUSTODIAN_REMOVE_TEMP_FILES, false, (Datum) 0); /* * Initialize the autovacuum subsystem (again, no process start yet) @@ -4051,12 +4055,14 @@ PostmasterStateMachine(void) ereport(LOG, (errmsg("all server processes terminated; reinitializing"))); - /* remove leftover temporary files after a crash */ + /* + * Remove leftover temporary files after a crash. + * + * Note that this just stages the pgsql_tmp directories for deletion. + * The custodian process is responsible for actually removing the files. + */ if (remove_temp_files_after_crash) - { StagePgTempFilesForRemoval(); - RemovePgTempFiles(); - } /* allow background workers to immediately restart */ ResetBackgroundWorkerCrashTimes(); @@ -4068,6 +4074,14 @@ PostmasterStateMachine(void) reset_shared(); + /* + * Now that shared memory is initialized, notify the custodian to clean + * up the staged pgsql_tmp directories. We do this even if + * remove_temp_files_after_crash is false so that any previously staged + * directories are eventually cleaned up. + */ + RequestCustodian(CUSTODIAN_REMOVE_TEMP_FILES, false, (Datum) 0); + StartupPID = StartupDataBase(); Assert(StartupPID != 0); StartupStatus = STARTUP_RUNNING; diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c index 02c48a668b..2f93f71d44 100644 --- a/src/backend/storage/file/fd.c +++ b/src/backend/storage/file/fd.c @@ -99,6 +99,7 @@ #include "pgstat.h" #include "port/pg_iovec.h" #include "portability/mem.h" +#include "postmaster/custodian.h" #include "postmaster/startup.h" #include "storage/fd.h" #include "storage/ipc.h" @@ -1579,9 +1580,9 @@ PathNameOpenFilePerm(const char *fileName, int fileFlags, mode_t fileMode) * * Directories created within the top-level temporary directory should begin * with PG_TEMP_FILE_PREFIX, so that they can be identified as temporary and - * deleted at startup by RemovePgTempFiles(). Further subdirectories below - * that do not need any particular prefix. -*/ + * deleted by RemovePgTempFiles(). Further subdirectories below that do not + * need any particular prefix. + */ void PathNameCreateTemporaryDir(const char *basedir, const char *directory) { @@ -1779,9 +1780,9 @@ OpenTemporaryFileInTablespace(Oid tblspcOid, bool rejectError) * * If the file is inside the top-level temporary directory, its name should * begin with PG_TEMP_FILE_PREFIX so that it can be identified as temporary - * and deleted at startup by RemovePgTempFiles(). Alternatively, it can be - * inside a directory created with PathNameCreateTemporaryDir(), in which case - * the prefix isn't needed. + * and deleted by RemovePgTempFiles(). Alternatively, it can be inside a + * directory created with PathNameCreateTemporaryDir(), in which case the prefix + * isn't needed. */ File PathNameCreateTemporaryFile(const char *path, bool error_on_failure) diff --git a/src/include/postmaster/custodian.h b/src/include/postmaster/custodian.h index 170ca61a21..80890ceadd 100644 --- a/src/include/postmaster/custodian.h +++ b/src/include/postmaster/custodian.h @@ -18,7 +18,7 @@ */ typedef enum CustodianTask { - FAKE_TASK, /* placeholder until we have a real task */ + CUSTODIAN_REMOVE_TEMP_FILES, NUM_CUSTODIAN_TASKS, /* new tasks go above */ INVALID_CUSTODIAN_TASK -- 2.25.1