From a99fd6a737cec24bb4063e99a241ff3e04c6ebb8 Mon Sep 17 00:00:00 2001 From: Tomas Vondra Date: Thu, 20 Oct 2022 19:55:23 +0200 Subject: [PATCH 1/9] fixup: brin has_nulls --- src/backend/access/brin/brin_bloom.c | 1 + src/backend/access/brin/brin_inclusion.c | 1 + src/backend/access/brin/brin_minmax.c | 1 + src/backend/access/brin/brin_minmax_multi.c | 1 + 4 files changed, 4 insertions(+) diff --git a/src/backend/access/brin/brin_bloom.c b/src/backend/access/brin/brin_bloom.c index 6b0af7267d5..60315450b41 100644 --- a/src/backend/access/brin/brin_bloom.c +++ b/src/backend/access/brin/brin_bloom.c @@ -539,6 +539,7 @@ brin_bloom_add_value(PG_FUNCTION_ARGS) BloomGetFalsePositiveRate(opts)); column->bv_values[0] = PointerGetDatum(filter); column->bv_allnulls = false; + column->bv_hasnulls = true; updated = true; } else diff --git a/src/backend/access/brin/brin_inclusion.c b/src/backend/access/brin/brin_inclusion.c index 4b02d374f23..e0f44d3e62c 100644 --- a/src/backend/access/brin/brin_inclusion.c +++ b/src/backend/access/brin/brin_inclusion.c @@ -164,6 +164,7 @@ brin_inclusion_add_value(PG_FUNCTION_ARGS) column->bv_values[INCLUSION_UNMERGEABLE] = BoolGetDatum(false); column->bv_values[INCLUSION_CONTAINS_EMPTY] = BoolGetDatum(false); column->bv_allnulls = false; + column->bv_hasnulls = true; new = true; } diff --git a/src/backend/access/brin/brin_minmax.c b/src/backend/access/brin/brin_minmax.c index 9e8a8e056cc..8a5661a8952 100644 --- a/src/backend/access/brin/brin_minmax.c +++ b/src/backend/access/brin/brin_minmax.c @@ -90,6 +90,7 @@ brin_minmax_add_value(PG_FUNCTION_ARGS) column->bv_values[0] = datumCopy(newval, attr->attbyval, attr->attlen); column->bv_values[1] = datumCopy(newval, attr->attbyval, attr->attlen); column->bv_allnulls = false; + column->bv_hasnulls = true; PG_RETURN_BOOL(true); } diff --git a/src/backend/access/brin/brin_minmax_multi.c b/src/backend/access/brin/brin_minmax_multi.c index 9a0bcf6698d..4e7119e2d78 100644 --- a/src/backend/access/brin/brin_minmax_multi.c +++ b/src/backend/access/brin/brin_minmax_multi.c @@ -2500,6 +2500,7 @@ brin_minmax_multi_add_value(PG_FUNCTION_ARGS) MemoryContextSwitchTo(oldctx); column->bv_allnulls = false; + column->bv_hasnulls = true; modified = true; column->bv_mem_value = PointerGetDatum(ranges); -- 2.37.3