From 9cd579d6a20aef2aeeab6ef50d72e779d75bf7cd Mon Sep 17 00:00:00 2001 From: Melanie Plageman Date: Sat, 30 Dec 2023 16:18:40 -0500 Subject: [PATCH v2 1/6] lazy_scan_skip remove unnecessary local var rel_pages lazy_scan_skip() only uses vacrel->rel_pages twice, so there seems to be no reason to save it in a local variable, rel_pages. --- src/backend/access/heap/vacuumlazy.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.c index 3b9299b8924..c4e0c077694 100644 --- a/src/backend/access/heap/vacuumlazy.c +++ b/src/backend/access/heap/vacuumlazy.c @@ -1302,13 +1302,12 @@ static BlockNumber lazy_scan_skip(LVRelState *vacrel, Buffer *vmbuffer, BlockNumber next_block, bool *next_unskippable_allvis, bool *skipping_current_range) { - BlockNumber rel_pages = vacrel->rel_pages, - next_unskippable_block = next_block, + BlockNumber next_unskippable_block = next_block, nskippable_blocks = 0; bool skipsallvis = false; *next_unskippable_allvis = true; - while (next_unskippable_block < rel_pages) + while (next_unskippable_block < vacrel->rel_pages) { uint8 mapbits = visibilitymap_get_status(vacrel->rel, next_unskippable_block, @@ -1331,7 +1330,7 @@ lazy_scan_skip(LVRelState *vacrel, Buffer *vmbuffer, BlockNumber next_block, * * Implement this by always treating the last block as unsafe to skip. */ - if (next_unskippable_block == rel_pages - 1) + if (next_unskippable_block == vacrel->rel_pages - 1) break; /* DISABLE_PAGE_SKIPPING makes all skipping unsafe */ -- 2.37.2