From eeb24acd782f1dc2afff80fccfcec442521b9622 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Villemain?= Date: Wed, 3 Jan 2024 19:03:22 +0100 Subject: [PATCH 1/3] Check last block greater or equal to first block in pg_prewarm This prevents useless call and inform users of unexpected value as parameter. --- contrib/pg_prewarm/pg_prewarm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/contrib/pg_prewarm/pg_prewarm.c b/contrib/pg_prewarm/pg_prewarm.c index 01fc2c8ad9..1de1b39482 100644 --- a/contrib/pg_prewarm/pg_prewarm.c +++ b/contrib/pg_prewarm/pg_prewarm.c @@ -133,10 +133,11 @@ pg_prewarm(PG_FUNCTION_ARGS) else { last_block = PG_GETARG_INT64(4); - if (last_block < 0 || last_block >= nblocks) + if (last_block < first_block || last_block >= nblocks) ereport(ERROR, (errcode(ERRCODE_INVALID_PARAMETER_VALUE), - errmsg("ending block number must be between 0 and %lld", + errmsg("ending block number must be between %lld and %lld", + (long long) (first_block), (long long) (nblocks - 1)))); } -- 2.39.2