From f562dd8b80bd0b7c2d66ee9633434a1e5be82e04 Mon Sep 17 00:00:00 2001 From: "yizhi.fzh" Date: Wed, 7 Feb 2024 07:00:33 +0800 Subject: [PATCH v1 1/1] Remove the unnecessary checks for pathkey routines both pathkeys_count_contained_in and foreach can handle the NIL input, so no need the extra checks. --- src/backend/optimizer/path/pathkeys.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/backend/optimizer/path/pathkeys.c b/src/backend/optimizer/path/pathkeys.c index 82ff31273b..98334e5c52 100644 --- a/src/backend/optimizer/path/pathkeys.c +++ b/src/backend/optimizer/path/pathkeys.c @@ -2126,12 +2126,6 @@ pathkeys_useful_for_ordering(PlannerInfo *root, List *pathkeys) { int n_common_pathkeys; - if (root->query_pathkeys == NIL) - return 0; /* no special ordering requested */ - - if (pathkeys == NIL) - return 0; /* unordered path */ - (void) pathkeys_count_contained_in(root->query_pathkeys, pathkeys, &n_common_pathkeys); @@ -2167,10 +2161,6 @@ pathkeys_useful_for_grouping(PlannerInfo *root, List *pathkeys) if (root->group_pathkeys == NIL) return 0; - /* unordered path */ - if (pathkeys == NIL) - return 0; - /* walk the pathkeys and search for matching group key */ foreach(key, pathkeys) { -- 2.34.1