From eef8fb5d5a567a1731d8eb6ae24f32a9a0879028 Mon Sep 17 00:00:00 2001 From: Laurenz Albe Date: Sat, 17 Feb 2024 17:12:40 +0100 Subject: [PATCH v1 1/3] Speed up binary COPY TO Performance analysis shows that a lot of time is spent in pq_begintypsend, so speeding that up will boost the performance of binary COPY TO considerably. Invent a new macro to initialize a StringInfo and fill the first four bytes with zeros. This macro is only used in pq_begintypsend, but we had better keep implementation details of StringInfo in stringinfo.h. --- src/backend/libpq/pqformat.c | 6 +----- src/include/lib/stringinfo.h | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/src/backend/libpq/pqformat.c b/src/backend/libpq/pqformat.c index a697ccfbbf..255dd4e5e3 100644 --- a/src/backend/libpq/pqformat.c +++ b/src/backend/libpq/pqformat.c @@ -328,12 +328,8 @@ pq_endmessage_reuse(StringInfo buf) void pq_begintypsend(StringInfo buf) { - initStringInfo(buf); /* Reserve four bytes for the bytea length word */ - appendStringInfoCharMacro(buf, '\0'); - appendStringInfoCharMacro(buf, '\0'); - appendStringInfoCharMacro(buf, '\0'); - appendStringInfoCharMacro(buf, '\0'); + initStringInfoWith4Zeros(buf); } /* -------------------------------- diff --git a/src/include/lib/stringinfo.h b/src/include/lib/stringinfo.h index 2cd636b01c..db38b6d3f7 100644 --- a/src/include/lib/stringinfo.h +++ b/src/include/lib/stringinfo.h @@ -112,6 +112,20 @@ extern StringInfo makeStringInfo(void); */ extern void initStringInfo(StringInfo str); +/*------------------------ + * initStringInfoWith4Zeros + * As above, but append four zero bytes. + */ +#define initStringInfoWith4Zeros(str) \ + { \ + initStringInfo(str); \ + (str)->data[0] = '\0'; \ + (str)->data[1] = '\0'; \ + (str)->data[2] = '\0'; \ + (str)->data[3] = '\0'; \ + (str)->len = 4; \ + } + /*------------------------ * initReadOnlyStringInfo * Initialize a StringInfoData struct from an existing string without copying -- 2.43.2