From a0be4ee7698ff03d6c22398f20fd2c7efadbff45 Mon Sep 17 00:00:00 2001 From: Antonin Houska Date: Mon, 29 Apr 2024 07:53:00 +0200 Subject: [PATCH 1/2] Undo comment changes. These belong to the following patch. --- src/test/regress/expected/join.out | 11 +++++------ src/test/regress/sql/join.sql | 13 ++++++------- 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/src/test/regress/expected/join.out b/src/test/regress/expected/join.out index 571198a86a..fa407d37f5 100644 --- a/src/test/regress/expected/join.out +++ b/src/test/regress/expected/join.out @@ -5648,12 +5648,11 @@ select d.* from d left join (select distinct * from b) s Seq Scan on d (1 row) --- when the GROUP BY contains a column that is not in the join condition, join --- removal takes place too, due to "unique keys" (Note: as of 9.6, we notice --- that b.id is a primary key and so drop b.c_id from the GROUP BY of the --- resulting plan; but this happens too late for join removal in the outer --- plan level.) -explain (costs off, verbose on) +-- join removal is not possible when the GROUP BY contains a column that is +-- not in the join condition. (Note: as of 9.6, we notice that b.id is a +-- primary key and so drop b.c_id from the GROUP BY of the resulting plan; +-- but this happens too late for join removal in the outer plan level.) +explain (costs off) select d.* from d left join (select * from b group by b.id, b.c_id) s on d.a = s.id; QUERY PLAN diff --git a/src/test/regress/sql/join.sql b/src/test/regress/sql/join.sql index bf8fb27072..c4c6c7b8ba 100644 --- a/src/test/regress/sql/join.sql +++ b/src/test/regress/sql/join.sql @@ -2047,17 +2047,16 @@ explain (costs off) select d.* from d left join (select distinct * from b) s on d.a = s.id and d.b = s.c_id; --- when the GROUP BY contains a column that is not in the join condition, join --- removal takes place too, due to "unique keys" (Note: as of 9.6, we notice --- that b.id is a primary key and so drop b.c_id from the GROUP BY of the --- resulting plan; but this happens too late for join removal in the outer --- plan level.) -explain (costs off, verbose on) +-- join removal is not possible when the GROUP BY contains a column that is +-- not in the join condition. (Note: as of 9.6, we notice that b.id is a +-- primary key and so drop b.c_id from the GROUP BY of the resulting plan; +-- but this happens too late for join removal in the outer plan level.) +explain (costs off) select d.* from d left join (select * from b group by b.id, b.c_id) s on d.a = s.id; -- similarly, but keying off a DISTINCT clause -explain (costs off, verbose on) +explain (costs off) select d.* from d left join (select distinct * from b) s on d.a = s.id; -- 2.44.0