Extensions support for pg_dump, patch v27
Hi,
Following recent commit of the hstore Makefile cleaning, that I included
into my extension patch too, I have a nice occasion to push version 27
of the patch. Please find it enclosed. This time I'm not including the
contrib-only and doc-src split versions, just ask for them if that's
what you need.
Of course you can also use my git repository:
http://git.postgresql.org/gitweb?p=postgresql-extension.git;a=shortlog;h=refs/heads/extension
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
Attachments:
On Mon, Jan 24, 2011 at 18:22, Dimitri Fontaine <dimitri@2ndquadrant.fr> wrote:
Following recent commit of the hstore Makefile cleaning, that I included
into my extension patch too, I have a nice occasion to push version 27
of the patch. Please find it enclosed.
Hi, I read the patch and test it in some degree. It works as expected
generally, but still needs a bit more development in edge case.
* commands/extension.h needs cleanup.
- Missing "extern" declarations for create_extension and
create_extension_with_user_data variables.
- ExtensionControlFile and ExtensionList can be hidden from the header.
- extension_objects_fctx is not used at all.
* There are many recordDependencyOn(&myself, &CreateExtensionAddress, ...)
in some places, but I'm not sure we forget something -- TRIGGERs?
* Will we still need uninstaller scripts?
DROP EXTENSION depends on object dependency to drop objects,
but we have a few configurations that cannot be described in the
dependency. For example, rows inserted into pg_am for user AMs
or reverting default settings modified by the extension.
* Extensions installed in pg_catalog:
If we install an extension into pg_catalog,
CREATE EXTENSION xxx WITH SCHEMA pg_catalog
pg_dump dumps nothing about the extension. We might need special care
for modules that install functions only in pg_catalog.
* I can install all extensions successfully, but there is a warning
in hstore. The warning was not reported to the client, but the whole
contents of hstore.sql.in was recorded in the server log.
WARNING: => is deprecated as an operator name
We sets client_min_messages for the issue in hstore.sql.in, but I think
we also need an additional "SET log_min_messages TO ERROR" around it.
* Is it support nested CREATE EXTENSION calls?
It's rare case, but we'd have some error checks for it.
* It passes all regression test for both backend and contrib modules,
but there are a couple of warnings during build and installation.
Three compiler warnings found. Please check.
pg_proc.c: In function 'ProcedureCreate':
pg_proc.c:110:8: warning: 'extensionOid' may be used uninitialized in
this function
pg_shdepend.c: In function 'shdepReassignOwned':
pg_shdepend.c:1335:6: warning: implicit declaration of function
'AlterOperatorOwner_oid'
operatorcmds.c:369:1: warning: no previous prototype for
'AlterOperatorOwner_oid'
* Five warnings also found during make install in contrib directory.
../../config/install-sh: ./uninstall_btree_gist.sql does not exist.
../../config/install-sh: ./uninstall_pageinspect.sql does not exist.
../../config/install-sh: ./uninstall_pgcrypto.sql does not exist.
../../config/install-sh: ./uninstall_pgrowlocks.sql does not exist.
../../config/install-sh: ./uninstall_pgstattuple.sql does not exist.
* You use "const = expr" in some places, ex. if( InvalidOid != ...),
but we seem to prefer "expr = const".
* [off topic] I found some installer scripts are inconsistent.
They uses CREATE FUNCTION for some of functions, but CREATE OR REPLACE
FUNCTION for others. We'd better write documentation about how to write
installer scripts because CREATE EXTENSION has some implicit assumptions
in them. For example, "Don't use transaction", etc.
--
Itagaki Takahiro
Hi,
Itagaki Takahiro <itagaki.takahiro@gmail.com> writes:
Hi, I read the patch and test it in some degree. It works as expected
generally, but still needs a bit more development in edge case.
Thanks for the review!
* commands/extension.h needs cleanup.
- Missing "extern" declarations for create_extension and
create_extension_with_user_data variables.
- ExtensionControlFile and ExtensionList can be hidden from the header.
- extension_objects_fctx is not used at all.
Fixed in git. I'm not yet used to the project style where we declare
some structures into the c code rather than the headers… and then it's
cleanup.
* There are many recordDependencyOn(&myself, &CreateExtensionAddress, ...)
in some places, but I'm not sure we forget something -- TRIGGERs?
I think we're good here. The extensions I know that use triggers are
installing the functions, it's still the user who CREATE TRIGGER and
uses the function. And even if we have an extension that contains some
CREATE TRIGGER commands in its script, the trigger will depend on a
function and the function on the extension.
If there's a use case for CREATE TRIGGER in an extension's script and
having the trigger not depend on another extension's object, like a
function, then I didn't see it. I'm ok to add the triggers as first
class dependency objects in the extension patch if there's a need…
* Will we still need uninstaller scripts?
DROP EXTENSION depends on object dependency to drop objects,
but we have a few configurations that cannot be described in the
dependency. For example, rows inserted into pg_am for user AMs
or reverting default settings modified by the extension.
Well I'm unconvinced by index AM extensions. Unfortunately, if you want
a crash safe AM, you need to patch core code, it's not an extension any
more. About reverting default settings, I'm not following.
What I saw is existing extensions that didn't need uninstall script once
you can DROP EXTENSION foo; but of course it would be quite easy to add
a parameter for that in the control file. Do we need it, though?
* Extensions installed in pg_catalog:
If we install an extension into pg_catalog,
CREATE EXTENSION xxx WITH SCHEMA pg_catalog
pg_dump dumps nothing about the extension. We might need special care
for modules that install functions only in pg_catalog.
I didn't spot that, I just didn't think about that use case. On a quick
test here it seems like the dependency is not recorded in this
case. Will fix.
* I can install all extensions successfully, but there is a warning
in hstore. The warning was not reported to the client, but the whole
contents of hstore.sql.in was recorded in the server log.WARNING: => is deprecated as an operator name
We sets client_min_messages for the issue in hstore.sql.in, but I think
we also need an additional "SET log_min_messages TO ERROR" around it.
We can do that, but what's happening now is my understanding of the
consensus we reached on the list.
* Is it support nested CREATE EXTENSION calls?
It's rare case, but we'd have some error checks for it.
In fact earthdistance could CREATE EXTENSION cube; itself in its install
script. As you say, though, it's a rare case and it was agreed that
this feature could wait until a later version, so I didn't spend time on
it.
* It passes all regression test for both backend and contrib modules,
but there are a couple of warnings during build and installation.Three compiler warnings found. Please check.
pg_proc.c: In function 'ProcedureCreate':
pg_proc.c:110:8: warning: 'extensionOid' may be used uninitialized in
this function
pg_shdepend.c: In function 'shdepReassignOwned':
pg_shdepend.c:1335:6: warning: implicit declaration of function
'AlterOperatorOwner_oid'
operatorcmds.c:369:1: warning: no previous prototype for
'AlterOperatorOwner_oid'
Oops sorry about that, I miss them too easily. What's the trick to turn
warnings into errors already please?
Fixed in the git repository.
* Five warnings also found during make install in contrib directory.
../../config/install-sh: ./uninstall_btree_gist.sql does not exist.
../../config/install-sh: ./uninstall_pageinspect.sql does not exist.
../../config/install-sh: ./uninstall_pgcrypto.sql does not exist.
../../config/install-sh: ./uninstall_pgrowlocks.sql does not exist.
../../config/install-sh: ./uninstall_pgstattuple.sql does not exist.
That's the DATA = uninstall_ lines in the Makefile. Removed in the git
repository. Cleared.
* You use "const = expr" in some places, ex. if( InvalidOid != ...),
but we seem to prefer "expr = const".
It allows to get a compiler error when you mistakenly use = rather than
== because the Left Hand Side is a constant, so I got used to writing
things this way. Should I review my patch and adapt? Will do after
some votes :)
* [off topic] I found some installer scripts are inconsistent.
They uses CREATE FUNCTION for some of functions, but CREATE OR REPLACE
FUNCTION for others. We'd better write documentation about how to write
installer scripts because CREATE EXTENSION has some implicit assumptions
in them. For example, "Don't use transaction", etc.
Will add some more documentation, ok. As far as contrib goes, I didn't
rework the install scripts.
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
Itagaki Takahiro <itagaki.takahiro@gmail.com> writes:
* Extensions installed in pg_catalog:
If we install an extension into pg_catalog,
CREATE EXTENSION xxx WITH SCHEMA pg_catalog
pg_dump dumps nothing about the extension. We might need special care
for modules that install functions only in pg_catalog.
In src/backend/catalog/pg_depend.c we find the code for
recordDependencyOn() which is in fact in recordMultipleDependencies(),
and sayth so:
/*
* If the referenced object is pinned by the system, there's no real
* need to record dependencies on it. This saves lots of space in
* pg_depend, so it's worth the time taken to check.
*/
So I'm not sure about what we can do here other than error on using
pg_catalog in CREATE EXTENSION? How do we want to manage adminpack?
Other than adminpack, I think it makes sense to say that extensions are
not going into pg_catalog…
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
On Tue, Jan 25, 2011 at 04:23:41PM +0100, Dimitri Fontaine wrote:
Itagaki Takahiro <itagaki.takahiro@gmail.com> writes:
* Extensions installed in pg_catalog:
If we install an extension into pg_catalog,
CREATE EXTENSION xxx WITH SCHEMA pg_catalog
pg_dump dumps nothing about the extension. We might need special care
for modules that install functions only in pg_catalog.In src/backend/catalog/pg_depend.c we find the code for
recordDependencyOn() which is in fact in recordMultipleDependencies(),
and sayth so:/*
* If the referenced object is pinned by the system, there's no real
* need to record dependencies on it. This saves lots of space in
* pg_depend, so it's worth the time taken to check.
*/So I'm not sure about what we can do here other than error on using
pg_catalog in CREATE EXTENSION? How do we want to manage adminpack?Other than adminpack, I think it makes sense to say that extensions
are not going into pg_catalog…
Given this, we should maybe see about either making adminpack part of
PostgreSQL's core distribution (probably a good idea) or moving it out
of pg_catalog so we don't have an exception to the rule.
Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
On Jan 25, 2011, at 7:27 AM, David Fetter wrote:
Other than adminpack, I think it makes sense to say that extensions
are not going into pg_catalog…Given this, we should maybe see about either making adminpack part of
PostgreSQL's core distribution (probably a good idea) or moving it out
of pg_catalog so we don't have an exception to the rule.
+1
David
On Wed, Jan 26, 2011 at 02:57, David E. Wheeler <david@kineticode.com> wrote:
Other than adminpack, I think it makes sense to say that extensions
are not going into pg_catalog…Given this, we should maybe see about either making adminpack part of
PostgreSQL's core distribution (probably a good idea) or moving it out
of pg_catalog so we don't have an exception to the rule.+1
I doubt it can solve the real problem.
It is my understanding that we install them in pg_catalog because
they are designed to be installed in template1 for pgAdmin, right?
We have a problem in pg_dump when we install extension modules in
template1. If we create a database, installed functions are copied
from template1. However, they are also dumped with pg_dump unless
they are in pg_catalog. So, we encounter "function already exists"
errors when pg_restore.
Since pg_dump won't dump user objects in pg_catalog, adminpack can
avoid the above errors by installing functions in pg_catalog.
CREATE EXTENSION might have the same issue -- Can EXTENSION work
without errors when we install extensions in template databases?
To avoid errors, pg_dump might need to dump extensions as
"CREATE OR REPLACE EXTENSION" or "CREATE EXTENSION IF NOT EXISTS"
rather than "CREATE EXTENSION".
--
Itagaki Takahiro
Itagaki Takahiro <itagaki.takahiro@gmail.com> writes:
Since pg_dump won't dump user objects in pg_catalog, adminpack can
avoid the above errors by installing functions in pg_catalog.
CREATE EXTENSION might have the same issue -- Can EXTENSION work
without errors when we install extensions in template databases?
Well in fact the reason why pg_dump will not dump the extension when
it's installed in pg_catalog is that the pg_depend entry is not
recorded, and the SQL query pg_dump uses gets its data from pg_extension
JOIN pg_depend JOIN pg_namespace.
The missing entry in pg_depend is the reason why the extension is not
part of the dump. We could fix that using a LEFT JOIN here and COALESCE
to force the namespace as pg_catalog. Is that not a kludge? If
acceptable, I will do that next.
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
Dimitri Fontaine <dimitri@2ndQuadrant.fr> writes:
The missing entry in pg_depend is the reason why the extension is not
part of the dump. We could fix that using a LEFT JOIN here and COALESCE
to force the namespace as pg_catalog. Is that not a kludge?
Yes, it is. Why is the pg_depend entry missing?
regards, tom lane
Tom Lane <tgl@sss.pgh.pa.us> writes:
Dimitri Fontaine <dimitri@2ndQuadrant.fr> writes:
The missing entry in pg_depend is the reason why the extension is not
part of the dump. We could fix that using a LEFT JOIN here and COALESCE
to force the namespace as pg_catalog. Is that not a kludge?Yes, it is. Why is the pg_depend entry missing?
See src/backend/catalog/pg_depend.c
/*
* If the referenced object is pinned by the system, there's no real
* need to record dependencies on it. This saves lots of space in
* pg_depend, so it's worth the time taken to check.
*/
Certainly, pg_catalog is pinned.
select *
from pg_depend
where refobjid = (select oid
from pg_namespace
where nspname = 'pg_catalog')
and refclassid = 'pg_namespace'::regclass;
classid | objid | objsubid | refclassid | refobjid | refobjsubid | deptype
---------+-------+----------+------------+----------+-------------+---------
0 | 0 | 0 | 2615 | 11 | 0 | p
(1 row)
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
Dimitri Fontaine <dimitri@2ndQuadrant.fr> writes:
Tom Lane <tgl@sss.pgh.pa.us> writes:
Dimitri Fontaine <dimitri@2ndQuadrant.fr> writes:
The missing entry in pg_depend is the reason why the extension is not
part of the dump. We could fix that using a LEFT JOIN here and COALESCE
to force the namespace as pg_catalog. Is that not a kludge?
Yes, it is. Why is the pg_depend entry missing?
See src/backend/catalog/pg_depend.c
Certainly, pg_catalog is pinned.
OK, so I guess I'm missing why the extension code is looking for stuff
dependent on the pg_catalog schema. That schema certainly doesn't
belong to any extension.
In any case, your proposed hack above is effectively assuming that
there's only one pinned schema, which is untrue now and is likely to
become even less true in the future. So I don't think we can go that way.
regards, tom lane
Tom Lane <tgl@sss.pgh.pa.us> writes:
OK, so I guess I'm missing why the extension code is looking for stuff
dependent on the pg_catalog schema. That schema certainly doesn't
belong to any extension.
Exactly. We're on the same page here, full agreement. So the extension
patch is not considering pg_catalog in any special way here, and the
problem comes from contrib/adminpack which installs its functions into
pg_catalog, yet is not part of core.
So in his tests, Itagaki was tempted to issue the following statement:
CREATE EXTENSION adminpack WITH SCHEMA pg_catalog;
That's supposed to register a dependency from the extension to its
declared hosting schema (adminpack is not relocatable so that entirely
depends on its script — which forces pg_catalog).
Then you get the same problems as with any other object that lives into
this schema, pg_dump will avoid dumping its definition…
In any case, your proposed hack above is effectively assuming that
there's only one pinned schema, which is untrue now and is likely to
become even less true in the future. So I don't think we can go that way.
Well I proposed is nothing more than a crock. What I'd like us to do
instead is ERRORing out when you want to use pg_catalog for an
extension.
We could use get_extension_namespace() just after recoding the
dependency and error out if we don't find the arguments we gave to
recordDependencyOn() so that we're not duplicating code. That will
cover any pinned schema. I'm preparing a patch to do that.
What do we want to do with adminpack? Including its functions into
core, or have it use another schema? I don't think an extension
installing its objects into pg_catalog is that good an idea…
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
Dimitri Fontaine <dimitri@2ndQuadrant.fr> writes:
So in his tests, Itagaki was tempted to issue the following statement:
CREATE EXTENSION adminpack WITH SCHEMA pg_catalog;
That's supposed to register a dependency from the extension to its
declared hosting schema (adminpack is not relocatable so that entirely
depends on its script - which forces pg_catalog).
Then you get the same problems as with any other object that lives into
this schema, pg_dump will avoid dumping its definition ...
Mph. Although such an extension should certainly carry a dependency on
the schema it's using, I'm not sure that it makes sense to consider that
the extension (as opposed to its contained objects) belongs to the
schema. If we think that extensions live inside schemas then it's
logically difficult for an extension to own objects scattered across
multiple schemas, which is surely a restriction we do not want. So I'd
have expected that extensions use unqualified names, like languages or
tablespaces. That being the case, there is no reason why pg_dump ought
to be making any such test.
There are places where pg_dump refuses to dump objects contained in
pg_catalog on the grounds that they're system objects, but that
heuristic ought not apply to extensions IMO, even if you don't agree
with the conclusion of the preceding paragraph. Any extension is, by
definition, not built-in.
Well I proposed is nothing more than a crock. What I'd like us to do
instead is ERRORing out when you want to use pg_catalog for an
extension.
Right offhand I'm not seeing the need for such a restriction, though
certainly I'd not cry a lot if we had to impose it. ISTM what we've got
here is some bogus what-to-dump rules in pg_dump. Extensions should
always be dumped.
What do we want to do with adminpack? Including its functions into
core, or have it use another schema? I don't think an extension
installing its objects into pg_catalog is that good an idea
I'm trying to avoid having an opinion on that. The reasons for it might
or might not be very good, but I'd rather that the extension mechanism
didn't break the ability for people to make such decisions.
regards, tom lane
Dimitri Fontaine <dimitri@2ndQuadrant.fr> writes:
We could use get_extension_namespace() just after recoding the
dependency and error out if we don't find the arguments we gave to
recordDependencyOn() so that we're not duplicating code. That will
cover any pinned schema. I'm preparing a patch to do that.
Kids are falling asleep and the patch there:
What do we want to do with adminpack? Including its functions into
core, or have it use another schema? I don't think an extension
installing its objects into pg_catalog is that good an idea…
As we're still waiting on some decision here, and some others in
previous mails of this same thread, I'm waiting some more before to
produce the next patch in the series. See
http://archives.postgresql.org/pgsql-hackers/2011-01/msg02385.php
http://archives.postgresql.org/pgsql-hackers/2011-01/msg02392.php
Of course the git repository is uptodate should you want to try the
newest code without waiting on me for the next patch release.
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
Tom Lane <tgl@sss.pgh.pa.us> writes:
Mph. Although such an extension should certainly carry a dependency on
the schema it's using, I'm not sure that it makes sense to consider that
the extension (as opposed to its contained objects) belongs to the
schema. If we think that extensions live inside schemas then it's
logically difficult for an extension to own objects scattered across
multiple schemas, which is surely a restriction we do not want. So I'd
have expected that extensions use unqualified names, like languages or
tablespaces. That being the case, there is no reason why pg_dump ought
to be making any such test.
Well yes, extension are not living in a schema, we just offer users a
way to influence the script as far as where the extension's objects are
to be found and register a dependency so that it's easy to remember what
the users asked. So that for example we are able to act the same way on
pg_restore.
Now, pg_dump makes no such test already, but a query is using a JOIN to
list extensions and their target schema, where it's possible that the
target has not been recorded by recordDependencyOn(): in this case the
whole extension's is filtered out of the resultset. Quick and dirty
fix, I proposed to LEFT JOIN in the pg_dump query…
There are places where pg_dump refuses to dump objects contained in
pg_catalog on the grounds that they're system objects, but that
heuristic ought not apply to extensions IMO, even if you don't agree
with the conclusion of the preceding paragraph. Any extension is, by
definition, not built-in.
Agreed. The problem we're having here is how to implement all that yet
fully support adminpack. The design we're talking about is the same.
Well I proposed is nothing more than a crock. What I'd like us to do
instead is ERRORing out when you want to use pg_catalog for an
extension.Right offhand I'm not seeing the need for such a restriction, though
certainly I'd not cry a lot if we had to impose it. ISTM what we've got
here is some bogus what-to-dump rules in pg_dump. Extensions should
always be dumped.
Agreed. Trying to solve an implementation detail, and that's the easier
way to prevent users from shooting themselves in the foot here.
What do we want to do with adminpack? Including its functions into
core, or have it use another schema? I don't think an extension
installing its objects into pg_catalog is that good an ideaI'm trying to avoid having an opinion on that. The reasons for it might
or might not be very good, but I'd rather that the extension mechanism
didn't break the ability for people to make such decisions.
You still can do one of the following commands, where you're not having
a say on the real schema that adminpack will use because it's not
relocatable and not paying attention to @extschema@, but apart from this
lie everything will just work. I'd be happy to ship with such a lie,
but I can see why people want something different.
CREATE EXTENSION adminpack;
CREATE EXTENSION adminpack WITH SCHEMA utils;
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
Dimitri Fontaine <dimitri@2ndQuadrant.fr> writes:
Tom Lane <tgl@sss.pgh.pa.us> writes:
Mph. Although such an extension should certainly carry a dependency on
the schema it's using, I'm not sure that it makes sense to consider that
the extension (as opposed to its contained objects) belongs to the
schema.
Well yes, extension are not living in a schema, we just offer users a
way to influence the script as far as where the extension's objects are
to be found and register a dependency so that it's easy to remember what
the users asked. So that for example we are able to act the same way on
pg_restore.
Oh: then you're doing it wrong. If you want to remember that WITH
SCHEMA was specified, you need to explicitly store that as another
column in pg_extension. You should not be depending on the dependency
mechanism to remember that for you, any more than we'd use pg_depend to
remember a table's relnamespace. The dependency mechanism is there
to figure out the consequences of a DROP command, it's not there to
remember arbitrary facts. (And yes, I know that we've cheated on that
principle a few times before; but you can't do it here.)
regards, tom lane
Tom Lane <tgl@sss.pgh.pa.us> writes:
Oh: then you're doing it wrong. If you want to remember that WITH
SCHEMA was specified, you need to explicitly store that as another
column in pg_extension. You should not be depending on the dependency
mechanism to remember that for you, any more than we'd use pg_depend to
remember a table's relnamespace. The dependency mechanism is there
to figure out the consequences of a DROP command, it's not there to
remember arbitrary facts. (And yes, I know that we've cheated on that
principle a few times before; but you can't do it here.)
The thinking is that we need to have the dependency registered too, so
that DROP SCHEMA will cascade to the extension. So while at it, I also
used the dependency for tracking the schema.
Even if I get to use a column to track the schema, I will have to
maintain registering the dependency. Should I do that?
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
Tom Lane <tgl@sss.pgh.pa.us> writes:
Oh: then you're doing it wrong. If you want to remember that WITH
SCHEMA was specified, you need to explicitly store that as another
column in pg_extension.
Ok, done. Of course, it solves the whole problem Itagaki had with
adminpack because we stop relying on dependencies to get it right now.
I've also added another parameter in the control file, named "schema".
It's only valid to use that when relocatable is false, and it allows to
force the schema where to install the extension. When this schema does
not already exists, it will be created for the user.
Of course the adminpack extension's control file now has relocatable =
false and schema = 'pg_catalog'.
~=# create extension lo;
CREATE EXTENSION
~=# create extension adminpack;
CREATE EXTENSION
~=# \dx
List of extensions
Schema | Name | Version | Description
------------+-----------+----------+-----------------------------------------
pg_catalog | adminpack | 9.1devel | Administrative functions for PostgreSQL
utils | lo | 9.1devel | managing Large Objects
(2 rows)
~=# drop extension adminpack;
DROP EXTENSION
~=# create extension adminpack with schema utils;
ERROR: this extension has to be installed in schema "pg_catalog"
~=# create extension adminpack with schema pg_catalog;
CREATE EXTENSION
~=# alter extension adminpack set schema utils;
ERROR: this extension does not support SET SCHEMA
The documentation is updated both in the patch and here:
http://pgsql.tapoueh.org/extensions/doc/html/extend-extension.html
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
Attachments:
On Thu, Jan 27, 2011 at 20:01, Dimitri Fontaine <dimitri@2ndquadrant.fr> wrote:
Ok, done. Of course, it solves the whole problem Itagaki had with
adminpack because we stop relying on dependencies to get it right now.
I found pg_restore with -c option fails when an extension is created
in pg_catalog. Since pg_catalog is an implicit search target, so we
might need the catalog to search_path explicitly.
Note that I can restore adminpack with not errors because it has
explicit "pg_catalog." prefix in the installer script.
----
postgres=# CREATE EXTENSION cube WITH SCHEMA pg_catalog;
$ pg_dump -Fc postgres > postgres.dump
$ pg_restore -d postgres -c postgres.dump
pg_restore: [archiver (db)] Error while PROCESSING TOC:
pg_restore: [archiver (db)] Error from TOC entry 1; 3996 16678 EXTENSION cube
pg_restore: [archiver (db)] could not execute query: ERROR: no schema
has been selected to create in
----
BTW, I have a minor comments for the code.
extern bool extension_relocatable_p(Oid ext_oid);
What is "_p" ? Also, we could make the function static
because it is used only in extension.c.
--
Itagaki Takahiro
Itagaki Takahiro <itagaki.takahiro@gmail.com> writes:
I found pg_restore with -c option fails when an extension is created
in pg_catalog. Since pg_catalog is an implicit search target, so we
might need the catalog to search_path explicitly.
Note that I can restore adminpack with not errors because it has
explicit "pg_catalog." prefix in the installer script.
Nice catch, thank you very much (again) for finding those :)
Please find inline the patch I've just applied that fixes the issue by
managing the current search path and creation namespace before executing
the script, the same way that schemacmds.c does.
BTW, I have a minor comments for the code.
extern bool extension_relocatable_p(Oid ext_oid);
What is "_p" ? Also, we could make the function static
because it is used only in extension.c.
predicate. Maybe I've done too much Emacs Lisp coding at the time I
added that function, but it looked natural (enough) to me :)
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
commit 5c14c989426c0811e5bf8b993ae9a966fbf903c4 (HEAD, refs/remotes/origin/extension, refs/heads/extension)
Author: Dimitri Fontaine <dim@tapoueh.org>
Date: Thu Jan 27 14:40:10 2011 +0100
Fully set the creation namespace before to execute the extenions's script.
Modified src/backend/commands/extension.c
diff --git a/src/backend/commands/extension.c b/src/backend/commands/extension.c
index 87310fb..4a8c757 100644
--- a/src/backend/commands/extension.c
+++ b/src/backend/commands/extension.c
@@ -415,6 +415,8 @@ execute_extension_script(ExtensionControlFile *control,
char *filename = get_extension_absolute_path(control->script);
char *old_cmsgs = NULL, *old_lmsgs = NULL; /* silence compiler */
bool reset_cmsgs = false, reset_lmsgs = false;
+ Oid target_schema;
+ OverrideSearchPath *overridePath;
/*
* Set create_extension and create_extension_with_user_data so that the
@@ -453,6 +455,21 @@ execute_extension_script(ExtensionControlFile *control,
SetConfigOption("log_min_messages", "warning", PGC_SUSET, PGC_S_SESSION);
}
+ if (control->relocatable)
+ target_schema = LookupCreationNamespace(schema);
+ else
+ target_schema = get_namespace_oid(schema, false);
+
+ /*
+ * Temporarily make the new namespace be the front of the search path, as
+ * well as the default creation target namespace. This will be undone at
+ * the end of this routine, or upon error.
+ */
+ overridePath = GetOverrideSearchPath(CurrentMemoryContext);
+ overridePath->schemas = lcons_oid(target_schema, overridePath->schemas);
+ /* XXX should we clear overridePath->useTemp? */
+ PushOverrideSearchPath(overridePath);
+
/*
* On failure, ensure that create_extension does not remain set.
*/
@@ -474,7 +491,8 @@ execute_extension_script(ExtensionControlFile *control,
if (control->relocatable)
{
List *search_path = fetch_search_path(false);
- Oid first_schema, target_schema;
+ Oid first_schema = linitial_oid(search_path);
+ list_free(search_path);
if (!execute_sql_string(sql))
ereport(ERROR,
@@ -495,10 +513,6 @@ execute_extension_script(ExtensionControlFile *control,
* We skip this step if the target schema happens to be the
* first schema of the current search_path.
*/
- first_schema = linitial_oid(search_path);
- target_schema = LookupCreationNamespace(schema);
- list_free(search_path);
-
if (first_schema != target_schema)
AlterExtensionNamespace_oid(CreateExtensionAddress.objectId,
target_schema);
@@ -531,6 +545,9 @@ execute_extension_script(ExtensionControlFile *control,
}
PG_END_TRY();
+ /* Reset search path to normal state */
+ PopOverrideSearchPath();
+
if (reset_cmsgs)
SetConfigOption("client_min_messages",
old_cmsgs, PGC_SUSET, PGC_S_SESSION);
On Thu, Jan 27, 2011 at 22:48, Dimitri Fontaine <dimitri@2ndquadrant.fr> wrote:
Itagaki Takahiro <itagaki.takahiro@gmail.com> writes:
I found pg_restore with -c option fails when an extension is created
in pg_catalog.Nice catch, thank you very much (again) for finding those :)
Seems good.
extern bool extension_relocatable_p(Oid ext_oid);
predicate. Maybe I've done too much Emacs Lisp coding at the time I
added that function, but it looked natural (enough) to me :)
Hmmm, I like extension_is_relocatable() or so...
Including the above, I wrote a patch on your patch for minor
cleanup. Please merge reasonable parts in it.
* access() is not portable.
The pre-checking with access() doesn't seems needed because
the same error will be raised in parse_extension_control_file().
* There are some dead code in the patch.
For example, you exported ObjectAddresses to public, but it is not
used in extension.c actually. I reverted some of changes.
* Should we support absolute control file paths?
Absolute paths are supported by get_extension_absolute_path(),
but I'm not sure actual use-cases.
* Each ereport(ERROR) should have a reasonable errcode unless
they are an internal logic error, and whether the error message
follows our guidline (starting with a lower case character, etc.)
* Changed create_extension_with_user_data to a static variable.
CreateExtensionAddress and create_extension are still exported.
We could have better names for them -- CurrentExtensionAddress
and in_create_extension? Or, in_create_extension might be
replaced with "CreateExtensionAddress.objectId != InvalidOid".
* Added psql tab completion for CREATE/DROP/ALTER EXTENSION.
* Use palloc0() instead of palloc() and memset(0).
* Several code cleanup.
--
Itagaki Takahiro
Attachments:
extension-diff-on.v28a.patchapplication/octet-stream; name=extension-diff-on.v28a.patchDownload
diff --git a/contrib/adminpack/adminpack.control b/contrib/adminpack/adminpack.control
index 5f4331d..79562b0 100644
*** a/contrib/adminpack/adminpack.control
--- b/contrib/adminpack/adminpack.control
***************
*** 2,5 ****
comment = 'Administrative functions for PostgreSQL'
version = '9.1devel'
relocatable = false
! schema = 'pg_catalog'
\ No newline at end of file
--- 2,5 ----
comment = 'Administrative functions for PostgreSQL'
version = '9.1devel'
relocatable = false
! schema = 'pg_catalog'
diff --git a/src/backend/catalog/dependency.c b/src/backend/catalog/dependency.c
index ec463d3..f4bb6db 100644
*** a/src/backend/catalog/dependency.c
--- b/src/backend/catalog/dependency.c
***************
*** 79,84 ****
--- 79,113 ----
#include "utils/tqual.h"
+ /*
+ * Deletion processing requires additional state for each ObjectAddress that
+ * it's planning to delete. For simplicity and code-sharing we make the
+ * ObjectAddresses code support arrays with or without this extra state.
+ */
+ typedef struct
+ {
+ int flags; /* bitmask, see bit definitions below */
+ ObjectAddress dependee; /* object whose deletion forced this one */
+ } ObjectAddressExtra;
+
+ /* ObjectAddressExtra flag bits */
+ #define DEPFLAG_ORIGINAL 0x0001 /* an original deletion target */
+ #define DEPFLAG_NORMAL 0x0002 /* reached via normal dependency */
+ #define DEPFLAG_AUTO 0x0004 /* reached via auto dependency */
+ #define DEPFLAG_INTERNAL 0x0008 /* reached via internal dependency */
+
+
+ /* expansible list of ObjectAddresses */
+ struct ObjectAddresses
+ {
+ ObjectAddress *refs; /* => palloc'd array */
+ ObjectAddressExtra *extras; /* => palloc'd array, or NULL if not used */
+ int numrefs; /* current number of references */
+ int maxrefs; /* current size of palloc'd array(s) */
+ };
+
+ /* typedef ObjectAddresses appears in dependency.h */
+
/* threaded list of ObjectAddresses, for recursion detection */
typedef struct ObjectAddressStack
{
*************** findDependentObjects(const ObjectAddress
*** 525,530 ****
--- 554,560 ----
/* no problem */
break;
case DEPENDENCY_INTERNAL:
+
/*
* This object is part of the internal implementation of
* another object. We have four cases:
diff --git a/src/backend/catalog/pg_depend.c b/src/backend/catalog/pg_depend.c
index 4be6490..1810a71 100644
*** a/src/backend/catalog/pg_depend.c
--- b/src/backend/catalog/pg_depend.c
*************** changeDependencyTypeFor(Oid objid,
*** 328,334 ****
return count;
}
-
/*
* isObjectPinned()
*
--- 328,333 ----
diff --git a/src/backend/catalog/pg_proc.c b/src/backend/catalog/pg_proc.c
index d7d99d2..40bc2cb 100644
*** a/src/backend/catalog/pg_proc.c
--- b/src/backend/catalog/pg_proc.c
*************** ProcedureCreate(const char *procedureNam
*** 626,632 ****
{
recordDependencyOn(&myself, &CreateExtensionAddress, DEPENDENCY_INTERNAL);
}
! else if(is_update && OidIsValid(extensionOid))
{
/* we have to recreate the dependency to the known extension */
ObjectAddress extension;
--- 626,632 ----
{
recordDependencyOn(&myself, &CreateExtensionAddress, DEPENDENCY_INTERNAL);
}
! else if (is_update && OidIsValid(extensionOid))
{
/* we have to recreate the dependency to the known extension */
ObjectAddress extension;
diff --git a/src/backend/commands/extension.c b/src/backend/commands/extension.c
index aaa08b0..7b791bf 100644
*** a/src/backend/commands/extension.c
--- b/src/backend/commands/extension.c
***************
*** 17,23 ****
* parameter, which is the name of the SQL script to run to install the
* extension.
*
! * Portions Copyright (c) 1996-2010, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
*
*
--- 17,23 ----
* parameter, which is the name of the SQL script to run to install the
* extension.
*
! * Portions Copyright (c) 1996-2011, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
*
*
***************
*** 29,43 ****
#include "postgres.h"
#include <unistd.h>
- #include <dirent.h>
- #include <sys/types.h>
- #include <sys/stat.h>
#include "access/xact.h"
- #include "access/genam.h"
- #include "access/heapam.h"
#include "access/sysattr.h"
- #include "catalog/dependency.h"
#include "catalog/indexing.h"
#include "catalog/namespace.h"
#include "catalog/pg_depend.h"
--- 29,37 ----
***************
*** 51,66 ****
#include "funcapi.h"
#include "mb/pg_wchar.h"
#include "miscadmin.h"
- #include "storage/fd.h"
- #include "utils/array.h"
#include "utils/builtins.h"
#include "utils/fmgroids.h"
- #include "utils/genfile.h"
#include "utils/guc.h"
#include "utils/lsyscache.h"
- #include "utils/memutils.h"
- #include "utils/rel.h"
- #include "utils/syscache.h"
#include "utils/tqual.h"
/*
--- 45,54 ----
***************
*** 68,74 ****
*/
ObjectAddress CreateExtensionAddress;
bool create_extension = false;
! bool create_extension_with_user_data = true;
/*
* Internal data structures, for control file parsing and listings.
--- 56,63 ----
*/
ObjectAddress CreateExtensionAddress;
bool create_extension = false;
!
! static bool create_extension_with_user_data;
/*
* Internal data structures, for control file parsing and listings.
*************** typedef struct extension_fctx
*** 101,146 ****
ExtensionList *installed;
} extension_fctx;
/*
* Utility functions to handle extension related paths
*/
static bool
! filename_extension_control_p(const char *filename)
! {
! return ! ( strcmp(filename, ".") == 0
! || strcmp(filename, "..") == 0
! || strrchr(filename, '.') == NULL
! || strcmp(strrchr(filename, '.'), ".control") != 0 );
! }
!
! /*
! * Given the 'name.control' filename, return the extension's name:
! *
! * `basename $filename .control`
! */
! static char *
! get_extension_name_from_control_filename(const char *filename)
{
! if (filename_extension_control_p(filename))
! {
! char *extname;
! char *slash = strrchr(filename, '/');
! char *dot = strrchr(filename, '.');
!
! if (slash == NULL)
! /* relative filename... */
! slash = (char *)filename;
! else
! /* the file ends with .control and has a / before, that's safe */
! slash++;
! extname = palloc(MAXPGPATH);
! memset(extname, '\0', MAXPGPATH);
! strncpy(extname, slash, dot - slash);
! return extname;
! }
! else
! return NULL;
}
static char *
--- 90,106 ----
ExtensionList *installed;
} extension_fctx;
+ static bool extension_is_relocatable(Oid ext_oid);
+
/*
* Utility functions to handle extension related paths
*/
static bool
! is_extension_control_filename(const char *filename)
{
! const char *extension = strrchr(filename, '.');
! return extension != NULL && strcmp(extension, ".control") == 0;
}
static char *
*************** get_extension_control_basepath(void)
*** 150,156 ****
char *result;
get_share_path(my_exec_path, sharepath);
! result = palloc(MAXPGPATH);
snprintf(result, MAXPGPATH, "%s/contrib", sharepath);
return result;
--- 110,116 ----
char *result;
get_share_path(my_exec_path, sharepath);
! result = (char *) palloc(MAXPGPATH);
snprintf(result, MAXPGPATH, "%s/contrib", sharepath);
return result;
*************** get_extension_control_filename(const cha
*** 163,169 ****
char *result;
get_share_path(my_exec_path, sharepath);
! result = palloc(MAXPGPATH);
snprintf(result, MAXPGPATH, "%s/contrib/%s.control", sharepath, extname);
return result;
--- 123,129 ----
char *result;
get_share_path(my_exec_path, sharepath);
! result = (char *) palloc(MAXPGPATH);
snprintf(result, MAXPGPATH, "%s/contrib/%s.control", sharepath, extname);
return result;
*************** get_extension_absolute_path(const char *
*** 183,189 ****
return (char *)filename;
get_share_path(my_exec_path, sharepath);
! result = palloc(MAXPGPATH);
snprintf(result, MAXPGPATH, "%s/contrib/%s", sharepath, filename);
return result;
--- 143,149 ----
return (char *)filename;
get_share_path(my_exec_path, sharepath);
! result = (char *) palloc(MAXPGPATH);
snprintf(result, MAXPGPATH, "%s/contrib/%s", sharepath, filename);
return result;
*************** parse_extension_control_file(const char
*** 203,210 ****
{
FILE *file;
bool saw_relocatable = false;
! ExtensionControlFile *control =
! (ExtensionControlFile *)palloc(sizeof(ExtensionControlFile));
ConfigVariable *item,
*head = NULL,
*tail = NULL;
--- 163,169 ----
{
FILE *file;
bool saw_relocatable = false;
! ExtensionControlFile *control;
ConfigVariable *item,
*head = NULL,
*tail = NULL;
*************** parse_extension_control_file(const char
*** 216,224 ****
* default values, all string fields are NULL til parsed, except for the
* name, which ain't parsed
*/
control->name = pstrdup(extname);
- control->script =
- control->version = control->comment = control->schema = NULL;
control->encoding = -1;
/*
--- 175,182 ----
* default values, all string fields are NULL til parsed, except for the
* name, which ain't parsed
*/
+ control = (ExtensionControlFile *) palloc0(sizeof(ExtensionControlFile));
control->name = pstrdup(extname);
control->encoding = -1;
/*
*************** parse_extension_control_file(const char
*** 294,305 ****
/*
* script defaults to ${extension-name}.sql
*/
! char *script;
! script = palloc(MAXPGPATH);
! memset(script, '\0', MAXPGPATH);
! sprintf(script, "%s.sql", control->name);
! control->script = script;;
}
if (!saw_relocatable)
--- 252,261 ----
/*
* script defaults to ${extension-name}.sql
*/
! char script[MAXPGPATH];
! snprintf(script, MAXPGPATH, "%s.sql", control->name);
! control->script = pstrdup(script);
}
if (!saw_relocatable)
*************** read_extension_control_file(const char *
*** 319,335 ****
{
char *filename = get_extension_control_filename(extname);
! if (access(filename, R_OK) == 0)
! {
! return parse_extension_control_file(extname, filename);
! }
!
! ereport(ERROR,
! (errmsg("could not read extension control file '%s' "
! "for extension %s", filename, extname)));
!
! /* make compiler happy */
! return NULL;
}
/*
--- 275,281 ----
{
char *filename = get_extension_control_filename(extname);
! return parse_extension_control_file(extname, filename);
}
/*
*************** execute_extension_script(ExtensionContro
*** 413,430 ****
const char *schema, bool user_data)
{
char *filename = get_extension_absolute_path(control->script);
! char *old_cmsgs = NULL, *old_lmsgs = NULL; /* silence compiler */
! bool reset_cmsgs = false, reset_lmsgs = false;
Oid target_schema;
OverrideSearchPath *overridePath;
- /*
- * Set create_extension and create_extension_with_user_data so that the
- * function pg_extension_with_user_data() returns the right value.
- */
- create_extension = true;
- create_extension_with_user_data = user_data;
-
elog(DEBUG1,
"Installing extension '%s' from '%s', in schema %s, %s user data",
control->name,
--- 359,369 ----
const char *schema, bool user_data)
{
char *filename = get_extension_absolute_path(control->script);
! char *save_client_min_messages = NULL,
! *save_log_min_messages = NULL;
Oid target_schema;
OverrideSearchPath *overridePath;
elog(DEBUG1,
"Installing extension '%s' from '%s', in schema %s, %s user data",
control->name,
*************** execute_extension_script(ExtensionContro
*** 441,458 ****
*
* We want to avoid dumping the full script for each of those.
*/
! reset_cmsgs = client_min_messages < WARNING;
! reset_lmsgs = log_min_messages < WARNING;
!
! if (reset_cmsgs)
{
! old_cmsgs = pstrdup((char *)GetConfigOption("client_min_messages", false));
! SetConfigOption("client_min_messages", "warning", PGC_SUSET, PGC_S_SESSION);
}
! if (reset_lmsgs)
{
! old_lmsgs = pstrdup((char *)GetConfigOption("log_min_messages", false));
! SetConfigOption("log_min_messages", "warning", PGC_SUSET, PGC_S_SESSION);
}
target_schema = LookupCreationNamespace(schema);
--- 380,399 ----
*
* We want to avoid dumping the full script for each of those.
*/
! if (client_min_messages < WARNING)
{
! save_client_min_messages =
! pstrdup(GetConfigOption("client_min_messages", false));
! SetConfigOption("client_min_messages", "warning",
! PGC_SUSET, PGC_S_SESSION);
}
!
! if (log_min_messages < WARNING)
{
! save_log_min_messages =
! pstrdup(GetConfigOption("log_min_messages", false));
! SetConfigOption("log_min_messages", "warning",
! PGC_SUSET, PGC_S_SESSION);
}
target_schema = LookupCreationNamespace(schema);
*************** execute_extension_script(ExtensionContro
*** 468,475 ****
--- 409,420 ----
PushOverrideSearchPath(overridePath);
/*
+ * Set create_extension and create_extension_with_user_data so that
+ * the function pg_extension_with_user_data() returns the right value.
* On failure, ensure that create_extension does not remain set.
*/
+ create_extension = true;
+ create_extension_with_user_data = user_data;
PG_TRY();
{
char *sql = read_extension_script_file(control);
*************** execute_extension_script(ExtensionContro
*** 542,559 ****
}
PG_END_TRY();
- /* Reset search path to normal state */
- PopOverrideSearchPath();
-
- if (reset_cmsgs)
- SetConfigOption("client_min_messages",
- old_cmsgs, PGC_SUSET, PGC_S_SESSION);
- if (reset_lmsgs)
- SetConfigOption("log_min_messages",
- old_lmsgs, PGC_SUSET, PGC_S_SESSION);
-
/* reset the current_extension dependency tracker */
create_extension = false;
}
/*
--- 487,504 ----
}
PG_END_TRY();
/* reset the current_extension dependency tracker */
create_extension = false;
+
+ /* Reset search path and GUC variables to normal state */
+ PopOverrideSearchPath();
+
+ if (save_client_min_messages != NULL)
+ SetConfigOption("client_min_messages", save_client_min_messages,
+ PGC_SUSET, PGC_S_SESSION);
+ if (save_log_min_messages != NULL)
+ SetConfigOption("log_min_messages", save_log_min_messages,
+ PGC_SUSET, PGC_S_SESSION);
}
/*
*************** execute_extension_script(ExtensionContro
*** 564,570 ****
void
CreateExtension(CreateExtensionStmt *stmt)
{
-
ListCell *option;
DefElem *d_user_data = NULL;
DefElem *d_schema = NULL;
--- 509,514 ----
*************** CreateExtension(CreateExtensionStmt *stm
*** 594,605 ****
* pg_extension catalog to forbid having two backends concurrently
* creating the same extension.
*/
! if( InvalidOid != get_extension_oid(stmt->extname, true) )
! {
ereport(ERROR,
(errcode(ERRCODE_DUPLICATE_OBJECT),
errmsg("extension \"%s\" already exists", stmt->extname)));
- }
/*
* The control file does not contain any text given to the backend
--- 538,547 ----
* pg_extension catalog to forbid having two backends concurrently
* creating the same extension.
*/
! if (get_extension_oid(stmt->extname, true) != InvalidOid)
ereport(ERROR,
(errcode(ERRCODE_DUPLICATE_OBJECT),
errmsg("extension \"%s\" already exists", stmt->extname)));
/*
* The control file does not contain any text given to the backend
*************** CreateExtension(CreateExtensionStmt *stm
*** 650,662 ****
*/
schema = strVal(d_schema->arg);
! if (!control->relocatable && control->schema != NULL)
{
! if (strcmp(control->schema, schema) != 0)
! ereport(ERROR,
! (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
! errmsg("this extension has to be installed in schema \"%s\"",
! control->schema)));
}
/* If the user is giving us the schema name, it must exists already */
--- 592,604 ----
*/
schema = strVal(d_schema->arg);
! if (!control->relocatable && control->schema != NULL &&
! strcmp(control->schema, schema) != 0)
{
! ereport(ERROR,
! (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
! errmsg("this extension has to be installed in schema \"%s\"",
! control->schema)));
}
/* If the user is giving us the schema name, it must exists already */
*************** CreateExtension(CreateExtensionStmt *stm
*** 725,739 ****
* pg_extension catalog to forbid having two backends concurrently
* creating the same extension.
*/
! if( InvalidOid != get_extension_oid(stmt->extname, true) )
! {
ereport(ERROR,
(errcode(ERRCODE_DUPLICATE_OBJECT),
errmsg("extension \"%s\" already exists", stmt->extname)));
- }
memset(values, 0, sizeof(values));
! MemSet(nulls, false, sizeof(nulls));
values[Anum_pg_extension_extname - 1] =
DirectFunctionCall1(namein, CStringGetDatum(control->name));
--- 667,679 ----
* pg_extension catalog to forbid having two backends concurrently
* creating the same extension.
*/
! if (get_extension_oid(stmt->extname, true) != InvalidOid)
ereport(ERROR,
(errcode(ERRCODE_DUPLICATE_OBJECT),
errmsg("extension \"%s\" already exists", stmt->extname)));
memset(values, 0, sizeof(values));
! memset(nulls, 0, sizeof(nulls));
values[Anum_pg_extension_extname - 1] =
DirectFunctionCall1(namein, CStringGetDatum(control->name));
*************** CreateExtension(CreateExtensionStmt *stm
*** 743,749 ****
values[Anum_pg_extension_relocatable - 1] =
BoolGetDatum(control->relocatable);
! if( control->version == NULL )
nulls[Anum_pg_extension_extversion - 1] = true;
else
values[Anum_pg_extension_extversion - 1] =
--- 683,689 ----
values[Anum_pg_extension_relocatable - 1] =
BoolGetDatum(control->relocatable);
! if (control->version == NULL)
nulls[Anum_pg_extension_extversion - 1] = true;
else
values[Anum_pg_extension_extversion - 1] =
*************** CreateExtension(CreateExtensionStmt *stm
*** 759,765 ****
* Comment on extension
*/
if (control->comment != NULL)
! CreateComments(extensionoid, ExtensionRelationId, 0, control->comment);
/*
* Set the globals create_extension and extension so that any object
--- 699,705 ----
* Comment on extension
*/
if (control->comment != NULL)
! CreateComments(extensionoid, ExtensionRelationId, 0, control->comment);
/*
* Set the globals create_extension and extension so that any object
*************** CreateExtension(CreateExtensionStmt *stm
*** 784,790 ****
}
execute_extension_script(control, schema, user_data);
- return;
}
/*
--- 724,729 ----
*************** DropExtension(DropExtensionStmt *stmt)
*** 852,859 ****
object.objectSubId = 0;
performDeletion(&object, stmt->behavior);
-
- return;
}
/*
--- 791,796 ----
*************** get_extension_name(Oid ext_oid)
*** 939,950 ****
}
/*
! * extension_relocatable_p
*
* Returns true when the extension is marked 'relocatable'
*/
! bool
! extension_relocatable_p(Oid ext_oid)
{
bool relocatable;
Relation rel;
--- 876,887 ----
}
/*
! * extension_is_relocatable
*
* Returns true when the extension is marked 'relocatable'
*/
! static bool
! extension_is_relocatable(Oid ext_oid)
{
bool relocatable;
Relation rel;
*************** pg_extensions(PG_FUNCTION_ARGS)
*** 1192,1198 ****
/* Get an array of installed extensions, but only their names */
installed = extension_list_installed(true);
! fctx = palloc(sizeof(extension_fctx));
fctx->dir.location = get_extension_control_basepath();
fctx->dir.dirdesc = AllocateDir(fctx->dir.location);
fctx->installed = installed;
--- 1129,1135 ----
/* Get an array of installed extensions, but only their names */
installed = extension_list_installed(true);
! fctx = (extension_fctx *) palloc(sizeof(extension_fctx));
fctx->dir.location = get_extension_control_basepath();
fctx->dir.dirdesc = AllocateDir(fctx->dir.location);
fctx->installed = installed;
*************** pg_extensions(PG_FUNCTION_ARGS)
*** 1213,1243 ****
while ((de = ReadDir(fctx->dir.dirdesc, fctx->dir.location)) != NULL)
{
ExtensionControlFile *control;
Datum values[5];
bool nulls[5];
bool is_installed = false;
int i = 0;
HeapTuple tuple;
! if (!filename_extension_control_p(de->d_name))
continue;
control = parse_extension_control_file(
! get_extension_name_from_control_filename(de->d_name),
! get_extension_absolute_path(de->d_name));
memset(values, 0, sizeof(values));
! MemSet(nulls, false, sizeof(nulls));
values[0] = DirectFunctionCall1(namein, CStringGetDatum(control->name));
values[2] = BoolGetDatum(control->relocatable);
! if( control->version == NULL )
nulls[1] = true;
else
values[1] = CStringGetTextDatum(control->version);
! if( control->comment == NULL )
nulls[3] = true;
else
values[3] = CStringGetTextDatum(control->comment);
--- 1150,1184 ----
while ((de = ReadDir(fctx->dir.dirdesc, fctx->dir.location)) != NULL)
{
ExtensionControlFile *control;
+ char *extname;
Datum values[5];
bool nulls[5];
bool is_installed = false;
int i = 0;
HeapTuple tuple;
! if (!is_extension_control_filename(de->d_name))
continue;
+ /* extract extension name from 'name.control' filename */
+ extname = pstrdup(de->d_name);
+ *strrchr(extname, '.') = '\0';
+
control = parse_extension_control_file(
! extname, get_extension_absolute_path(de->d_name));
memset(values, 0, sizeof(values));
! memset(nulls, 0, sizeof(nulls));
values[0] = DirectFunctionCall1(namein, CStringGetDatum(control->name));
values[2] = BoolGetDatum(control->relocatable);
! if (control->version == NULL)
nulls[1] = true;
else
values[1] = CStringGetTextDatum(control->version);
! if (control->comment == NULL)
nulls[3] = true;
else
values[3] = CStringGetTextDatum(control->comment);
*************** pg_extensions(PG_FUNCTION_ARGS)
*** 1247,1253 ****
* expect installations to typically have very few extensions
* installed, we simple rescan the same array each time.
*/
! while( !is_installed && i < fctx->installed->numrefs )
is_installed = 0 == strcmp(fctx->installed->exts[i++].name,
control->name);
--- 1188,1194 ----
* expect installations to typically have very few extensions
* installed, we simple rescan the same array each time.
*/
! while (!is_installed && i < fctx->installed->numrefs)
is_installed = 0 == strcmp(fctx->installed->exts[i++].name,
control->name);
*************** AlterExtensionNamespace_oid(Oid extensio
*** 1289,1300 ****
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
(errmsg("must be superuser to ALTER EXTENSION"))));
! if (!extension_relocatable_p(extensionOid))
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
(errmsg("this extension does not support SET SCHEMA"))));
! object = (ObjectAddress *)palloc(sizeof(ObjectAddress));
object->classId = ExtensionRelationId;
object->objectId = extensionOid;
object->objectSubId = 0;
--- 1230,1241 ----
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
(errmsg("must be superuser to ALTER EXTENSION"))));
! if (!extension_is_relocatable(extensionOid))
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
(errmsg("this extension does not support SET SCHEMA"))));
! object = (ObjectAddress *) palloc(sizeof(ObjectAddress));
object->classId = ExtensionRelationId;
object->objectId = extensionOid;
object->objectSubId = 0;
*************** AlterExtensionNamespace_oid(Oid extensio
*** 1302,1308 ****
/*
* We scan pg_depend to find objects that depend directly on the extension.
*/
! dep = (ObjectAddress *)palloc(sizeof(ObjectAddress));
depRel = heap_open(DependRelationId, AccessShareLock);
--- 1243,1249 ----
/*
* We scan pg_depend to find objects that depend directly on the extension.
*/
! dep = (ObjectAddress *) palloc(sizeof(ObjectAddress));
depRel = heap_open(DependRelationId, AccessShareLock);
*************** AlterExtensionNamespace_oid(Oid extensio
*** 1375,1383 ****
if (HeapTupleIsValid(tup))
{
! values = palloc0(rel->rd_att->natts * sizeof(Datum));
! nulls = palloc0(rel->rd_att->natts * sizeof(bool));
! replaces = palloc0(rel->rd_att->natts * sizeof(bool));
values[Anum_pg_extension_extnamespace - 1] = nspOid;
replaces[Anum_pg_extension_extnamespace - 1] = true;
newtup = heap_modify_tuple(tup, rel->rd_att, values, nulls, replaces);
--- 1316,1324 ----
if (HeapTupleIsValid(tup))
{
! values = (Datum *) palloc0(rel->rd_att->natts * sizeof(Datum));
! nulls = (bool *) palloc0(rel->rd_att->natts * sizeof(bool));
! replaces = (bool *) palloc0(rel->rd_att->natts * sizeof(bool));
values[Anum_pg_extension_extnamespace - 1] = nspOid;
replaces[Anum_pg_extension_extnamespace - 1] = true;
newtup = heap_modify_tuple(tup, rel->rd_att, values, nulls, replaces);
diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index 84c68a7..747fa52 100644
*** a/src/bin/psql/tab-complete.c
--- b/src/bin/psql/tab-complete.c
*************** static const SchemaQuery Query_for_list_
*** 578,583 ****
--- 578,593 ----
" FROM pg_catalog.pg_proc "\
" WHERE proname='%s'"
+ #define Query_for_list_of_extensions \
+ " SELECT pg_catalog.quote_ident(extname) "\
+ " FROM pg_catalog.pg_extension "\
+ " WHERE substring(pg_catalog.quote_ident(extname),1,%d)='%s'"
+
+ #define Query_for_list_of_available_extensions \
+ " SELECT pg_catalog.quote_ident(name) "\
+ " FROM pg_catalog.pg_available_extensions "\
+ " WHERE substring(pg_catalog.quote_ident(name),1,%d)='%s' AND NOT installed"
+
/*
* This is a list of all "things" in Pgsql, which can show up after CREATE or
* DROP; and there is also a query to get a list of them.
*************** static const pgsql_thing_t words_after_c
*** 606,611 ****
--- 616,622 ----
{"DATABASE", Query_for_list_of_databases},
{"DICTIONARY", Query_for_list_of_ts_dictionaries, NULL, true},
{"DOMAIN", NULL, &Query_for_list_of_domains},
+ {"EXTENSION", Query_for_list_of_extensions},
{"FOREIGN DATA WRAPPER", NULL, NULL},
{"FOREIGN TABLE", NULL, NULL},
{"FUNCTION", NULL, &Query_for_list_of_functions},
*************** psql_completion(char *text, int start, i
*** 775,781 ****
pg_strcasecmp(prev3_wd, "TABLE") != 0)
{
static const char *const list_ALTER[] =
! {"AGGREGATE", "CONVERSION", "DATABASE", "DEFAULT PRIVILEGES", "DOMAIN", "FOREIGN DATA WRAPPER", "FOREIGN TABLE", "FUNCTION",
"GROUP", "INDEX", "LANGUAGE", "LARGE OBJECT", "OPERATOR", "ROLE", "SCHEMA", "SERVER", "SEQUENCE", "TABLE",
"TABLESPACE", "TEXT SEARCH", "TRIGGER", "TYPE", "USER", "USER MAPPING FOR", "VIEW", NULL};
--- 786,793 ----
pg_strcasecmp(prev3_wd, "TABLE") != 0)
{
static const char *const list_ALTER[] =
! {"AGGREGATE", "CONVERSION", "DATABASE", "DEFAULT PRIVILEGES", "DOMAIN",
! "EXTENSION", "FOREIGN DATA WRAPPER", "FOREIGN TABLE", "FUNCTION",
"GROUP", "INDEX", "LANGUAGE", "LARGE OBJECT", "OPERATOR", "ROLE", "SCHEMA", "SERVER", "SEQUENCE", "TABLE",
"TABLESPACE", "TEXT SEARCH", "TRIGGER", "TYPE", "USER", "USER MAPPING FOR", "VIEW", NULL};
*************** psql_completion(char *text, int start, i
*** 838,843 ****
--- 850,860 ----
COMPLETE_WITH_LIST(list_ALTERDATABASE);
}
+ /* ALTER EXTENSION <name> */
+ else if (pg_strcasecmp(prev3_wd, "ALTER") == 0 &&
+ pg_strcasecmp(prev2_wd, "EXTENSION") == 0)
+ COMPLETE_WITH_CONST("SET SCHEMA");
+
/* ALTER FOREIGN */
else if (pg_strcasecmp(prev2_wd, "ALTER") == 0 &&
pg_strcasecmp(prev_wd, "FOREIGN") == 0)
*************** psql_completion(char *text, int start, i
*** 1579,1584 ****
--- 1596,1611 ----
pg_strcasecmp(prev_wd, "TEMPLATE") == 0)
COMPLETE_WITH_QUERY(Query_for_list_of_template_databases);
+ /* CREATE EXTENSION */
+ /* Complete with available extensions rather than installed ones. */
+ else if (pg_strcasecmp(prev2_wd, "CREATE") == 0 &&
+ pg_strcasecmp(prev_wd, "EXTENSION") == 0)
+ COMPLETE_WITH_QUERY(Query_for_list_of_available_extensions);
+ /* CREATE EXTENSION <name> */
+ else if (pg_strcasecmp(prev3_wd, "CREATE") == 0 &&
+ pg_strcasecmp(prev2_wd, "EXTENSION") == 0)
+ COMPLETE_WITH_CONST("WITH SCHEMA");
+
/* CREATE FOREIGN */
else if (pg_strcasecmp(prev2_wd, "CREATE") == 0 &&
pg_strcasecmp(prev_wd, "FOREIGN") == 0)
*************** psql_completion(char *text, int start, i
*** 1922,1927 ****
--- 1949,1955 ----
else if ((pg_strcasecmp(prev3_wd, "DROP") == 0 &&
(pg_strcasecmp(prev2_wd, "CONVERSION") == 0 ||
pg_strcasecmp(prev2_wd, "DOMAIN") == 0 ||
+ pg_strcasecmp(prev2_wd, "EXTENSION") == 0 ||
pg_strcasecmp(prev2_wd, "FUNCTION") == 0 ||
pg_strcasecmp(prev2_wd, "INDEX") == 0 ||
pg_strcasecmp(prev2_wd, "LANGUAGE") == 0 ||
diff --git a/src/include/catalog/dependency.h b/src/include/catalog/dependency.h
index 74ed40b..7607c06 100644
*** a/src/include/catalog/dependency.h
--- b/src/include/catalog/dependency.h
*************** typedef enum SharedDependencyType
*** 101,131 ****
SHARED_DEPENDENCY_INVALID = 0
} SharedDependencyType;
! /*
! * Deletion processing requires additional state for each ObjectAddress that
! * it's planning to delete. For simplicity and code-sharing we make the
! * ObjectAddresses code support arrays with or without this extra state.
! */
! typedef struct
! {
! int flags; /* bitmask, see bit definitions below */
! ObjectAddress dependee; /* object whose deletion forced this one */
! } ObjectAddressExtra;
!
! /* ObjectAddressExtra flag bits */
! #define DEPFLAG_ORIGINAL 0x0001 /* an original deletion target */
! #define DEPFLAG_NORMAL 0x0002 /* reached via normal dependency */
! #define DEPFLAG_AUTO 0x0004 /* reached via auto dependency */
! #define DEPFLAG_INTERNAL 0x0008 /* reached via internal dependency */
!
! /* expansible list of ObjectAddresses (used in dependency.c and extension.c) */
! typedef struct
! {
! ObjectAddress *refs; /* => palloc'd array */
! ObjectAddressExtra *extras; /* => palloc'd array, or NULL if not used */
! int numrefs; /* current number of references */
! int maxrefs; /* current size of palloc'd array(s) */
! } ObjectAddresses;
/*
* This enum covers all system catalogs whose OIDs can appear in
--- 101,108 ----
SHARED_DEPENDENCY_INVALID = 0
} SharedDependencyType;
! /* expansible list of ObjectAddresses (private in dependency.c) */
! typedef struct ObjectAddresses ObjectAddresses;
/*
* This enum covers all system catalogs whose OIDs can appear in
diff --git a/src/include/catalog/pg_extension.h b/src/include/catalog/pg_extension.h
index 2ea24a6..32b3677 100644
*** a/src/include/catalog/pg_extension.h
--- b/src/include/catalog/pg_extension.h
***************
*** 3,9 ****
* pg_extension.h
* definition of the system "extension" relation (pg_extension)
*
! * Portions Copyright (c) 1996-2010, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
*
* src/include/catalog/pg_extension.h
--- 3,9 ----
* pg_extension.h
* definition of the system "extension" relation (pg_extension)
*
! * Portions Copyright (c) 1996-2011, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
*
* src/include/catalog/pg_extension.h
*************** typedef FormData_pg_extension *Form_pg_e
*** 53,63 ****
#define Anum_pg_extension_extversion 4
/* ----------------
! * initial contents of pg_extension
* ----------------
*/
- /* btree
- DATA(insert ("PostgreSQL" PG_VERSION _null_));
- */
#endif /* PG_EXTENSION_H */
--- 53,60 ----
#define Anum_pg_extension_extversion 4
/* ----------------
! * pg_extension has no initial contents
* ----------------
*/
#endif /* PG_EXTENSION_H */
diff --git a/src/include/commands/extension.h b/src/include/commands/extension.h
index 11809b8..cc5e7ed 100644
*** a/src/include/commands/extension.h
--- b/src/include/commands/extension.h
***************
*** 4,10 ****
* Extension management commands (create/drop extension).
*
*
! * Portions Copyright (c) 1996-2010, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
*
* src/include/commands/extension.h
--- 4,10 ----
* Extension management commands (create/drop extension).
*
*
! * Portions Copyright (c) 1996-2011, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
*
* src/include/commands/extension.h
***************
*** 30,46 ****
*/
extern ObjectAddress CreateExtensionAddress;
extern bool create_extension;
- extern bool create_extension_with_user_data;
extern void CreateExtension(CreateExtensionStmt *stmt);
extern void DropExtension(DropExtensionStmt *stmt);
extern Oid get_extension_oid(const char *extname, bool missing_ok);
extern char *get_extension_name(Oid ext_oid);
- extern bool extension_relocatable_p(Oid ext_oid);
extern void RemoveExtensionById(Oid extId);
extern void AlterExtensionNamespace(char *name, const char *newschema);
extern void AlterExtensionNamespace_oid(Oid extensionOid, Oid nspOid);
-
#endif /* EXTENSION_H */
--- 30,43 ----
Itagaki Takahiro <itagaki.takahiro@gmail.com> writes:
Hmmm, I like extension_is_relocatable() or so...
Including the above, I wrote a patch on your patch for minor
cleanup. Please merge reasonable parts in it.
After review, I included all your proposed changes, thanks a lot!
Please find attached a new version of the patch, v29, including your
changes and merged against HEAD from this morning (there was no
conflict, but still).
* access() is not portable.
The pre-checking with access() doesn't seems needed because
the same error will be raised in parse_extension_control_file().* There are some dead code in the patch.
For example, you exported ObjectAddresses to public, but it is not
used in extension.c actually. I reverted some of changes.
Thanks, those are due to late refactoring, removal of features and
adjustments etc. Doing that in "free time" rather than full time these
busy days, so I've missed some cleaning.
* Should we support absolute control file paths?
Absolute paths are supported by get_extension_absolute_path(),
but I'm not sure actual use-cases.
Well I don't see no harm in allowing non-core compliant extension
packaging, as this feature is not targeting only BSD compatible Open
Source extensions such as contribs. It seems to me to be a case of
mechanism versus policy, I don't think our policy here should mean that
we alter the mechanism for others.
* Each ereport(ERROR) should have a reasonable errcode unless
they are an internal logic error, and whether the error message
follows our guidline (starting with a lower case character, etc.)
Done.
* Changed create_extension_with_user_data to a static variable.
CreateExtensionAddress and create_extension are still exported.
We could have better names for them -- CurrentExtensionAddress
and in_create_extension? Or, in_create_extension might be
replaced with "CreateExtensionAddress.objectId != InvalidOid".
Well there has been enough discussion about those names I think, current
one where voted by Alvaro and Robert IIRC. I'm open to changes, but
would now prefer to include that in the commiter's work :)
* Added psql tab completion for CREATE/DROP/ALTER EXTENSION.
* Use palloc0() instead of palloc() and memset(0).
* Several code cleanup.
Thanks a lot!
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
Attachments:
extension.v29.patch.gzapplication/octet-streamDownload
�)�BMextension.v29.patch ��{�6�8��}�w�� �X�=nr�j+����^[i����>�D�<�D���x�=��� $HQ�s���V���m0�3�?��n4����S�7Gc����k�m��_����u�c��[^�.��������:���x.tyxq��stq�����
�����6���u����5�8n����i8��E7��Y���x:
G��:6�����+�\��a�����V���?�dG��^����M��o��?�����o��6���\������������l�E�y"Z�l���N��v4m}
�=�`qn���wOG����4�>��h���M&����0�����&������~��0��n4#D�#�I�O�w��OG� %���"J&7qp���GP�]cy,u�Q��|���O��A ��� �i��
�>�"^�� �yD]u-�"����(r
���������r���S(��y~!^�9;j��������$;wq8 j�����yE�5qX�p���]?-]��t4Gok�J�X2�AR��+�'�K#��������z���h��4P �M&q���'qt�'E����m��C4e�]:e ��b��I�0Y@������V���'�~l����"���}1�F�������Y��� ��B�����|�2�� ~�������^O�����
gH���������>�6=�?Tr4q��PL�����Z?��)]C)�+�L�����&k?zur&��x�����9��q����PFD� v�(N*oJ�x�
�Z6�?��+�������������C�h��?�d"&�a"�`2 G7b �]qw�@i����� ��D� I;��
�����rHX��?����^�.�Xh����l���%,����Q+����&��������x�H<����A�EO�=aA��5Zn�7�gW�M����x$�����������T�f&x?�a��y~M'��4��{����!��F�q��<�o����;?�}s����/0=�u�����1�;�C�R�R�r��E��pX�X*����w�",�p#pg��0��M�����}��{��bgV���E�G/���
�C�h���f��������/t�q���+�"��yu�<n�������Ex_���-��0g(�,���E�M��@����JL���W��bs7L�,�B����p�"R���o�!�t�2��������K����t
�������:
:Xc��������;���3�A3}�)h~�U��m������T�Qg�f���p����'��������Qp��d_r8������C�6*�w`�x���s��
.-lT�����Xrp$F��s��YE����K�
��7��t1Uv����]rZ���o���Y�]���,��C�x����}�Qg��������� ����,��/2�L�0���&�(lT����Xrp�B��c��u�y��h|y��������l���]�kU���-���JV�������z�������t�a����((��?u���*�5��w8FA]|��8_�1�Oy�9'SL��s��|������U�\�{~��Fs���K�L5��wXV���yG�����
'5�o��b���c����8�tS�?��&S��d�atc��ISM��wx��f=����/s�Q���<d��V��"��r�0!\G�^��<�H_�K����F$L'� �.g��L�'8~��/"��!h�jx �]���J`��p�����H@�J90l8
'��]?�%w������i�,�v 1!F���6���f�@�}�������������� ����I��t~7W5��#��mp�
,��M�����#(p���#
uTr� |N���;��n��=5PQ/��%%z�8���$����aT�C��`�$���+tpH&y8 ��)$��x�d��ss�I��r3����~&_���+U|T��%N*%�27���&����N�P�X^$w�o1y&�&�����g����h�Ts������d<'���z����`���
P����j���G�d�"�l����]�Y`�t���z��KL&�s.��bSI%��I,?�D2x~Q��]%�����U�����-6G����U��s����������?P�J"�e�U0�j�B�'.�����YS��cU����q��k6��9���+�.1�T~�Y�2�M*]fN�sL*59�T@�f����|Ut�0?=�|'K����!�`N��B��,��p
sL�*��$u9�<����$�sD���"*��q�%&�*�c~$�cz�Gj��q�-���w��P~n��,�S`��t
����U@���]Z��l�Vs�%3J�K�(��sF��b3�E��Q�`������!����q#�����P&!�2b��W�2�ATt� ��G�&�������#q����'�u�jD���SFY�Rt��MU��4�,GQ�����]BK�gt�J�k[����J�BB/A��9�C�Z�DT�%�DV1�����������\s���\m/4W������s�=�\m���b����������������������r�~������l�17�K���s����l/;7�s��v��,�ns�Mc��i,07�������4���F��4�������A�%f��91Xd�y��KL�;?��n00�nn�����.���O���G���lCm5f��wg����6@��C��o�~�9��^D��tD��e�P�y^}z�]������u~�����'<��Wk����
����2_��)�V�3A�����b��y:\����L5�����;���j�������@��(�-�������� ��������'��VNF��D��w4���4~#>��mR��$��q��<50���q��#TZ�'���EMvCWtB=/��T�
~��w
,�=�UXq�Mr��[�d6thM�%�\��Q�o��E���f@>]�q3oLx����v����>�r�d��<&�!w�$X���0�O��.nL�L�d)�l����] spfG�����9����~t������y��Y&�]���.V��vk�p9whh��
�}���Q/x�3�w-�9�|�b�>m��#���g�/$=�W�JL�� ����.:��k.W��J�r?&.��T�^��$��d�'Y��
�����EO!�i��#] �l�������#��C����$��i�A9��)�UQ"�
J*��$�L-sd2)�^WP�o:�0�W �������P����{�m^���'��:Q�*0UZ{Q � ���
U���
@_�o%�*U�o�NU�U�nTV��
����*����*H���J��V_[����%�V^�-`���{�6;��V�.�JK�G� �G� t�~�3B��Zv ���V1 �U����������"�`R�z�7�k��^+`�
��CmP2��1��c��o�������AU��<�qp��B�(X��stz�.���`w���{$5a�O�]�*)���
����tD��D?���9�Y^�z�d�Z�]g��v�I<�*�cB��p��~<��
G�"��%YW2����W�7O��Bk�����o�u������: ��_����Y�]n�z�e�st�j�u�~�z�+��2�ql��:�Zgvyc�<�1������;d�A���q�����qx�q��O|>�BS*��8H�jw��`��!�7�Tz�SD�y��:�z�t��G�M�#�:�I��l���K�z�n��:z$��Pj��Q�C���a�
� &E���#5�O�������*�ac�B��[x������v�������/~������|��M�z-I�'�z_`����3��|�����H��2�o}���M8f�!�.�s����"�2����2�d�w;mr��,��<��3\=���Vvv�Bx����:�r��n�?/t���0�bg�9��Vc�
���A�� ��/*�S��l�o��
��B=�V��2�B��,�S��,(��T'�%���3� �V^y�R�[��r}���
��_+ �;�^�i��]�����$�{F�%����C�n7cr ���T��$�W0�FZ���cfZ 4�~��������;xRzX�7�:�w3�X_E�Q�v����c�!<�`.�]c��"�a�m���u�������a���u���`���upX���"�������c�m�+{�=p���;��#\
��$����O��vC�F#Q��@��M_J�^� ���8��������e�~�h��?'Hu�����5 r���QtxA�^�
���d:b�
&�������)�=��]lO�:�PIH�L�t��VfM�h��������4G�Fv���}�j�\�@�*$Z��cc�h��c\���$�+m_��������-��"�2V�z��M���c|���n~w��(���(��������-��R�8�~|/�� �~cm
+9;o���ej{*..O^7/o��b0�s(�!h`]����Uh�3�JW��|����7 >9vs������������] �i��|����WN�_��'[�1%�[��VF�/s�>:���)�Vr�u��+��cs��4���IG���`Q��u�����2z�I���CQ��w�E���.We/3��X^��'��N��%�N�!H��`��U���W�!�V
�"�7o����+vuv/��`��u��( �y�De�yj.������gdU3kw��\`�fU�7;S
C�Rs���R�^��jWU�r*0�,�����*@v����J���as�;@��Q���Z%j������F�Ul�z���.*&�K$F��xc`���? ���ZU8Ug�-0�R��Bk`��;��h��b9��i$����l��zSd4�[����r�}�dftE���r����_���g���>h����H���z4"P�}q�k�PM�C����������A�m�E`s���<R���C�c�I���SO�S��W��c�6E���X�WI��X�tF+B6����4���B�T4�'~T{$Q���v�����Gk*��Au����W�%v~LT@#��� 7k��X���g�8<Il~�o��`J��J1�.[Fy�����C �yy��8>!��VI�E���k���s�k�������V.�b�$���T|���Je@�`-6��@,����Q��D���@
K�%��|�e `l��y�g�-��%,n�ba�A~n2%R:���J�g$Uf�U,W���,��|&�%��G, ���+�-Z��)�%�����&xeNcI\���
�a��w���`�'/�D��� 7PJ0�ht?D��<m�.��9���]b��������[�����W�qUx�u�
�H�������~z}e��g}��\��1�_D{�r��w�
��<��'���-"�?����A�]DjEb�r�CY�����S1Cu�e_�78v����`��[��\�5 ����#+"[/���<�)(g�����<m���\�.p��0���)�cy$���_&��si�w�S&��;r��x�����qC$x��d2��~7`&����_6H�8_�@u�~ve�]�
������^�O������a��A ���w�A���9��Pu�5�[$������D�!7C@���2h4���*�Fe^-�\l����Y��~�+���i���@�1&��7���+���xa5z��((�,�y{O Q�K,����I�v�~��2�}�����uM�&�2�����p��Un�������tE����:k�kpU�i����}���_Ad`}�N��?�Pe���'a�@T� 3��U��U�,y�E�$���Y��v��:>�<�c.�F�L��O����d��W$� �0�Y�q���8n=��Dd|�)o-�aR�����5��z�������Q���3hwc����H
��!��'�0�q8 v����:���(�i�
%U62�@_�@u�~ve���~ �%�� �|MC�_��y��Q�����Wo��Z�H��~��=����'G��2��FU����En;���M|:gy�:���cSC�B��>�����4��%��
gCd�U����9r$���Sn&lg 2Z'�m�*�8W*��m�6z�`����3��E�;����W�P'�`O���q�����F�+���_`��t��V������j�[�R��?�����,T���o��<<G�� {��J� XP�2�{��^��ojpCT��UI%K�-����6�P����g���3�c������3!��@#P#O�
h��A��!�r�j7ON��F�P�{)P� �����`�����E�����1hP����Y�#H��8������|�e��P������r����� ��<J��RI������r�[(>"d������w�`������iw�)^:A����_��;i)-���j���L��yV� n���B�d�"���{��S�0F��xE��!"���R�(z�����xgoNO�x� �"+" �b?����y��6���L��dOX�4�t�w����qu�-��� ��K�F�&h7�9
����/@�Wv��-���h]^�_���Z/D
w����v��:t��������..��Z�o.[��
bPi�rU��&/������,98W [M���30��;�/�)
�o������lg�1�$B�������J?���Z1�C�J�j���hV9���/����*Ia(�Es �r����Iz��(����`���_U���o*5�_����UF��R]��w�Q���J`X�Jm�P����p?tg�� } ��>(`����� zv~�*�k�����m5����������Z
�E�_����d�T���f#�u�[M�h ;!GAU��Ie��u*�9�\'�C�J��
�`����"+�2X�L(���� � ��=��0��t`y���f�����0���P�dn g�l���G�h'!9gu�t��� -{�1����*H�$R�N\4ki �����,�hyQ���3�{����zJ����tR^:��%+���.���j��VX���-�CV�a��a��+��.(<+���Xitqw
c�/Q��+���%�;S��iR��;��ti�j�j�dLG���z9���"��G�����Ic]��75�t`�r�����,:����77E�8��n�N�v�U"u]�wx7�"I�K5�������(�����P�@�CAv�n���=�2��v�B��brK�G"M���W������e,����MU�`n��sX����8Vc��{"��v$���P�I*��.{# nT"�C�t��N ���1����������yPOP�� �����d�)����������D����q�D,���mgm������~�pDv��>���wypN��@��MR������ tY#g�O�����5�'���f����k* ��~R�*�QooTL9�o���Bo~��D�:�LS?�VK��^
A}J ��s�Q��O\�N[GmD��7��)�| ����X�sg
���`��E���T�v-�K-oC��[Y/%�$I&���G�>pM<�:�����DK�q8����iU1��������0�_�~��3�%b9���'���L�ck�&����.-Ve���mr/7����������^d�h���B��)�����bfs�#K%���3R�I�j����������X��.��NV0G�:Yb~�y�^��F �?��73����'�#Cz�$X2�E�z��^n���������e$V�K���P�Vp:_d*��i1a�����[�4�i����8�TZ-���`P��'1������<2���'���j.�rz�1���0d2�Z������`b�� 4&)���g�T{�%m��]�h�MG�mI�����1�l�d6��V��
�7�TY��8wbE`f�����I��=�V%g�����W �2m0o$Dv�\�l�����}��F������Z��}�jn@�7��*'FIaDM����t�
fml�����z5�����Y�����WwS���-t��d�E�s*Y�m
����m�8�M1Q�tx����?��qo�{jn���r��U��F�iq��g�K��c�J�U��f�z$����8���a$�G{����[[���������
����=.|Q�Y�G<���e �5�}��t��6���������r��e����OH�e>��d]l�����;�5^��e����L����g
:e��?�o�O��T��
K�%�u�X\���t�������^(b��h�a�
D�$�f:\�F���[s���wF��mg�:��y6�A�\gm9��C�8%M����-��@���f���d���]�3gXf��97�U�-�,���V��*�5���
J�K=���
A�(������T4��.�}�eu�
��G��P!���x:�F�a@t�{ t(�
J��#�@On�V2~�9�MGeu��f5�H�����K4�� ���{x���h�Ec\�����=��|��$��t�8��iSD�=�j��<^��/��Y��;u��=���Q�z�}��{�M�!��DP�-�C2���x�SL#.z����&�'�`X�}�hP���/��X�T2�7X����������+v80�����`0y?�zW?�
*�<�_���9j�/M�5����D��4����*����
���>�����={F���=}[��`��duO�z��E3�}]H #�t+���oCP�`7 ��� �� |`�)���q��lft�-�����r�?�8R������}m�-���`��H�s@�!��KDy�J,-
%G"S���U��
���C��
hF�G�h<�0��C�c�s ��X�y�ax"y���Z�}�`=�9�t��5�.)���k�%���9\-�����z ����,=���,4���*����,^�(^C�;Z4*�����Pu^*O�
�������K�����Hyi�qp��
����5���X��� �btf��-j`��"M�����������A��,�/�R��uv�������Ta���y��
��W>�6\���g�<��8-�g���T���SRqF*NH���8�����xO����V��*p���872�
,`r��LF'��V�o3�a� ��S]���*0�|;�73c4$����Rr�"b��R�rB����7�������Sm�*u��l~3��*L�r��j4P��=%�np��&$���rT����
���Q�������f)~4�,f�N�c��Qa��VYi]�8���t���E�0��7f���T��3��?*2�1�@��j2�,����Ve�7���``�k�g���&��x$"������� $�.���V���6s3�n����M�*�P�RU,Xx�bs�ZT&Z!-5�Zf�U#�@7���� ���5�2��l��7��j�������
mEX��a�W�T��JU}[
�2��0i��MeFrS��������u*����"kW��������� .;��W��7Xy.�� �
<��;|�) �. |�m_��'C��:���4����y\����� ����|�A}�<;��]X�x��J&�
=$S�y�����~P�D��M����Ps����Q9�=g W?-���Z�R JZ�����/�J�X[�#�J��P5�X����L�Rx�� G�q��~���a�0���J
��'JgS+�>��q��C�r�����V-���{�
p6�Q������[EP.��V��m.���I�~N�O��Yl�"b��������A:�q6{�2Yh��g��)���PjOnA�� ��A���$.�S>*�6Q���E��>���� ���:R^���5.��>6���K�ut~y\����(]x�"��6��m|�m�����d:w)7���p��d�w��?.a�n��8�Y����E��)f�9������c�`kv�]Y�[�U��J� 8Q{y�zmI�[:�"�[��\��B��;x��\Xw�7���$� ���3������V����o�V>�P���j�3x1���ZR��!�m�.��l9S���e ��@�|4�>�P�1��'�XP�+d������,���]���Z�s�)]BP�\a�;@+���"�@��%��
#.�@��k�\�'����0c1yX���8�*��.
{36�,f��%d�y��T�|�+�
$S[����|���7����~] �7�b>�MY%���[�M����GE�4�/�f�k�zW���Q��ni+K������v��{}�Lu8C�t�[jX�M<�����`�g�mtG��=z�af����-���-�����i��RM��r��}�-�]&5���p������V��8%�S����q���X�v|�\{�����Z�� �'�� �9,���������������x�B-E��]�2��H�Q�j��Da��S��s�g��Yq����-����J��~M_=!��0J�������X �*�[4�*��c����{]�fPb5��c�uwy�*U)��(O�a��U(ZK���<�tY�����"U���V<��0N�|��n������oa�9j��-��>R��0�m d��R���'Q���}����y[22������]1~O��C����|�%��$K�H�a��6��7�����j%��Vl�)@�Vt�����g v��c��x�I��pN������u��^�_��]��~���8��Q�0���yAb��fI�!�����.�2����0�~����������v�4��N�u��Z�H& �����*#���(�g��=*r����/Nm����]�m����R�����'�(���H&�!� �q������� �������?��6d�1�'�s��#K��eBu^��F��9~���U~�(W*%I�<k!�R�.K��g7�?�
��s9�1���� l��]���=�B����W�#�A����G����UR��Db3.E������\�Y��#�mp~E���(�n��O~��\@O�I%�u����V����K��F*��b/
D��jQ�j������pT�?A�LjU��%3��TQ��)�� �5w�w�Jm�.�s��z����II�K;����F_��0U���GQ�����,���j�s
�������%�%��_��v�n�b!���1�74��k
��oHs���--4�
�Q��YD
a'�:���Y���{�D�="��@ ~[�U����.����2����w�Cg��`�<������\;��XL����(4z�oUE�����T�k_����bVT��S�\�)P�J@�Q����<���[��3D���8������iz�^g�}r���@���T�����8
���m��p�U��w�B���?�W�F�l�>6��P�B s�P]������H��s�JA�o�f ��>�>�M'���b�6���<�3Q z�NY
���8�����x�ZV���_u��,��3F���W'g�y�o��L���7��B�]b��;�����31Q`��]�`I9'NQZ�Z���'/�P�'���T
�)�:�uApL��J:@|=j�O��"vo�*pp���y��L���D��q�����WH��<d���39x|�$���o?�����`�!/6�O�@�D���h���6'���li�|�{�[�t����lD�p�D#s�-4��Ej9|���Or�^a�%����Ot���3�_D$D�U��!�}
^a�/����LN��8�D�����,%2��8E����"�]���j1�qM� ^.�ybS,���Q)j��5E0e"
���S�1�1g�]���!�;�V�.-rP����[��B~���R%���c�Y�����;K��j��
���D! 9��O��?D,1_Pa*��w+[��W�mE��`�N���R�V+N��wq��r���Y�,�og��|���U|3������L���2���U���,� ({{)� ��2~2$ ��C��+3��������
Pi����o*S��+tQg���T �����*#T�iP��8����bR���$����SV�O���B����m��O��-#T@����N@>�����'�n8�z �b
D�>���}� wg����^2������H�K>��GWY��S���O���Y���4-��,t������W�g01g�0'��;7�'�*��!+��*��}4�n����xP�3��oAx��"�/F�}���j������aV
�B�u@��bpwB��?����3�@�n�'B��4)��D/�5l����NY�l�$���8�~z���F���e`3W��8j�}��#�D�\��Q:h�����p�����m�oK��l�Lq��f���^>�
����^�F/����f@��K����V�~}0:��l!��e����1��T�N����%��B����GV���"��A�mg�C?�G��F��mXU� ���,KF�)#3u���v����d��t�:J����)�a*6T���$U�(��i���h��9�z��Gq�QxWM/t�#� c�:N���Q@�i��[����������r�|f ���c�:+�L��$��< �����^���u�o��
?�����7�W-q$���'G��*+���*E�w�4�U��|s�>t�
�����p�*z+Caa� ���</��uH�-r�'� �
����W$�W��q?/� a=����L���[�����0�o�:q��<m��� ;{��:�����-Q�'��}�C�������c�0,����Gp/JiC��������_:N������2�]v@��jk�]Z����i]��b�/�Zt����Y�C.h��f����-�z�Lr��P$|���p!-Q�-K}��a4MRo&��}�S=��#.���zw0�������5mzP�T�v���Bi `u�����C85W:G^"��}��T2�g@���Hb}dTX�w��)���H�[
�d:��O&�B�#�����Pa�,[\��������r+�wE�m�fW�U�����]M,����U�1�@g-�2a>H0SV:Q�8���M[�#�p�0oX1_��K,��PN����-�'�`B*��#���U�,/�#�F������@����8��\6M�W���U�
+t�yy��`���l�L���������U�RN3�_$��������~>�(&B������\��m<������B��*M�Aas��Tg1H���Bz���s)���X`v��1���yW���J
I�K�)�q�*��s�+�}&G`�5�sI�wl+��z������bQda�y��?��b2n��S�\���d"JK@���`8��g���:�+@BSx���.�M�B)9��r*+��d��l(�J��{KpL+�x �*������0��/SU�bm9�����+�N�w0�(��O[Gm�����3�xat����Y�����l;����s���'5�������=���P������Et��/b��.�J�j
u7����d ��~�-�����:PEPN7${}v�0KPm��[�L�����������������A �����:n�'���{�����c��&=L�@l ms=��'�-u3A����� �j(= � ���9a�"�0U �U����66���!�{6L�9�6#����i����U ~s�9a�y�V"����N_����-��Ge�^p=���bE�0{�RI�E)QJ�8<�T��;�������w���Xx]/sQqXS���qy/�Nw��.��3
���`�v[{����8�no��a���U#�"U�S���6
�g��`��~U�R�1hW���}����CL�i<Mf��B����u��n'�d� E��������@&wlG�����2���n���`����G�S�0(��I�8 ���)^���Hs:�o�����,�������:������V��~��� ����Z�p�������r6:l66R8�@���j�<����C)p��r������[�G��_=��{����RG��-�Wo��[`3J�lq�v���Y�&�LQZ��2e�V6��M8
U ����zo�sb����E����C�N?��%u4��^)�b'z�����FnYxMJ:wq8�],Df.�%-�|����
�IYH�R?�Z\s��v����JK�ANIn������=vzUJPNv������`�������dg�udgW�S�����\�,8<����my�e������Y���R� ��������4 �]@�'�/��_��A��O��>��]�����Q����(#��wxd1�&!�}N�����u4Q���/~/�/�:��dd~R+�<�IC�����`��I��@>R8w����1G�N;�z���r+���m���?hW��l�����{����):"�Y���Gw�f���<@�]�c�� ���� ����%���������Dp�������<(�~PT�����:U����i��}��������VR��c��)6T���;�3*�dWJQ|Xn�7���O�y����p��k�n��T����;
Xf��[�
��i�[��d\(��
��Ny]�������x��H�� �}^}
B������n����E��������~�[N?�eF\u@�V��$Q4/�x���pf���{@/:��y���%�h�%��qi�(���~���Y[+��M0
b��:����0�n��������:E�����)o��Z�bPJ4�T����$!�[�B(� M������{���cQ�%�,���[*�C"*��3����3|��aq�U�T�y?z���JC�+������� �_D]b�Y&�# X��zmg�4X{0���hgL_�6��C��{F��;\���-��~����C�$���xQ ��'�F��t�L���O�:��M���u�'��#���I�=z�v(�m9���C���� .rj:������Y����-������%�/uN���.���~T�����E��>��j$�����z�pI�)�BO1����`d��7S�@�(my�i������V������[Y���{-.8(E���J�?\��?���Ea��2#��� ���M
����#}�@m�e��0Yr&�u
�U��MkK`cf1t���lX%/JV�:���X1?�d��&����W��h@k�x�"�
��aX �y����.-La����v��z��Z zQ�i�7��S���l�/9� �����m>�A�����)�}� ;��`��������6@WZ�#���N�� x�-��;�}����j��>e`��e)I,h�C�/��J��������S����1m�{_���������c�L��#�,�����HZW��S�o��������*���C���z����V�$rXj�H3
-���BE��p�d�Eo�h:�$�W���9�d�_��8��?��� �g���O�{�]�~\��R�t)�8x�P�m�o�]���n�~_G���~K<Q������|X��o�i����B���-5'b�@����'��<c����!BXC� ����$l�O��j��r}�kky�A����?{�# \��h�� �]���`��}jn�l�� �5x�<���{A�h�����Flk�){���@ &�1�����E�:��n�,�e����n��-
�P,���K��k�a�Qn�����q���pYHQ�������']������6�gzd0�E�R�2)��&�����m����:�{���>&�[}��b.t�@Gpo����So��{���[���[���v�;:j�9t��Kf���������}���kI�#h�t_J\��h�uy�nR�zE�1�T�AOK{���
����|()n���}u�ac��m4�9��mw{k��]a o��V>O%\�9�!�Uh���-�-��;����%t��*Ja�
y��$0�������bU�m���mQ*�W$����� ��"���>���]~W���)�|9GZ>��+;U��.04����%#��u]x�M��5������B��W��P5�H����43�w:*������ ,#�O��������Ra��I`��0���U08��F�{��c���)
H �D�tI;����S�u��Je�v|l�z[[��
�������<��fk����M<���D7��3y�dr����p�ZJ��";�S��������G��-M���1��tth��=AFk������~�����>%����YD���+��y����V�) ��C�����Y&��� �R��tb�Y��"+������������uhm3�wM���d-����8�8.�'�Iw�D1��#_S�``�'�G�� �� ���@�A_��2�I�o���N`�F;�-�/j���:�I�F1i�VT�H���!�;�6!��#����p�PC(������-����Wno:c���;5�x���������<�dx��;�Q�@y��5�`�6�5!%S���=�l�0��|��O�V_���3s�M��xSo��D����-�"��: �c�vxR�"=�������b�c$'��
!.`�M0"i���;�8YSzio/���_����g�5����j/�Y��n�Q��C u��
�����q�Qp����� ���{���0X�� ��Ze������L|3'@"�>��?�����$E��$������e<i�z���$S��������y��UNg����?��.�/�"�����L��(��g���%r�i��)k�$m�I����a���� L����9G��yf��(X�����q[k��mH�).��S�rF����E����`�%�c����:�#����t/�D+4`�=�n:h1
�k`gyA`�.���v�}��u|r����mhA�Fl��4�=T�S��C���A�����;�<�?�Z�$���h ��(��%#��� ��K���(MP8
��nZE�.���
�w&��+�kd�h0���f`w�x�>���^<O�zKa<2�;����6Nn������&���'�������$ � a��F���6���Q�&� }�XUX!���V��M��H�@e�g(xH�5"��F#0��w����dh�5����q��U�A�K�f����;����u�E���a�x� ���X�@��E��p�WP����R��LS]d�C^8�{U����_�� �g�x���*�y��h��99���p�.Gv�4���
���q4�
���� @a���Qp!�>���C]�$V��`�2DmV'Aq��D����[g������������e�C�d:2;sV��.?%�J�{��3-�Y�T�{1E�I���Bs�;�>(*:�H�j&A�3v�D������~�
�b�6k��fF����I�${=����~��pw�|g(?-r�}�!��/���iZ��m�V�_�,�FUR�&��u�$6i�VKC�RwK2��<r-�GJ����)+N ��D# �y��Q��CM�q�Y��v�:�4ai!�?�M����5V�����1�|�������a6(��sG�A�14�H��$b��90��m6RO,)��"6U������nhT�.��A�&�#O�0�7a�;�]��B��C��e��������j��y�H�U���'R��zR:�0��������F�Ux
�X���Z���-q`��?1j#r�([��,v�Q"��#!Ik HF7�
���R�0��5O-G���0:z�<-��������d������9E�1��D��#������7��^�Vmf&���4��R��i��6D�:$G��A��#w��>����� �o>�S"�: ��rN�)������'��������Mc%ub4�[@~��LZ������bw�&O�bLqs%!�3� iyI��7��C���4�"��L��!K������0�\Q�_]���������W�7r�Q5��( �m3 �3>{,��s<N+��;�aW�9�&�6��� �72���� $*��kx�b�(��+�Qf�
��Zm�Hy�A@'_�l�������[1!3'��:��h�;��KU���'&w�:n��(�`�#�p�3�&s�X�9�O���p�V�A�Vg�����oW ���V3��;p�Q����up�!��� 7�o�:�b��1�/p�fY�?�L��K����x+#j��<k�����X��j�*|�}{�*?m��z�|�x�
/���`��?��V���k��!���-r7�v?|��?f�F���:�6����Q;m�l7/_Q�Hl�������9������������:�6��3��r3W�������Er��5���`@� ]��������we1TW��_�DL���:�DC�S�s�s{dnmn�7W�G��p��)�:�/��������H�{[0\�B��L�|� ���_fh�'�B3<��L������KmQ�I�i��1�9R��dK���-����� �D�r�G��Wg���h���<
H������(��\D��&�N
���~4M������������H*���8��&6���������w]z
��}].G�����(}��`������s�o��p�5�&Y����~���a���X����4������t���)���F�Sx5}���P�sb$�r (T/�y��2�U��;jE'������I������tH�e��Y�f�Ht85��&�x$L��
���3���9�������,�v
QzH�p���IA��[/��}��p)���Tw�U�/�3�f�����:b�����.�'�������S�6f |yt���A��n��>�$������&c����0K�B������,8���j������C5�ks��EJr�)m����u�������h��R���d!���!H�\�2�\����V����X>�T��up�����Z�2m�N��c���.+9�fw9 !;s�g����"e��S�vep���a�.��j�Q����������x)�%)��Z��74���H!_�bN ��`��D�5���l��/x�A��BT �����=bC��H���gqpC��2���5��+��h�]#��vO�M_�����i^$�_
����
�5o�� ����[q���a�m���O�Z�lG6�0���q� �a$^�� J�H������[�("���%����^2�;RnE*v@t��7'�"��fCw�G� ���9������s�������L�!�G���VBv�HRU�H�:�������������h�:���y\��C�1�x�q����2b!$������A�.
��]�� {�$�-��+���k��X�7����U�����p��.L��S,�M`:��X���
z���!���kbt��q����
o�2��������ev���lm[��3��;G��,��5yZ�QI
1�����mY-�����e@1CT�t�S�����t��W�U� �,@���PCa���"��P�9�R�KG�����w x����O��@xG��1�D�����O��
��N���������
��������L��+B��,:]��;h��Ly~�k���(?����Z��*�$S2U'�%S���f_��z���|�>S�������45�g-�@I1��(�Se]�����<�����<���p���2�&�B#�|�%�X�)^Bq��I(��E���-J�-�)!YGEZ��cb)���Xd
&�dk�@-���A���e�;��QF��h%�'�*���y�]��R���P2E������.XF%PB#T�"�UIf����>���K2���������uv���M?
����j�>���L��DE�Z_�����*�2=����,@��.�]FycS��_s��E��t�b����]�0L�x�UJ�.N�����]A��T,�z5��5���I'����f����H/4�x��D�M
/��B_��!-����n�z���G��f-�M����z��������q&��o�o���O�\�.����-�[�A#L�)rc�����������S��L��h���6{[��L����4�����,7����<�����:8�G�f�L�Q�"�������.l��C����e�'�.D���qP�<S�����F�2|�O��,�1;*{�9����:bc����L�� ��*���|j���)Y'*�������I�2U@lJ���|���TX;{�C�Y�=T�>����n�M5)[�m��o6�KJ������[)k���,(�e�&�k�B���rR
��z�xy��,��� Os�JB�# �8��W�����
� ����bb�M��gEq�B�
�����24X�������^���?WS<��*_G�)���B��4S�J6�v��Rj��`��;����Z��.q~�A<���������e���y�����/��]���t=���'K���y4�lw^�_�N^� ���c�m3�Q����&~���p[���a����RAG��V(6�c}����������I�����+)INk�l-���;KMr������1SQ��5%g'����1c� ��
���b����OkG�^.������
wP���p��������������j�i,�����\�.������U~
�v�.�'Yz0o�V�f� �F������"��I�{�j���[�����i����&�^��8�����N��\��I���$D���<���"GP��Z��+��
�ul&����UL �p�w��%t�vU�l�,��h�0/,a��[��N��s�Mw�vuPg��`3���C�<5��bP�7�K���p]��#s��ct� R��!��"Z�2�����IME���zG��>~��(4/3��Q��������X�K���`��26���sD1K��N/N�k����t4Rn;:�W��U1s�{qa�C���K
0���9>��mv\� �"���fY�Ac����`�K+�$]*�F<e�-��`��e,8�='���V��HNN��<��:�s(}��A%O��;�*�C��f��l�5,����^.�yP{��.�TD�����K*��Kg2M�{��u�2
�8�MO^!�6�o}�r|��xa���^����p�{;"c����&������gf���;���|d]�p�&����
�Z�
R,a�3S;F�4��\R ��%$������� .�"��e��[?�a%���_^~�����w��1o�
r��q��QV��JfM��Z.���8,C������{%Wv2J���}� �������T��d��3-C��
v!��Ulr���U���c��l��E��E�=(���|7 e��m��viI��]����[�<�j_O
{g�R55����-�oL���<9j|KM[�����-U�VcY�f{��:1�����n����h�)2~X
�%Q�g�1/+���X��Zs6� ��[�S~MY�G~�6��h�����G�:�+��@�a7�@��]����=����6���l$,���v��C���p�:80���g�9�D����m�>)���1�����c��$�G<�L���K-1��Y�H�R���2~#X�oG��VuYH�d��E�W������7�/W�_�A��:��o��;_Jl �����->8����w������$��F��������cE�������m�!Er ^��4z�F ��yX������f���S�4�7#�0�������'�aC�&G���p3>�=������!r�F]h-�Y��r2By��b��� ^���9N��#����o�l�v�]�����_�B�B#!J�53o�/h�\K�o��E_�gN���QO�b�k@v%���*����,u/z�#\��M������m���;���o��R����-(�-]6������oX�����t!�~!m#��a��{f���o�V�F���<;^��R�r�
Z<��5����a���^�n����w�z�����}���x�VzaD
�� b�({k�zn&K��Kc��/^��n�x�m�v��?�` -����:��WWk��]���_��9m]�����G��Fa����4L�� =�����<~��H��1�����i�'3�����9���m>�
r��h�;�0���N&�m���ET9��$���z��y�a ��s�g���lr�c`o�{{K}J�����g�����La���k�s���u��R��C��LT�9��*�A7��C�g���<������r�2:`SQ��f��������l���7U��k_���G�� ��f�5f-�80���Oe���*���/� ������!������+��;����suI|�o5�Y&B�>��h��k��\��%�������JA���[a�I���zF��C ���[�K���>W7������N^0 �'��l��$�I���d�M��ki�CB�(6��[`N�d��R!n{�:��_�S����P����j!���(�<q+��=�3��T���������S���y�[��<;��=��z��V_�A�~s8S��1� ��a"� �pwX�����h�����#�M�
vq�<T��;$���������6��~���;[�����V��sE�Fgv0�������������j]�����b�70��y
���b���y
����+Y���
J���u�����QF��R����b}�;HK�������S��P2�< �wv�t�6r,���-�5�y����bF�X��b�de��_�c�e$��� M %���Q��:L}����s\������@o1C
E�z�K[�o������%B�;�����]0���������!j?i%��~���/:rx��R`�&������s�����.����>e��L1�$��}ows{q��^�\�&�����F���"�0��9pi0H`��%dsA�*m/�}L+$2;�����5���4F��T���?J(�-���N�7���hw��XPy���es�z���������t�r� ��_�)���)en�bO�7 �x�6�)���������d)5���|`�e��7�`g��)���c��2�^S�,�{`�%�q��w�'��Z��� ����.+�r;�3z%��VT���'L�f���<3������*=u�����|H�gGHh����<