Cleanup some -I$(libpq_srcdir) in makefiles

Started by Michael Paquierabout 5 years ago4 messages

michael@paquier.xyz

about 5 years ago

1 attachment(s)

Hi all,

While looking at a patch from David, I have noticed $subject:
/messages/by-id/CAApHDvpgB+vxk=W6OPKidwzZEo6kniFQidNoMzR8P4ROtyky2w@mail.gmail.com

adminpack and old_snapshot have no need for those references as they
don't use libpq. Any objections to a small-ish cleanup that removes
those references, as per the attached?

Thanks,
--
Michael

Attachments:

makefile-libpq.patchtext/x-diff; charset=us-asciiDownload

diff --git a/contrib/adminpack/Makefile b/contrib/adminpack/Makefile
index 630fea7726..851504f4ae 100644
--- a/contrib/adminpack/Makefile
+++ b/contrib/adminpack/Makefile
@@ -4,7 +4,6 @@ MODULE_big = adminpack
 OBJS = \
 	$(WIN32RES) \
 	adminpack.o
-PG_CPPFLAGS = -I$(libpq_srcdir)
 
 EXTENSION = adminpack
 DATA = adminpack--1.0.sql adminpack--1.0--1.1.sql adminpack--1.1--2.0.sql\
diff --git a/contrib/old_snapshot/Makefile b/contrib/old_snapshot/Makefile
index 77c85df322..adb557532f 100644
--- a/contrib/old_snapshot/Makefile
+++ b/contrib/old_snapshot/Makefile
@@ -4,7 +4,6 @@ MODULE_big = old_snapshot
 OBJS = \
 	$(WIN32RES) \
 	time_mapping.o
-PG_CPPFLAGS = -I$(libpq_srcdir)
 
 EXTENSION = old_snapshot
 DATA = old_snapshot--1.0.sql

David Rowley

dgrowleyml@gmail.com

about 5 years ago

In reply to: Michael Paquier (#1)

Re: Cleanup some -I$(libpq_srcdir) in makefiles

On Wed, 23 Dec 2020 at 18:07, Michael Paquier <michael@paquier.xyz> wrote:

While looking at a patch from David, I have noticed $subject:
/messages/by-id/CAApHDvpgB+vxk=W6OPKidwzZEo6kniFQidNoMzR8P4ROtyky2w@mail.gmail.com

adminpack and old_snapshot have no need for those references as they
don't use libpq. Any objections to a small-ish cleanup that removes
those references, as per the attached?

I think these can be safely removed.

In case they have an opinion on this, I've included Tom and Robert as
the authors of 629b3af2 and aecf5ee2.

David

Tom Lane

tgl@sss.pgh.pa.us

about 5 years ago

In reply to: David Rowley (#2)

Re: Cleanup some -I$(libpq_srcdir) in makefiles

David Rowley <dgrowleyml@gmail.com> writes:

On Wed, 23 Dec 2020 at 18:07, Michael Paquier <michael@paquier.xyz> wrote:

adminpack and old_snapshot have no need for those references as they
don't use libpq. Any objections to a small-ish cleanup that removes
those references, as per the attached?

I think these can be safely removed.

In case they have an opinion on this, I've included Tom and Robert as
the authors of 629b3af2 and aecf5ee2.

629b3af2 just moved around the existing -I switch in adminpack/Makefile.
AFAICS that switch goes back to adminpack's introduction, fe59e5666.
It was probably just copied-and-pasted from some other contrib Makefile;
since this Makefile has never actually linked libpq, it's hard to see why
it'd be useful here.

regards, tom lane

Michael Paquier

michael@paquier.xyz

about 5 years ago

In reply to: Tom Lane (#3)

Re: Cleanup some -I$(libpq_srcdir) in makefiles

On Tue, Dec 29, 2020 at 05:06:20PM -0500, Tom Lane wrote:

629b3af2 just moved around the existing -I switch in adminpack/Makefile.
AFAICS that switch goes back to adminpack's introduction, fe59e5666.
It was probably just copied-and-pasted from some other contrib Makefile;
since this Makefile has never actually linked libpq, it's hard to see why
it'd be useful here.

Thanks David and Tom. I got around to apply this cleanup.
--
Michael